From patchwork Fri Apr 10 22:37:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Alexey Dobrovolsky X-Patchwork-Id: 1269207 X-Patchwork-Delegate: ynezz@true.cz Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20170209 header.b=CbbEGRwy; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Nfcos1NZ; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48zXwN1qTVz9sSk for ; Sat, 11 Apr 2020 08:38:09 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:MIME-Version:Message-Id:Date:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MqoM1iVDC6nuROjNctv4QWXNrRX0NqLnJg7MqrQnRDg=; b=CbbEGRwyCYDxd6 PH/p4QErDucnqQvhMAyYcX7dYyaELCnPw+0iqW8Ref8ANRQaSqkoYJi6k9wAnb9BLQeJwus/59PHi vFqyCMRZxB2brhTBLOuw3fMfwdKhUUqBCMqNmAJI5FQhJtxXcE4zCjORuS1Mt2G3sTJiHV3AcgA8l qNbYZ4Ka9PX9fRwmYLLbIcyY/6jcCeF80fSPKmfdnhuf4p2KuJ3nKxWSkZ5JuoJ065qvVZG1DT2WH 0MDqk2q9vPAAmP+6rAxkX39RjuVTOQRv5NxQD3dzU1W6VvDm9ynliATybd2xss2OLYfuAFbDi8bgI FMcJMme7zV3YuAa2RqFQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jN2Hf-00033q-23; Fri, 10 Apr 2020 22:37:59 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jN2Hc-00033P-DX for openwrt-devel@lists.openwrt.org; Fri, 10 Apr 2020 22:37:57 +0000 Received: by mail-wr1-x442.google.com with SMTP id c15so3882419wro.11 for ; Fri, 10 Apr 2020 15:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y1ySqqAAbcTR4GINnKuviPuYKjzlDotyec3ubI3WKuY=; b=Nfcos1NZ1YxeHGA5J/axokTHaIiIXcuLd8n33y4duRTgiJU98l+UVBsKyG2Dn7EeIK X61RVdWTdxVwXDw4L3xFCUJhfOlgBxJOESEDpuVACsHGTioY7msXfin3g/dloCyL585t twEjTv2njRii7qTGorQek15yOn+nwKae68Dm0AekyyySJaLXQD0D45Ssku2KSTITdEX5 vDzcUIOutaEjMT0gPnECqIawN6T9fLiQOO6fFcXStpjeuFYxUoY6MmZeODKri0x3qzUL W7GVfoKmptmx3d66BOIWkG89nlBJHOiPEhmvg4+pGDqOuuBBpvPAvG4nS+sZ9UpbLJ3M NPtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y1ySqqAAbcTR4GINnKuviPuYKjzlDotyec3ubI3WKuY=; b=Oz3bJvNcXskFjaNz8Acl59BtLAZ5g1a0p3by2k40LNPGQnKgOV8Z0MxMj9YSM8XJDy G1YEaKfsIxGLUue+dW3xY/clmfQ2VbmKSlMvM9r9dozLeP/E4EDcQr3jBBdoTSeN+O3A n4FTt/cgZKKOQnXogfxkQLaUIxpbPaDS33e6xa5suq+Z5BLb3RGy1Tjmo9rw3XWJDy92 l5PKGi9Zo7YNQvJuJ/GqNpcra0bZEq/ZCvQvw4zSeOCDkahsJ1U8UNuDx6maXwRnyAXM xp1bzAMARhIhY4FE1aHAJShOHCZREgiMgmTJK6W9Jwbxe3i+owMVb+CS9XiBCjxe8oV4 efGQ== X-Gm-Message-State: AGi0PubUQwZbdRuhWviZHRrXnZogKzw4A16cHOtraDcauT226oi95xCb uDBkZzkMJjnPSVulFJ9+1l8= X-Google-Smtp-Source: APiQypLApYU4Szh04nQpcGXrad66XH3uJ0FinkqwN2hB9IZCkfUuWBdFSYxSB9/9z95apViUyb/c6w== X-Received: by 2002:adf:f750:: with SMTP id z16mr4561830wrp.115.1586558274152; Fri, 10 Apr 2020 15:37:54 -0700 (PDT) Received: from localhost.localdomain (ip-95-220-62-111.bb.netbynet.ru. [95.220.62.111]) by smtp.gmail.com with ESMTPSA id y15sm4733826wro.68.2020.04.10.15.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 15:37:53 -0700 (PDT) From: Alexey Dobrovolsky To: Adrian Schmutzler , John Crispin Date: Sat, 11 Apr 2020 01:37:09 +0300 Message-Id: <20200410223709.1974-1-dobrovolskiy.alexey@gmail.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200410_153756_468004_8D5E78AB X-CRM114-Status: GOOD ( 11.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [dobrovolskiy.alexey[at]gmail.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [OpenWrt-Devel] [RFC PATCH] ramips: remove patches for USB-dwc2 X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexey Dobrovolsky , openwrt-devel@lists.openwrt.org Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org In FS#2738 we can see that patch first introduced in e8ebcff ("ramips: add a explicit reset to dwc2") breaks USB functionality since 18.06. Thus, this patch should be removed. Removed: - 0032-USB-dwc2-add-device_reset.patch Fixes: FS#2738 Fixes: FS#2964 Signed-off-by: Alexey Dobrovolsky --- Notes: I can’t assess whether the root cause of the e8ebcff patch has been fixed in upstream or the patch needs to be rewritten. From the description of the bugs, it is only clear that in the latest OpenWrt versions this patch does not work correctly. I built 18.06.2 and master at 91c61aae200ecf98e332482d395beda819d6a4fa for ZyXEL Keenetic with 0032-USB-dwc2-add-device_reset.patch removed as described in FS#2738 and USB works with a USB flash drive (FS#2964). .../0032-USB-dwc2-add-device_reset.patch | 29 ------------------- .../0032-USB-dwc2-add-device_reset.patch | 29 ------------------- 2 files changed, 58 deletions(-) delete mode 100644 target/linux/ramips/patches-4.14/0032-USB-dwc2-add-device_reset.patch delete mode 100644 target/linux/ramips/patches-5.4/0032-USB-dwc2-add-device_reset.patch diff --git a/target/linux/ramips/patches-4.14/0032-USB-dwc2-add-device_reset.patch b/target/linux/ramips/patches-4.14/0032-USB-dwc2-add-device_reset.patch deleted file mode 100644 index c04e2db661..0000000000 --- a/target/linux/ramips/patches-4.14/0032-USB-dwc2-add-device_reset.patch +++ /dev/null @@ -1,29 +0,0 @@ -From a758e0870c6d1e4b0272f6e7f9efa9face5534bb Mon Sep 17 00:00:00 2001 -From: John Crispin -Date: Sun, 27 Jul 2014 09:49:07 +0100 -Subject: [PATCH 32/53] USB: dwc2: add device_reset() - -Signed-off-by: John Crispin ---- - drivers/usb/dwc2/hcd.c | 3 +++ - 1 file changed, 3 insertions(+) - ---- a/drivers/usb/dwc2/hcd.c -+++ b/drivers/usb/dwc2/hcd.c -@@ -48,6 +48,7 @@ - #include - #include - #include -+#include - - #include - #include -@@ -5215,6 +5216,8 @@ int dwc2_hcd_init(struct dwc2_hsotg *hso - - retval = -ENOMEM; - -+ device_reset(hsotg->dev); -+ - hcfg = dwc2_readl(hsotg->regs + HCFG); - dev_dbg(hsotg->dev, "hcfg=%08x\n", hcfg); - diff --git a/target/linux/ramips/patches-5.4/0032-USB-dwc2-add-device_reset.patch b/target/linux/ramips/patches-5.4/0032-USB-dwc2-add-device_reset.patch deleted file mode 100644 index ec837cda93..0000000000 --- a/target/linux/ramips/patches-5.4/0032-USB-dwc2-add-device_reset.patch +++ /dev/null @@ -1,29 +0,0 @@ -From a758e0870c6d1e4b0272f6e7f9efa9face5534bb Mon Sep 17 00:00:00 2001 -From: John Crispin -Date: Sun, 27 Jul 2014 09:49:07 +0100 -Subject: [PATCH 32/53] USB: dwc2: add device_reset() - -Signed-off-by: John Crispin ---- - drivers/usb/dwc2/hcd.c | 3 +++ - 1 file changed, 3 insertions(+) - ---- a/drivers/usb/dwc2/hcd.c -+++ b/drivers/usb/dwc2/hcd.c -@@ -49,6 +49,7 @@ - #include - #include - #include -+#include - - #include - #include -@@ -5023,6 +5024,8 @@ int dwc2_hcd_init(struct dwc2_hsotg *hso - - retval = -ENOMEM; - -+ device_reset(hsotg->dev); -+ - hcfg = dwc2_readl(hsotg, HCFG); - dev_dbg(hsotg->dev, "hcfg=%08x\n", hcfg); -