diff mbox series

[OpenWrt-Devel] scripts/gen_image_generic.sh: Replace -o with ||

Message ID 20200101021309.22847-1-rosenp@gmail.com
State Superseded
Headers show
Series [OpenWrt-Devel] scripts/gen_image_generic.sh: Replace -o with || | expand

Commit Message

Rosen Penev Jan. 1, 2020, 2:13 a.m. UTC 
-o is not well defined.

Found with shellcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 scripts/gen_image_generic.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jo-Philipp Wich Jan. 1, 2020, 4:03 p.m. UTC | #1 
Hi,

> [...]
> +if [ ! $# -eq 5 ] || [ ! $# -eq 6 ]; then

why not simply "-ne" ?

~ Jo
diff mbox series

Patch

diff --git a/scripts/gen_image_generic.sh b/scripts/gen_image_generic.sh
index 2c57d56f07..81feeaa7d7 100755
--- a/scripts/gen_image_generic.sh
+++ b/scripts/gen_image_generic.sh
@@ -1,10 +1,10 @@ 
 #!/usr/bin/env bash
 # Copyright (C) 2006-2012 OpenWrt.org
 set -e -x
-[ $# == 5 -o $# == 6 ] || {
+if [ ! $# -eq 5 ] || [ ! $# -eq 6 ]; then
     echo "SYNTAX: $0 <file> <kernel size> <kernel directory> <rootfs size> <rootfs image> [<align>]"
     exit 1
-}
+fi
 
 OUTPUT="$1"
 KERNELSIZE="$2"