diff mbox series

[OpenWrt-Devel,fstools,2/2] blockd: don't flush devices list on "hotplug" call

Message ID 20191213100512.31373-3-zajec5@gmail.com
State Accepted
Headers show
Series blocd: fix vlist holding devices | expand

Commit Message

Rafał Miłecki Dec. 13, 2019, 10:05 a.m. UTC 
From: Rafał Miłecki <rafal@milecki.pl>

The point of "hotplug" call is to add or remove a single entry to/from
devices list. Using vlist_update() and vlist_flush() was clearing whole
list (and leaving the last entry in case of adding a devices).

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 blockd.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/blockd.c b/blockd.c
index 7375b2b..e07530c 100644
--- a/blockd.c
+++ b/blockd.c
@@ -237,7 +237,6 @@  block_hotplug(struct ubus_context *ctx, struct ubus_object *obj,
 	if (!device)
 		return UBUS_STATUS_UNKNOWN_ERROR;
 
-	vlist_update(&devices);
 	if (data[MOUNT_REMOVE]) {
 		vlist_delete(&devices, &device->node);
 	} else {
@@ -257,7 +256,6 @@  block_hotplug(struct ubus_context *ctx, struct ubus_object *obj,
 		strcpy(__target, target);
 		vlist_add(&devices, &device->node, device->name);
 	}
-	vlist_flush(&devices);
 
 	return 0;
 }