From patchwork Fri Mar 1 14:40:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adrian Schmutzler X-Patchwork-Id: 1050232 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:e::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=adrianschmutzler.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZwXecOA3"; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 449sYd2z8mz9s4V for ; Sat, 2 Mar 2019 01:41:25 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References: In-Reply-To:Message-Id:Date:To:From:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=vz1qmWJZNTTc1gHijA2RAzOn7/T3DB3o196uSGhQGPc=; b=ZwXecOA30eq0/M/E1RNP+x82yb NYyM20B31kcG4/J7i3MQxzGjxMXEGPz4ItfHRhzEyJfzHKVx7CW8aDLCL8/IpzcamP2zhVkRRTEG3 pP9KjsgPjdE1RwD16a57zRcgOdl1g+NB0vRNdyyAVYaFC/uHZFVV5jX5Zvy6AocFIMZUT3qVguPXE h4AnDy3QrDx45zOyvsdwTx4rljjT03vtZVdE1aL1t968RxTsDBcJYz/xCbWwSSU04dZmjYtVhfvCB EdW7gx+urBPVvNdCLYE9fRTBl4oI17vWAdXqhrJ2yq1yaqhm/ovEEijpIynJPTp6KQShxvoSDyLXr LcUrnW6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjLd-0006np-PD; Fri, 01 Mar 2019 14:41:13 +0000 Received: from mout.kundenserver.de ([212.227.126.134]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzjKy-0005pY-B7 for openwrt-devel@lists.openwrt.org; Fri, 01 Mar 2019 14:40:35 +0000 Received: from localhost.localdomain ([188.194.105.77]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXXhv-1gU6683ryx-00Z03b for ; Fri, 01 Mar 2019 15:40:28 +0100 From: Adrian Schmutzler To: openwrt-devel@lists.openwrt.org Date: Fri, 1 Mar 2019 15:40:19 +0100 Message-Id: <20190301144022.1984-4-freifunk@adrianschmutzler.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190301144022.1984-1-freifunk@adrianschmutzler.de> References: <20190301144022.1984-1-freifunk@adrianschmutzler.de> X-Provags-ID: V03:K1:3RC5GO0JY24k9jYT031n92pj8Ybkw8UGNeykkLIE7P7YGlB971O f56CCoZs7gt0Qdgc6PFBT/KrS/PVtS+vXi6zCqSSBvJEoD13JeaEOxkYIDsV9apQNGsekdz sSL3GGKfYB2/0thkyjNjd0J0o65j439Y7t5qWoM+D2Lg/00oeGRVX2pwbcWR6rYSVKFmhla aFlflBDOn/cg5cwtZfh8A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:G+786nlVUg4=:bPIVZbskUau4XIP/6uhPOu Yqygptur+JDDArjya4zb/OyS0l/uV/4EbSLdQekf7re6TRS2kMx4zSy5b/YSbU8Fo/TdzsHno 5wHdNQIYsTcCxyDK5Q0MAfeX2Ym7Ho41W2hx4Z4EeQiK88weysxIWlVqmhipGZwXODjPU5V0u 7g0U+/Jgl5IteovkqbVDdwhllVtMy1t2kBa+1YM9raCwk+ZVvXpGYPZt8SBoqrSl/eZNSkxKl Lergjyq2F5u974sAKDgqnh5BwVlyFBjZxUDCSZOHe/u/8vDWQvIuJ6G2cIdv6h7F5AJTZGrYK h5E6rBuYjC/EVTUEhZyO0hOEWauPF0681fH9WHNEHaJ/q3/VtepicUREdmGZdORIbeOc8bdqj cJidYcBb2N8mXg871Yp5CUzTEeUPnVTlSmpvetrzLKReTY/hyvnJXuyFZeiJlvdnNXIOrBmeZ eUItC9uNc+L2ROQledcVtZ/4elCnC55CPj0bOh1kx052Ic2amqJu1WhxTkPKgXfkHX8XnVNHI AIbTe3y5+DOcGTy6qnFVtCdGyJCaw0aVF97jhgiy4Qxlh2KWlNutij4UhqwiwZdzSAwPcxMVF fRF8EOgf4MW4ksGsggTM62KHhpNMPOrW+pqWqSYBY7PrFLvjju36ormc6ROkZdJjN5BI2FT5I ELmOOzU+e9f0FA8X53VrAkkfX8/GgPc+OH8R/v+Xh5ZJDiNcrpM4HiDl4vAM6E1KUnecn7pph 35KcwHhNOUsAuHAPUH7uffXrU7GOfPWdo/DBWgKdv3d9Ig8tJQYXCt0NZ/0= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190301_064032_680202_9E5120D1 X-CRM114-Status: UNSURE ( 9.41 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [212.227.126.134 listed in list.dnswl.org] Subject: [OpenWrt-Devel] [PATCH v4 3/6] ar71xx: Speed up mtd extraction in ar71xx.sh X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org Although the amount of data read here is smaller than for the caldata, there still might be some speed gain compared to reading bytewise. And there is no harm... Signed-off-by: Adrian Schmutzler --- Changed in v3: - Changed position of iflag to be consistent Changed in v4: - Rebased --- target/linux/ar71xx/base-files/lib/ar71xx.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/linux/ar71xx/base-files/lib/ar71xx.sh b/target/linux/ar71xx/base-files/lib/ar71xx.sh index 95fa247f4b..f0f6f0398b 100755 --- a/target/linux/ar71xx/base-files/lib/ar71xx.sh +++ b/target/linux/ar71xx/base-files/lib/ar71xx.sh @@ -16,7 +16,7 @@ ar71xx_get_mtd_offset_size_format() { dev=$(find_mtd_part $mtd) [ -z "$dev" ] && return - dd if=$dev bs=1 skip=$offset count=$size 2>/dev/null | hexdump -v -e "1/1 \"$format\"" + dd if=$dev iflag=skip_bytes bs=$size skip=$offset count=1 2>/dev/null | hexdump -v -e "1/1 \"$format\"" } ar71xx_get_mtd_part_magic() { @@ -390,7 +390,7 @@ tplink_pharos_v2_get_model_string() { part=$(find_mtd_part 'product-info') [ -z "$part" ] && return 1 - dd if=$part bs=1 skip=4360 count=64 2>/dev/null | tr -d '\r\0' | head -n 1 + dd if=$part iflag=skip_bytes bs=64 skip=4360 count=1 2>/dev/null | tr -d '\r\0' | head -n 1 } ar71xx_board_detect() {