diff mbox series

[OpenWrt-Devel,v2] base-files: Fix netdev led trigger

Message ID 20181216171003.29307-1-hauke@hauke-m.de
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series [OpenWrt-Devel,v2] base-files: Fix netdev led trigger | expand

Commit Message

Hauke Mehrtens Dec. 16, 2018, 5:10 p.m. UTC
In the upstream netdev led trigger the one mode file was replaced by 3
files named rx, tx and link. Fix the netdev trigger configuration code
to use the modified API.

Fixes: aa3b6a08c56 ("kernel: Replace ledtrig-netdev with upstream backport")
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
 package/base-files/files/etc/init.d/led | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Hannu Nyman Dec. 16, 2018, 5:17 p.m. UTC | #1
Thanks.

The second version of the patch sets all three netdev trigger values properly.


(tested by hand-editing the change to R7800)
diff mbox series

Patch

diff --git a/package/base-files/files/etc/init.d/led b/package/base-files/files/etc/init.d/led
index a3f1224a1a..ff23088e97 100755
--- a/package/base-files/files/etc/init.d/led
+++ b/package/base-files/files/etc/init.d/led
@@ -71,7 +71,9 @@  load_led() {
 		"netdev")
 			[ -n "$dev" ] && {
 				echo $dev > /sys/class/leds/${sysfs}/device_name
-				echo "${mode:-link}" > /sys/class/leds/${sysfs}/mode
+				for m in $mode; do
+					echo 1 > /sys/class/leds/${sysfs}/$m
+				done
 				echo $interval > /sys/class/leds/${sysfs}/interval
 			}
 			;;