| Message ID | 20181216155609.13147-1-hauke@hauke-m.de |
|---|---|
| State | Accepted |
| Delegated to: | Hauke Mehrtens |
| Headers | show |
| Series | [OpenWrt-Devel] base-files: Fix netdev led trigger | expand |
Based on editing the respective file manually in a live router, the patch fixes it partially: Now there is permanently lit wan led in R7800, but no blinking for wan activity. R7800 has the mode as "link tx rx", but the patch only does action for /sys/class/leds/r7800\:white\:wan/link ``` root@router1:~# cat /sys/class/leds/r7800\:white\:wan/rx 0 root@router1:~# cat /sys/class/leds/r7800\:white\:wan/tx 0 root@router1:~# cat /sys/class/leds/r7800\:white\:wan/link 1 ``` I think that the patch should be modified to set all three possible LED actions.
diff --git a/package/base-files/files/etc/init.d/led b/package/base-files/files/etc/init.d/led index a3f1224a1a..570b53df11 100755 --- a/package/base-files/files/etc/init.d/led +++ b/package/base-files/files/etc/init.d/led @@ -71,7 +71,7 @@ load_led() { "netdev") [ -n "$dev" ] && { echo $dev > /sys/class/leds/${sysfs}/device_name - echo "${mode:-link}" > /sys/class/leds/${sysfs}/mode + echo 1 > /sys/class/leds/${sysfs}/${mode:-link} echo $interval > /sys/class/leds/${sysfs}/interval } ;;
In the upstream netdev led trigger the one mode file was replaced by 3 files named rx, tx and link. Fix the netdev trigger configuration code to use the modified API. Fixes: aa3b6a08c56 ("kernel: Replace ledtrig-netdev with upstream backport") Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- package/base-files/files/etc/init.d/led | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)