[OpenWrt-Devel,1/8] firewall: Install config files as 600

Message ID	20180919190333.5753-1-rosenp@gmail.com
State	Accepted
Delegated to:	John Crispin
Headers	show Return-Path: <openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org> From: Rosen Penev <rosenp@gmail.com> To: openwrt-devel@lists.openwrt.org Date: Wed, 19 Sep 2018 12:03:26 -0700 Message-Id: <20180919190333.5753-1-rosenp@gmail.com> summary: Content analysis details: (-0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:532 listed in] [list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rosenp[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Subject: [OpenWrt-Devel] [PATCH 1/8] firewall: Install config files as 600 Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org> Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org
Series	[OpenWrt-Devel,1/8] firewall: Install config files as 600 \| expand [OpenWrt-Devel,1/8] firewall: Install config files as 600 [OpenWrt-Devel,2/8] dnsmasq: Install hotplug and config files as 600 [OpenWrt-Devel,3/8] soloscli: Install hotplug file as 600 [OpenWrt-Devel,4/8] samba36: Install several config files as 600 [OpenWrt-Devel,5/8] comgt: Install hotplug and netifd files as 600 [OpenWrt-Devel,6/8] linux-atm: Install hotplug file as 600 [OpenWrt-Devel,7/8] procd: Install hotplug files as 600 [OpenWrt-Devel,8/8] mac80211: Install hotplug file as 600

Message ID

20180919190333.5753-1-rosenp@gmail.com

State

Accepted

Delegated to:

John Crispin

Headers

From: Rosen Penev <rosenp@gmail.com>
To: openwrt-devel@lists.openwrt.org
Date: Wed, 19 Sep 2018 12:03:26 -0700
Message-Id: <20180919190333.5753-1-rosenp@gmail.com>
Subject: [OpenWrt-Devel] [PATCH 1/8] firewall: Install config files as 600
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "openwrt-devel" <openwrt-devel-bounces@lists.openwrt.org>
Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org

Series

[OpenWrt-Devel,1/8] firewall: Install config files as 600 | expand

Commit Message

Rosen Penev Sept. 19, 2018, 7:03 p.m. UTC

None of the files in firewall are used by non-root.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 package/network/config/firewall/Makefile | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/package/network/config/firewall/Makefile b/package/network/config/firewall/Makefile
index 830a1b268f..2c1224de38 100644
--- a/package/network/config/firewall/Makefile
+++ b/package/network/config/firewall/Makefile
@@ -9,10 +9,10 @@ 
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=firewall
-PKG_RELEASE:=1
+PKG_RELEASE:=2
 
 PKG_SOURCE_PROTO:=git
-PKG_SOURCE_URL=$(PROJECT_GIT)/project/firewall3.git
+PKG_SOURCE_URL:=$(PROJECT_GIT)/project/firewall3.git
 PKG_SOURCE_DATE:=2018-08-13
 PKG_SOURCE_VERSION:=1c4d5bcd1137e61e91dca858fe33d76d7a1dc821
 PKG_MIRROR_HASH:=49f939877a734056455556c90b959c407fd2c4988dc5d86f62a8122ebd7b8899
@@ -50,13 +50,13 @@  define Package/firewall/install
 	$(INSTALL_DIR) $(1)/etc/init.d
 	$(INSTALL_BIN) ./files/firewall.init $(1)/etc/init.d/firewall
 	$(INSTALL_DIR) $(1)/etc/hotplug.d/iface
-	$(INSTALL_DATA) ./files/firewall.hotplug $(1)/etc/hotplug.d/iface/20-firewall
+	$(INSTALL_CONF) ./files/firewall.hotplug $(1)/etc/hotplug.d/iface/20-firewall
 	$(INSTALL_DIR) $(1)/etc/config/
-	$(INSTALL_DATA) ./files/firewall.config $(1)/etc/config/firewall
+	$(INSTALL_CONF) ./files/firewall.config $(1)/etc/config/firewall
 	$(INSTALL_DIR) $(1)/etc/
-	$(INSTALL_DATA) ./files/firewall.user $(1)/etc/firewall.user
+	$(INSTALL_CONF) ./files/firewall.user $(1)/etc/firewall.user
 	$(INSTALL_DIR) $(1)/usr/share/fw3
-	$(INSTALL_DATA) $(PKG_BUILD_DIR)/helpers.conf $(1)/usr/share/fw3
+	$(INSTALL_CONF) $(PKG_BUILD_DIR)/helpers.conf $(1)/usr/share/fw3
 endef
 
 $(eval $(call BuildPackage,firewall))

[OpenWrt-Devel,1/8] firewall: Install config files as 600

Commit Message

Patch