diff mbox series

[OpenWrt-Devel,3/5] ar71xx: rbspi: mark rb911L user led as active low

Message ID 20180729101500.8621-4-hacks@slashdirt.org
State Accepted
Delegated to: John Crispin
Headers show
Series several fixes for mach-rbspi.c / correct support for wAP R | expand

Commit Message

Thibaut July 29, 2018, 10:14 a.m. UTC 
The active_low flag was missing for the user LED. This LED is open drain
(confirmed in OEM source) and open drain only makes sense for active low
GPIOs.

The two wireless LEDs mentioned in the comments are also #defined for
future reference.

Signed-off-by: Thibaut VARÈNE <hacks@slashdirt.org>
Tested-by: Ryan Mounce <ryan@mounce.com.au>
---
 target/linux/ar71xx/files/arch/mips/ath79/mach-rbspi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/target/linux/ar71xx/files/arch/mips/ath79/mach-rbspi.c b/target/linux/ar71xx/files/arch/mips/ath79/mach-rbspi.c
index ad67c6e869..4aff7df55b 100644
--- a/target/linux/ar71xx/files/arch/mips/ath79/mach-rbspi.c
+++ b/target/linux/ar71xx/files/arch/mips/ath79/mach-rbspi.c
@@ -255,6 +255,8 @@  static struct gpio_led rb952_leds[] __initdata = {
 
 
 /* RB 962UiGS-5HacT2HnT gpios */
+#define RB962_WIFI_LED_1	1
+#define RB962_WIFI_LED_2	2
 #define RB962_GPIO_POE_STATUS	2
 #define RB962_GPIO_POE_POWER	3
 #define RB962_GPIO_LED_USER	12
@@ -520,7 +522,7 @@  static struct platform_device rbwapgsc_phy_device = {
 #define RB911L_GPIO_LED_ETH	20
 #define RB911L_GPIO_LED_POWER	11
 #define RB911L_GPIO_LED_USER	3
-#define RB911L_GPIO_PIN_HOLE	14 /* for reference */
+#define RB911L_GPIO_PIN_HOLE	14 /* for reference, active low */
 
 static struct gpio_led rb911l_leds[] __initdata = {
 	{
@@ -551,6 +553,7 @@  static struct gpio_led rb911l_leds[] __initdata = {
 		.name = "rb:green:power",
 		.gpio = RB911L_GPIO_LED_POWER,
 		.default_state = LEDS_GPIO_DEFSTATE_ON,
+		.active_low = 1,
 		.open_drain = 1,
 	}, {
 		.name = "rb:green:user",