diff mbox series

[OpenWrt-Devel,5/5] net: ethernet: mediatek: enhance with avoiding superfluous assignment inside mtk_get_ethtool_stats

Message ID 20180704232008.3310-5-rosenp@gmail.com
State Rejected
Delegated to: John Crispin
Headers show
Series [OpenWrt-Devel,1/5] ramips: ethernet: Switch to of_device_get_match_data | expand

Commit Message

Rosen Penev July 4, 2018, 11:20 p.m. UTC 
From: Sean Wang <sean.wang@mediatek.com>

data_src is unchanged inside the loop, so this patch moves
the assignment to outside the loop to avoid unnecessarily
assignment

Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
 .../ramips/files-4.14/drivers/net/ethernet/mediatek/ethtool.c  | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/ethtool.c b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/ethtool.c
index 5732c28536..edadf4fc30 100644
--- a/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/ethtool.c
+++ b/target/linux/ramips/files-4.14/drivers/net/ethernet/mediatek/ethtool.c
@@ -192,8 +192,9 @@  static void fe_get_ethtool_stats(struct net_device *dev,
 		}
 	}
 
+	data_src = &hwstats->tx_bytes;
+
 	do {
-		data_src = &hwstats->tx_bytes;
 		data_dst = data;
 		start = u64_stats_fetch_begin_irq(&hwstats->syncp);