| Message ID | 20141225014908.7ebf4d02@erker.lan |
|---|---|
| State | Changes Requested |
| Headers | show |
On 2014-12-25 01:49, Lars Kruse wrote: > Hi, > > dnsmasq supports an option "--quiet-dhcp" in order to remove DHCP log messages > from the system log. We would like to use this option in our wireless community > in order to reduce the amount of private data (MAC addresses) exposed in the > logs. > > cheers, > Lars > > > Description: > > add --quiet-dhcp option for dnsmasq (usable via "quiet_dhcp" in UCI) > > This reduces the amount of private information (MAC addresses) being logged. > > Signed-off-by: Lars Kruse <devel@sumpfralle.de> The description should be first in the email body without "Description:" You can add extra comments after the --- lines (this ensures that git-am ignores them). > --- > --- a/openwrt/package/network/services/dnsmasq/files/dnsmasq.init > +++ b/openwrt/package/network/services/dnsmasq/files/dnsmasq.init What kind of tree was this patch generated from? For the usual git trees it should be a/package/... instead of a/openwrt/package/... > @@ -123,6 +123,7 @@ dnsmasq() { > append_bool "$cfg" nonwildcard "--bind-interfaces" > append_bool "$cfg" fqdn "--dhcp-fqdn" > append_bool "$cfg" proxydnssec "--proxy-dnssec" > + append_bool "$cfg" quiet_dhcp "--quiet-dhcp" The patch is whitespace mangled. Please check your email client settings. - Felix
Hi, >> --- a/openwrt/package/network/services/dnsmasq/files/dnsmasq.init >> +++ b/openwrt/package/network/services/dnsmasq/files/dnsmasq.init > What kind of tree was this patch generated from? For the usual git trees > it should be a/package/... instead of a/openwrt/package/... > >> @@ -123,6 +123,7 @@ dnsmasq() { >> append_bool "$cfg" nonwildcard "--bind-interfaces" >> append_bool "$cfg" fqdn "--dhcp-fqdn" >> append_bool "$cfg" proxydnssec "--proxy-dnssec" >> + append_bool "$cfg" quiet_dhcp "--quiet-dhcp" Since the other options omit the word separation it is maybe better to call this one "quietdhcp" for the sake of consistency. I'd also argue for making this the default... ~ Jow
--- a/openwrt/package/network/services/dnsmasq/files/dnsmasq.init +++ b/openwrt/package/network/services/dnsmasq/files/dnsmasq.init @@ -123,6 +123,7 @@ dnsmasq() { append_bool "$cfg" nonwildcard "--bind-interfaces" append_bool "$cfg" fqdn "--dhcp-fqdn" append_bool "$cfg" proxydnssec "--proxy-dnssec" + append_bool "$cfg" quiet_dhcp "--quiet-dhcp" append_parm "$cfg" dhcpscript "--dhcp-script" append_parm "$cfg" cachesize "--cache-size"
Hi, dnsmasq supports an option "--quiet-dhcp" in order to remove DHCP log messages from the system log. We would like to use this option in our wireless community in order to reduce the amount of private data (MAC addresses) exposed in the logs. cheers, Lars Description: add --quiet-dhcp option for dnsmasq (usable via "quiet_dhcp" in UCI) This reduces the amount of private information (MAC addresses) being logged. Signed-off-by: Lars Kruse <devel@sumpfralle.de> --- --