| Message ID | 20141212225906.GA7534@makrotopia.org |
|---|---|
| State | Changes Requested |
| Delegated to: | John Crispin |
| Headers | show |
i think this should the opt-in not opt-out. target maintainers should set it only if they have boards with the env stored inside ubi. John On 12/12/2014 23:59, Daniel Golle wrote: > We've been carrying around that patch for a while now and didn't > ever encounter any problem on non-UBI flashtypes. So I guess the > 8kB extra space won't hurt on modern platforms which might even make > use of their U-Boot environment being stored in UBI. > > Let me know if there are any targets missing in the blacklist > (i.e. platforms/SoCs without the option to deploy NAND flash or > commonly found with only 4MB flash where those 8kB might actually > matter, or platforms where we haven't got U-Boot, ...) > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > package/boot/uboot-envtools/Config.in | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/package/boot/uboot-envtools/Config.in b/package/boot/uboot-envtools/Config.in > index 9fd8103..10c03f9 100644 > --- a/package/boot/uboot-envtools/Config.in > +++ b/package/boot/uboot-envtools/Config.in > @@ -1,7 +1,13 @@ > config UBOOT_ENVTOOLS_UBI > bool "Support environment in UBI volume" > depends on PACKAGE_uboot-envtools > - default n > + depends on !TARGET_adm5120 && !TARGET_adm8668 && !TARGET_ar7 && \ > + !TARGET_ar71xx_generic && !TARGET_atheros && \ > + !TARGET_au1000 && !TARGET_avr32 && !TARGET_ramips_rt288x && \ > + !TARGET_ramips_rt305x && !TARGET_uml && !TARGET_x86 && \ > + !TARGET_x86_64 > + > + default y > help > Add support for reading and writing U-Boot environment > stored in UBI volume(s). >
diff --git a/package/boot/uboot-envtools/Config.in b/package/boot/uboot-envtools/Config.in index 9fd8103..10c03f9 100644 --- a/package/boot/uboot-envtools/Config.in +++ b/package/boot/uboot-envtools/Config.in @@ -1,7 +1,13 @@ config UBOOT_ENVTOOLS_UBI bool "Support environment in UBI volume" depends on PACKAGE_uboot-envtools - default n + depends on !TARGET_adm5120 && !TARGET_adm8668 && !TARGET_ar7 && \ + !TARGET_ar71xx_generic && !TARGET_atheros && \ + !TARGET_au1000 && !TARGET_avr32 && !TARGET_ramips_rt288x && \ + !TARGET_ramips_rt305x && !TARGET_uml && !TARGET_x86 && \ + !TARGET_x86_64 + + default y help Add support for reading and writing U-Boot environment stored in UBI volume(s).
We've been carrying around that patch for a while now and didn't ever encounter any problem on non-UBI flashtypes. So I guess the 8kB extra space won't hurt on modern platforms which might even make use of their U-Boot environment being stored in UBI. Let me know if there are any targets missing in the blacklist (i.e. platforms/SoCs without the option to deploy NAND flash or commonly found with only 4MB flash where those 8kB might actually matter, or platforms where we haven't got U-Boot, ...) Signed-off-by: Daniel Golle <daniel@makrotopia.org> --- package/boot/uboot-envtools/Config.in | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)