Message ID | 1770ecac-58a3-b4f4-2317-5a13053f5143@navigue.com |
---|---|
State | Superseded |
Headers | show |
Series | [OpenWrt-Devel] Allow VLAN filtering if needed. | expand |
On 2018-11-15 16:11, Jonathan Thibault wrote: > Greetings, > > I would like to propose enabling CONFIG_BRIDGE_VLAN_FILTERING on OpenWRT > releases. > > This allows us to use the bridge as a managed switch and gracefully > handle mixed tagged and untagged frames. Prior to this, the only > alternative was creating one bridge per vlan which quickly becomes a > nightmare and still won't let you mix both tagged and untagged frames on > the physical port without some complex ebtables magic. > > This is in line with the notion that OpenWRT is the network go-to swiss > army knife when you need a nice set-and-forget, low maintenance box to > handle a specific task. > > Current builds of the ip-bridge package already fully support this > feature so the only requirement is enabling the kernel config. > > This is disabled by default so existing bridge configurations will not > be affected. This patch only gives the ability to turn it on with an > 'ip link' command. If there is interest, I could look into making the > feature accessible via uci configuration. > > It causes about 3.1% hit on raw bridging speed, which is relatively > trivial considering that I had to use 300 byte packets to strain the CPU > enough to notice a slowdown at all. The ER8 would chug along at wire > speed otherwise, and that's using only one core. Since the typical > bridge use case on OpenWRT is wireless, I doubt it would be noticeable > at all. > > > diff --git a/target/linux/generic/config-4.14 > b/target/linux/generic/config-4.14 > index aa227ec6bf..a385fe3f24 100644 > --- a/target/linux/generic/config-4.14 > +++ b/target/linux/generic/config-4.14 > @@ -623,7 +623,7 @@ CONFIG_BRIDGE=y > # CONFIG_BRIDGE_EBT_STP is not set > # CONFIG_BRIDGE_EBT_T_FILTER is not set > # CONFIG_BRIDGE_EBT_T_NAT is not set > -# CONFIG_BRIDGE_EBT_VLAN is not set > +CONFIG_BRIDGE_EBT_VLAN=y Wrong config symbol? - Felix
Jonathan Thibault <jonathan@navigue.com> writes: > I would like to propose enabling CONFIG_BRIDGE_VLAN_FILTERING on > OpenWRT releases. Yes, please. This is more or less required for DSA. Bjørn
diff --git a/target/linux/generic/config-4.14 b/target/linux/generic/config-4.14 index aa227ec6bf..a385fe3f24 100644 --- a/target/linux/generic/config-4.14 +++ b/target/linux/generic/config-4.14 @@ -623,7 +623,7 @@ CONFIG_BRIDGE=y # CONFIG_BRIDGE_EBT_STP is not set # CONFIG_BRIDGE_EBT_T_FILTER is not set # CONFIG_BRIDGE_EBT_T_NAT is not set -# CONFIG_BRIDGE_EBT_VLAN is not set +CONFIG_BRIDGE_EBT_VLAN=y CONFIG_BRIDGE_IGMP_SNOOPING=y # CONFIG_BRIDGE_NETFILTER is not set # CONFIG_BRIDGE_NF_EBTABLES is not set diff --git a/target/linux/generic/config-4.9 b/target/linux/generic/config-4.9 index 83abfdc8ff..6bcb82adec 100644 --- a/target/linux/generic/config-4.9 +++ b/target/linux/generic/config-4.9 @@ -598,7 +598,7 @@ CONFIG_BRIDGE=y CONFIG_BRIDGE_IGMP_SNOOPING=y # CONFIG_BRIDGE_NETFILTER is not set # CONFIG_BRIDGE_NF_EBTABLES is not set -# CONFIG_BRIDGE_VLAN_FILTERING is not set +CONFIG_BRIDGE_VLAN_FILTERING=y # CONFIG_BROADCOM_PHY is not set CONFIG_BROKEN_ON_SMP=y # CONFIG_BSD_DISKLABEL is not set