diff mbox

[OpenWrt-Devel,v2] brcm2708: implement sysupgrade image check

Message ID 1460046411-17102-1-git-send-email-chunkeey@googlemail.com
State Changes Requested
Headers show

Commit Message

Christian Lamparter April 7, 2016, 4:26 p.m. UTC
Implement a crude but functioning sysupgrade image check for the
Raspberry Pi. The code only checks if the master boot record boot
signature (0x55aa) is present in the first 512-bytes at the correct
location. This can prevent the odd bricking of a system when flashing
the wrong file.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
---
 .../linux/brcm2708/base-files/lib/upgrade/platform.sh   | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/target/linux/brcm2708/base-files/lib/upgrade/platform.sh b/target/linux/brcm2708/base-files/lib/upgrade/platform.sh
index 1d4b694..631aa69 100644
--- a/target/linux/brcm2708/base-files/lib/upgrade/platform.sh
+++ b/target/linux/brcm2708/base-files/lib/upgrade/platform.sh
@@ -1,5 +1,20 @@ 
+get_magic_at() {
+	local file="$1"
+	local pos="$2"
+	get_image "$file" | dd bs=1 count=2 skip="$pos" 2>/dev/null | hexdump -v -n 2 -e '1/1 "%02x"'
+}
+
 platform_check_image() {
-	# i know no way to verify the image
+	local file="$1"
+	local magic
+
+	magic=$(get_magic_at "$file" 510)
+
+	[ "$magic" != "55aa" ] && {
+		echo "Failed to verify MBR boot signature."
+		return 1
+	}
+
 	return 0;
 }