From patchwork Fri Dec 18 04:24:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Dickinson X-Patchwork-Id: 558733 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id C297A1401DA for ; Fri, 18 Dec 2015 15:28:16 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 7B74728C17E; Fri, 18 Dec 2015 05:25:26 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 23DEB28BC4B for ; Fri, 18 Dec 2015 05:24:56 +0100 (CET) X-policyd-weight: using cached result; rate:hard: -8.5 Received: from s1.neomailbox.net (s1.neomailbox.net [5.148.176.57]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Fri, 18 Dec 2015 05:24:51 +0100 (CET) From: openwrt@daniel.thecshore.com To: openwrt-devel@lists.openwrt.org Date: Thu, 17 Dec 2015 23:24:56 -0500 Message-Id: <1450412696-108600-5-git-send-email-openwrt@daniel.thecshore.com> In-Reply-To: <1450412696-108600-1-git-send-email-openwrt@daniel.thecshore.com> References: <1450412696-108600-1-git-send-email-openwrt@daniel.thecshore.com> Subject: [OpenWrt-Devel] [PATCH 4/4] images imagebuilder: Allow to add sanitized extra name X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" From: Daniel Dickinson For final output image names allow user to add an extra string (which is sanitized). This is particularly useful with ImageBuilder where you may generate multiple images from the same base and for the same board, with different package selections and additional files (via FILES=). Signed-off-by: Daniel Dickinson --- include/image.mk | 3 ++- target/imagebuilder/files/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/include/image.mk b/include/image.mk index 445b1f0..6612abe 100644 --- a/include/image.mk +++ b/include/image.mk @@ -31,8 +31,9 @@ $(shell echo $(call tolower,$(1)) | sed 's/_/-/g') endef DIST_SANITIZED:=$(call sanitize,$(VERSION_DIST)) +EXTRA_NAME_SANITIZED=$(call sanitize,$(EXTRA_IMAGE_NAME)) -IMG_PREFIX:=$(DIST_SANITIZED)-$(if $(CONFIG_VERSION_FILENAMES),$(VERSION_NUMBER)-)$(BOARD)$(if $(SUBTARGET),-$(SUBTARGET)) +IMG_PREFIX:=$(DIST_SANITIZED)-$(if $(CONFIG_VERSION_FILENAMES),$(VERSION_NUMBER)-)$(if $(EXTRA_NAME_SANITIZED),$(EXTRA_NAME_SANITIZED)-)$(BOARD)$(if $(SUBTARGET),-$(SUBTARGET)) MKFS_DEVTABLE_OPT := -D $(INCLUDE_DIR)/device_table.txt diff --git a/target/imagebuilder/files/Makefile b/target/imagebuilder/files/Makefile index f612ea9..439ff2c 100644 --- a/target/imagebuilder/files/Makefile +++ b/target/imagebuilder/files/Makefile @@ -43,7 +43,7 @@ Building images: make image PACKAGES=" [ [ ...]]" # include extra packages make image FILES="" # include extra files from make image BIN_DIR="" # alternative output directory for the images - + make image EXTRA_IMAGE_NAME="" # Add this to the output image filename (sanitized) endef $(eval $(call shexport,Helptext)) @@ -174,7 +174,7 @@ package_postinst: FORCE build_image: FORCE @echo @echo Building images... - $(NO_TRACE_MAKE) -C target/linux/$(BOARD)/image install TARGET_BUILD=1 IB=1 \ + $(NO_TRACE_MAKE) -C target/linux/$(BOARD)/image install EXTRA_IMAGE_NAME=$(EXTRA_IMAGE_NAME) TARGET_BUILD=1 IB=1 \ $(if $(USER_PROFILE),PROFILE="$(USER_PROFILE)") clean: