From patchwork Mon Nov 2 11:32:29 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hannu Nyman X-Patchwork-Id: 538976 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id F1C22140D98 for ; Mon, 2 Nov 2015 22:32:58 +1100 (AEDT) Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id BD779280314; Mon, 2 Nov 2015 12:30:56 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id DC5AF2800A1 for ; Mon, 2 Nov 2015 12:30:50 +0100 (CET) X-policyd-weight: using cached result; rate: -5.5 Received: from filtteri1.pp.htv.fi (filtteri1.pp.htv.fi [213.243.153.184]) by arrakis.dune.hu (Postfix) with ESMTP for ; Mon, 2 Nov 2015 12:30:50 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by filtteri1.pp.htv.fi (Postfix) with ESMTP id F1E2321BABD; Mon, 2 Nov 2015 13:32:36 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at pp.htv.fi Received: from smtp5.welho.com ([213.243.153.39]) by localhost (filtteri1.pp.htv.fi [213.243.153.184]) (amavisd-new, port 10024) with ESMTP id GIZo1QAsc-zS; Mon, 2 Nov 2015 13:32:33 +0200 (EET) Received: from localhost.localdomain (87-100-236-80.bb.dnainternet.fi [87.100.236.80]) by smtp5.welho.com (Postfix) with ESMTP id E5D7A5BC004; Mon, 2 Nov 2015 13:32:32 +0200 (EET) From: Hannu Nyman To: openwrt-devel@lists.openwrt.org Date: Mon, 2 Nov 2015 13:32:29 +0200 Message-Id: <1446463949-8761-1-git-send-email-hannu.nyman@iki.fi> X-Mailer: git-send-email 2.5.0 Cc: Hannu Nyman Subject: [OpenWrt-Devel] [PATCH] hostapd: add default value to eapol_version (#20641) X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" r46861 introduced a new option eapol_version to hostapd, but did not provide a default value. When the option value is evaluated, the non-existing value causes errors to the systen log: "netifd: radio0: sh: out of range" Add a no-op default value 0 for eapol_version. Only values 1 or 2 are actually passed on, so 0 will not change the default action in hostapd. Signed-off-by: Hannu Nyman --- References: https://dev.openwrt.org/changeset/46861/ https://dev.openwrt.org/ticket/20641 Error message: Mon Nov 2 12:34:14 2015 daemon.notice netifd: radio0 (6249): sh: out of range Mon Nov 2 12:34:14 2015 daemon.notice netifd: radio1 (6259): sh: out of range Mon Nov 2 12:34:14 2015 daemon.notice netifd: radio0 (6249): Configuration file: /var/run/hostapd-phy0.conf Comparison causing the error: [ "$eapol_version" -ge "1" -a "$eapol_version" -le "2" ] && append bss_conf "eapol_version=$eapol_version" "$N" package/network/services/hostapd/files/netifd.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/package/network/services/hostapd/files/netifd.sh b/package/network/services/hostapd/files/netifd.sh index bdfcbb2..9b40a23 100644 --- a/package/network/services/hostapd/files/netifd.sh +++ b/package/network/services/hostapd/files/netifd.sh @@ -194,6 +194,7 @@ hostapd_set_bss_options() { set_default hidden 0 set_default wmm 1 set_default uapsd 1 + set_default eapol_version 0 append bss_conf "ctrl_interface=/var/run/hostapd" if [ "$isolate" -gt 0 ]; then