From patchwork Wed Mar 18 07:18:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 451236 X-Patchwork-Delegate: jogo@openwrt.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from arrakis.dune.hu (arrakis.dune.hu [78.24.191.176]) (using TLSv1.1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 15C821400D5 for ; Wed, 18 Mar 2015 18:19:19 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=L3p09YR4; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 8D2E82809E0; Wed, 18 Mar 2015 08:18:44 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on arrakis.dune.hu X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, T_DKIM_INVALID autolearn=no version=3.3.2 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 0FC94280219 for ; Wed, 18 Mar 2015 08:18:41 +0100 (CET) X-policyd-weight: using cached result; rate: -8.5 Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by arrakis.dune.hu (Postfix) with ESMTPS for ; Wed, 18 Mar 2015 08:18:40 +0100 (CET) Received: by wibdy8 with SMTP id dy8so82169207wib.0 for ; Wed, 18 Mar 2015 00:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=Qf3EQ426Cl3b7mAl593OU9PhENnD9Rno5BrX3FmJC8I=; b=L3p09YR4fIl0JYzXnrK8BffYaCM5rFT0CMFwHGIHfho3aRJrCdbkOb+5WcRSiYbqpC +EmEORVWyz0KKVFbetwi2n1diquRxiy9vtawCIN/AgAnYsUTueZqkuCbU9euaOfCOCmr /saeyknpcuHALBA/h22u5k336lkko+E1xabRd305tj4l0uqX2QnVrS5ba1efH1/etcC7 hTumWFUjwBO+5xZuCK9cR7DkH9Ta/sWbiNT8u/SbpfZXkhJyni4b9TzveOv5hYXeXFUy KJ039jkCIXAZyWpRkViBSpwoEdKz/GsTAiooSmLBkWFIE7xfyzOSb8tyh6YlQvo+KCaP L78g== X-Received: by 10.194.60.77 with SMTP id f13mr141276471wjr.105.1426663148103; Wed, 18 Mar 2015 00:19:08 -0700 (PDT) Received: from linux-tdhb.lan ([89.174.37.6]) by mx.google.com with ESMTPSA id dx11sm23150865wjb.23.2015.03.18.00.19.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Mar 2015 00:19:07 -0700 (PDT) From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: openwrt-devel@lists.openwrt.org Date: Wed, 18 Mar 2015 08:18:53 +0100 Message-Id: <1426663133-18131-1-git-send-email-zajec5@gmail.com> X-Mailer: git-send-email 1.8.4.5 MIME-Version: 1.0 Cc: Jonas Gorski Subject: [OpenWrt-Devel] [PATCH] b53: reverse duplex bit meaning for IMP state override register X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: openwrt-devel-bounces@lists.openwrt.org Sender: "openwrt-devel" Signed-off-by: Rafał Miłecki --- When reading bcmrobo.c code for BCM5301X I've noticed that it uses REG_CTRL_MIIPO (0x0e) with a following comment: /* default(1 << 1) DUPLX_MODE: * Full Duplex */ So I guess our bit definition may be reversed. Can someone verify this? --- target/linux/generic/files/drivers/net/phy/b53/b53_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h index ba50915..4899cc4 100644 --- a/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h +++ b/target/linux/generic/files/drivers/net/phy/b53/b53_regs.h @@ -75,7 +75,7 @@ /* IMP Port state override register (8 bit) */ #define B53_PORT_OVERRIDE_CTRL 0x0e #define PORT_OVERRIDE_LINK BIT(0) -#define PORT_OVERRIDE_HALF_DUPLEX BIT(1) /* 0 = Full Duplex */ +#define PORT_OVERRIDE_FULL_DUPLEX BIT(1) /* 0 = Half Duplex */ #define PORT_OVERRIDE_SPEED_S 2 #define PORT_OVERRIDE_SPEED_10M (0 << PORT_OVERRIDE_SPEED_S) #define PORT_OVERRIDE_SPEED_100M (1 << PORT_OVERRIDE_SPEED_S)