diff mbox

[OpenWrt-Devel,v2,2/3] cli: fix return value of package_cmd().

Message ID 1426653885-23455-3-git-send-email-yszhou4tech@gmail.com
State Accepted
Delegated to: Felix Fietkau
Headers show

Commit Message

Yousong Zhou March 18, 2015, 4:44 a.m. UTC 
It's a bug revealed by commit 446e774 "cli: properly unload package
before quit".  The current code would exit with value 1 even if
uci_export() succceeded.

Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
---
 cli.c |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff mbox

Patch

diff --git a/cli.c b/cli.c
index b647f77..557472e 100644
--- a/cli.c
+++ b/cli.c
@@ -305,10 +305,13 @@  static int package_cmd(int cmd, char *tuple)
 		}
 		if (uci_commit(ctx, &ptr.p, false) != UCI_OK) {
 			cli_perror();
+			goto out;
 		}
 		break;
 	case CMD_EXPORT:
-		uci_export(ctx, stdout, ptr.p, true);
+		if (uci_export(ctx, stdout, ptr.p, true) != UCI_OK) {
+			goto out;
+		}
 		break;
 	case CMD_SHOW:
 		if (!(ptr.flags & UCI_LOOKUP_COMPLETE)) {
@@ -333,6 +336,8 @@  static int package_cmd(int cmd, char *tuple)
 		break;
 	}
 
+	ret = 0;
+
 out:
 	if (ptr.p)
 		uci_unload(ctx, ptr.p);