From patchwork Fri Apr 14 03:58:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Elliott Mitchell X-Patchwork-Id: 1774261 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cne5Jpv6; dkim-atps=neutral Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q69WG3TdNz23vH for ; Thu, 27 Apr 2023 06:31:22 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:To:Subject:Date:From: References:In-Reply-To:Message-Id:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vHwGNZdllS9Q1a8+KlR7gqlEBvdZBb89Yt8H95fCFPk=; b=cne5Jpv6KjtnGA 65A6BBmD+/b6VidT81UxR0ah+WbVCyC81+1P7pJnrYfjZCLFcW+CnymhjiPHQTWb8ObX0unrb/RuV xSQmVmx1pu/QxCfXyG/AqdALlqSRd9+d3EEJJW0uBjCi+8NKdkizyWkEk9Zbjci6zRLZLTr868zXL 4RzMmuwYWhSpm1QqNVDc+OoEgcTWbR5wLO8mBs3pSdMw+uCRgF2yROviiVQIwwvB6UHNbGE9iaO8l so2EAGvxDBXCvxVlWt5h5kGRmsqxt8pTuvD30qIY9qtQ7AsfXhkcK8EEmdEvzWz2+HwONxklgQybM 0BefFgWG5MYD3m9bDOuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prlmA-004o5x-0g; Wed, 26 Apr 2023 20:30:06 +0000 Received: from mailhost.m5p.com ([74.104.188.4]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prlm6-004o51-2g for openwrt-devel@lists.openwrt.org; Wed, 26 Apr 2023 20:30:04 +0000 Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 33QKTtq7030152 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO) for ; Wed, 26 Apr 2023 16:30:00 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 33QKTt8W030151; Wed, 26 Apr 2023 13:29:55 -0700 (PDT) (envelope-from ehem) Message-Id: <03e8435f00711caeb7e54b0b4eb65d1dffaa850f.1682539911.git.ehem+openwrt@m5p.com> In-Reply-To: References: From: Elliott Mitchell Date: Thu, 13 Apr 2023 20:58:58 -0700 Subject: [PATCH 7/9] kernel/x86: remove all ISA support from non-legacy To: openwrt-devel@lists.openwrt.org X-Spam-Status: No, score=2.5 required=10.0 tests=DATE_IN_PAST_96_XX, KHOP_HELO_FCRDNS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on mattapan.m5p.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230426_133003_028129_2EB8FB34 X-CRM114-Status: UNSURE ( 7.76 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 2.1 (++) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: While some older PCI motherboard might emulate some functions via ISA, actual ISA is absent from anything non-legacy. Move ISA DMA enabling to Geode and Legacy. Signed-off-by: Elliott Mitchell --- Question here is how far to go with removing ISA support? Certainly it is appropriate to keep for the legacy build, but what of slightly more [...] Content analysis details: (2.1 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 2.1 DATE_IN_PAST_96_XX Date: is 96 hours or more before Received: date -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org While some older PCI motherboard might emulate some functions via ISA, actual ISA is absent from anything non-legacy. Move ISA DMA enabling to Geode and Legacy. Signed-off-by: Elliott Mitchell Reviewed-by: Philip Prindeville --- Question here is how far to go with removing ISA support? Certainly it is appropriate to keep for the legacy build, but what of slightly more recent hardware? Some i686 motherboards might have actual slots, but it was quickly vestigial. --- target/linux/x86/config-5.10 | 5 ++--- target/linux/x86/config-5.15 | 5 ++--- target/linux/x86/geode/config-5.10 | 2 ++ target/linux/x86/geode/config-5.15 | 2 ++ target/linux/x86/legacy/config-5.10 | 2 ++ target/linux/x86/legacy/config-5.15 | 2 ++ 6 files changed, 12 insertions(+), 6 deletions(-) diff --git a/target/linux/x86/config-5.10 b/target/linux/x86/config-5.10 index 8be829d549..98e0372247 100644 --- a/target/linux/x86/config-5.10 +++ b/target/linux/x86/config-5.10 @@ -132,7 +132,6 @@ CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR=y CONFIG_GENERIC_IRQ_RESERVATION_MODE=y CONFIG_GENERIC_IRQ_SHOW=y -CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_MSI_IRQ=y CONFIG_GENERIC_MSI_IRQ_DOMAIN=y CONFIG_GENERIC_PCI_IOMAP=y @@ -185,8 +184,8 @@ CONFIG_IRQ_DOMAIN=y CONFIG_IRQ_DOMAIN_HIERARCHY=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_IRQ_WORK=y -# CONFIG_ISA is not set -CONFIG_ISA_DMA_API=y +CONFIG_ISA=n +CONFIG_ISA_DMA_API=n # CONFIG_IT8712F_WDT is not set # CONFIG_IT87_WDT is not set # CONFIG_ITCO_WDT is not set diff --git a/target/linux/x86/config-5.15 b/target/linux/x86/config-5.15 index afe66b27b1..3805820416 100644 --- a/target/linux/x86/config-5.15 +++ b/target/linux/x86/config-5.15 @@ -133,7 +133,6 @@ CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_IRQ_MATRIX_ALLOCATOR=y CONFIG_GENERIC_IRQ_RESERVATION_MODE=y CONFIG_GENERIC_IRQ_SHOW=y -CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_MSI_IRQ=y CONFIG_GENERIC_MSI_IRQ_DOMAIN=y CONFIG_GENERIC_PCI_IOMAP=y @@ -187,8 +186,8 @@ CONFIG_IRQ_DOMAIN=y CONFIG_IRQ_DOMAIN_HIERARCHY=y CONFIG_IRQ_FORCED_THREADING=y CONFIG_IRQ_WORK=y -# CONFIG_ISA is not set -CONFIG_ISA_DMA_API=y +CONFIG_ISA=n +CONFIG_ISA_DMA_API=n # CONFIG_IT8712F_WDT is not set # CONFIG_IT87_WDT is not set # CONFIG_ITCO_WDT is not set diff --git a/target/linux/x86/geode/config-5.10 b/target/linux/x86/geode/config-5.10 index 30b358b050..632e1fb7b7 100644 --- a/target/linux/x86/geode/config-5.10 +++ b/target/linux/x86/geode/config-5.10 @@ -42,6 +42,7 @@ CONFIG_CS5535_MFGPT=y CONFIG_CS5535_MFGPT_DEFAULT_IRQ=7 CONFIG_DMA_ACPI=y # CONFIG_EL3 is not set +CONFIG_GENERIC_ISA_DMA=y CONFIG_GEODE_WDT=y CONFIG_GEOS=y CONFIG_GPIO_ACPI=y @@ -67,6 +68,7 @@ CONFIG_IOSF_MBI=y CONFIG_ISA=y # CONFIG_ISAPNP is not set CONFIG_ISA_BUS_API=y +CONFIG_ISA_DMA_API=y # CONFIG_ISCSI_IBFT is not set # CONFIG_LANCE is not set CONFIG_LEDS_GPIO=y diff --git a/target/linux/x86/geode/config-5.15 b/target/linux/x86/geode/config-5.15 index 0c54cdaf9e..deaf2123d4 100644 --- a/target/linux/x86/geode/config-5.15 +++ b/target/linux/x86/geode/config-5.15 @@ -45,6 +45,7 @@ CONFIG_CS5535_MFGPT_DEFAULT_IRQ=7 # CONFIG_CS89x0_ISA is not set CONFIG_DMA_ACPI=y # CONFIG_EL3 is not set +CONFIG_GENERIC_ISA_DMA=y CONFIG_GEODE_WDT=y CONFIG_GEOS=y CONFIG_GPIO_ACPI=y @@ -74,6 +75,7 @@ CONFIG_IOSF_MBI=y CONFIG_ISA=y # CONFIG_ISAPNP is not set CONFIG_ISA_BUS_API=y +CONFIG_ISA_DMA_API=y # CONFIG_ISCSI_IBFT is not set # CONFIG_LANCE is not set CONFIG_LEDS_GPIO=y diff --git a/target/linux/x86/legacy/config-5.10 b/target/linux/x86/legacy/config-5.10 index a11eca8fc2..3a44ab45d6 100644 --- a/target/linux/x86/legacy/config-5.10 +++ b/target/linux/x86/legacy/config-5.10 @@ -106,6 +106,7 @@ CONFIG_FONT_SUPPORT=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y # CONFIG_FRAMEBUFFER_CONSOLE_ROTATION is not set +CONFIG_GENERIC_ISA_DMA=y CONFIG_HDMI=y CONFIG_HID_BATTERY_STRENGTH=y # CONFIG_HIGHMEM4G is not set @@ -136,6 +137,7 @@ CONFIG_IOSF_MBI=y CONFIG_ISA=y CONFIG_ISAPNP=y CONFIG_ISA_BUS_API=y +CONFIG_ISA_DMA_API=y # CONFIG_ISCSI_IBFT is not set CONFIG_ISO9660_FS=y # CONFIG_JOLIET is not set diff --git a/target/linux/x86/legacy/config-5.15 b/target/linux/x86/legacy/config-5.15 index b424147073..74edf85abd 100644 --- a/target/linux/x86/legacy/config-5.15 +++ b/target/linux/x86/legacy/config-5.15 @@ -109,6 +109,7 @@ CONFIG_FONT_SUPPORT=y CONFIG_FRAMEBUFFER_CONSOLE=y CONFIG_FRAMEBUFFER_CONSOLE_DETECT_PRIMARY=y # CONFIG_FRAMEBUFFER_CONSOLE_ROTATION is not set +CONFIG_GENERIC_ISA_DMA=y CONFIG_HDMI=y CONFIG_HID_BATTERY_STRENGTH=y # CONFIG_HIGHMEM4G is not set @@ -142,6 +143,7 @@ CONFIG_IOSF_MBI=y CONFIG_ISA=y CONFIG_ISAPNP=y CONFIG_ISA_BUS_API=y +CONFIG_ISA_DMA_API=y # CONFIG_ISCSI_IBFT is not set CONFIG_ISO9660_FS=y # CONFIG_JOLIET is not set