From patchwork Fri Apr 5 11:06:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Donald X-Patchwork-Id: 1920213 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=shYOL6Kj; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=ERV6+BRm; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.openwrt.org (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org; envelope-from=openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org; receiver=patchwork.ozlabs.org) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V9wmm0BWBz1yZM for ; Fri, 5 Apr 2024 22:12:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UKQ7L3+RSkB9tJ3Xt8Y5ZdUNi+EX4TfQgLVlH+SSwJg=; b=shYOL6KjryYboM EOxkMasfd4kOqS8yL3yZ8ukxOpYBcxRcYMkxLbZbm3i/gDd4/EjrbcqUqi3w+DHpNotWHgj1M3p25 bEFRZ7eVpe08Jy9gCUDKKwFi6rYcxZGQDMlo4eGZnz9YFyNOBf4q3UZEhOKd6PYaIvy/d1xSUzD1Y NiFNtrN/jyFuY7s20iteqnAO5uKE6B6Bi54jWJA83L0SfbzmCi/JAoy4RG7D4TEOVlKTKk0wshhFJ iAqu3Mzps4EBg4pK8DbfphiDZxTnWhmkJFpXXWhHlNTU4zwEhFxAoE/1QglpW2bJl+reZLbjEIZKg Ami88orYw0PszmtUjVQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshSs-00000006bgp-3Cvq; Fri, 05 Apr 2024 11:10:34 +0000 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rshSn-00000006bcd-47x9 for openwrt-devel@lists.openwrt.org; Fri, 05 Apr 2024 11:10:31 +0000 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-516c403cc46so3824520e87.3 for ; Fri, 05 Apr 2024 04:10:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712315427; x=1712920227; darn=lists.openwrt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=WF0Jr87fwbdjHM6oIVDj1TJX0wl4MsEkOV99+Daagbs=; b=ERV6+BRmyz9qp0flBAeYxm47hjILBA0SGVcy0HqjbskCUJefZpLxkZoO4Upip8lEFg LqyFvlGHqRLPhjqm5L5/tYckhsl3gbCAqNoZQoDaLHliRoP4UbmiJstd0Rp+o5tKV31j 23ElLNzfC3CRBwG4QNwV5gWMAVjGDN1EJKib6fKDOAHiA+rq3cGhuUE3E12iQKri4Ryt JZ83p6PdMxwzCu52SSuweuA46FVZYADcvH0fcBgqU0M8kbb4j9gIvIvXOyC2ZBXtAUPx 94iE0c7cS+3Yri4vNbl4vpjhpKRjiETTjT754FV7p99HrAaIXu6cDV36PjQepq3jj9TY /iGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712315427; x=1712920227; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:sender:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=WF0Jr87fwbdjHM6oIVDj1TJX0wl4MsEkOV99+Daagbs=; b=BI4kN4/3HitO0QIMlWq9v1wyirh3HIMnnMa9AgNkktjfs9AaPsLe4HKgTBdrpHKcfw EfUOo1dY/g0xyIk7OjbDMwRbj0v1u6f0IQA3HUC3UF4TLUHnjS2pLDxKEXsCUZ1XkUse tR7G+bbFNeF2at9hu1bivbLY6L+rD5zYLpNLekfROQyvzYqHUgYUg69EFdWy/w8rqAF8 oulrb9PYbv+IV6Y0Z5J3BhNnK0PP8HXnbLwU8nOhj1KyQbZc2tDQUHgKFGgL2cL4RYyM l4paUPLDjYk8Z+yOIaIiHq2ZV6ehyAOrC9gQsRGnBz27ZyHeYUnYHKI9DZqSck8jZ/HK mc+w== X-Gm-Message-State: AOJu0Ywj8DqToIWbaBeAA7/lPMQTIcOVY1sJrXOd2C9r69pSypyWprBf cB4fgOOQwxjNKMp/oE378+k9iVg1GAwaqSk+H/i55E0rzE2u3laQec5fEXQ+HWd7tw== X-Google-Smtp-Source: AGHT+IGxtpaFT1kg8sTd4TesBwXQFmDt4xfK6/xAfqemvL6ih4+vrkKHcGWsriQlXioVEwPcQ8fzyg== X-Received: by 2002:a05:6512:484a:b0:516:d26e:ea6f with SMTP id ep10-20020a056512484a00b00516d26eea6fmr981327lfb.35.1712315426612; Fri, 05 Apr 2024 04:10:26 -0700 (PDT) Received: from blackhol3 ([2001:9b0:40::cae3:cb03]) by smtp.gmail.com with ESMTPSA id g21-20020ac24d95000000b00516cdadf377sm163719lfe.137.2024.04.05.04.10.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 04:10:26 -0700 (PDT) From: Paul Donald To: OpenWrt Development List Subject: [PATCH v2 0/9] odhcpd patchset Date: Fri, 5 Apr 2024 13:06:44 +0200 Message-ID: <20240405111025.26478-1-newtwen+github@gmail.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240405005510.19778-1-newtwen+github@gmail.com> References: <20240405005510.19778-1-newtwen+github@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240405_041030_093717_610BC575 X-CRM114-Status: UNSURE ( 7.78 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: From: Paul Donald applies to odhcpd master HEAD d8118f6e76e5519881f9a37137c3a06b3cb60fd2 Before: == ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64) Type: Prefix information (3) Length: 4 (32 bytes) Prefix Length: 64 Flag: 0xc0, On-link flag(L), Autonomous address-configuration fl [...] Content analysis details: (-0.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:12d listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [newtwen+github(at)gmail.com] X-BeenThere: openwrt-devel@lists.openwrt.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: OpenWrt Development List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "openwrt-devel" Errors-To: openwrt-devel-bounces+incoming=patchwork.ozlabs.org@lists.openwrt.org From: Paul Donald applies to odhcpd master HEAD d8118f6e76e5519881f9a37137c3a06b3cb60fd2 Before: == ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64) Type: Prefix information (3) Length: 4 (32 bytes) Prefix Length: 64 Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A) Valid Lifetime: Infinity (4294967295) Preferred Lifetime: Infinity (4294967295) Reserved Prefix: fd51:1c2a:8909:: ==After:== ICMPv6 Option (Prefix information : fd51:1c2a:8909::/64) Type: Prefix information (3) Length: 4 (32 bytes) Prefix Length: 64 Flag: 0xc0, On-link flag(L), Autonomous address-configuration flag(A) Valid Lifetime: Infinity (4294967295) Preferred Lifetime: 420 Reserved Prefix: fd51:1c2a:8909:: == changes: v1: initial patch v2: implemented feedback for commit messages Paul Donald (9): various: refactor pref(erred) to preferred_lt (lifetime) various: refactor valid -> valid_lt (lifetime) various: Comment spell-fixes and clarification router: inherit user-assigned preferred_lifetime router: Limit prefix preferred_lt to valid_lt in accordance with RFC4861 router: Apply updated values from RFC8319 (updates RFC4861) to RA/ND config: ra_management is deprecated comment router: DNSRecursiveDNS and DNSSearchOpt Type comments ndp: Comments (spelling) src/config.c | 1 + src/dhcpv4.c | 2 +- src/dhcpv6-ia.c | 140 ++++++++++++++++++++++++------------------------ src/dhcpv6.c | 6 +-- src/dhcpv6.h | 8 +-- src/ndp.c | 4 +- src/netlink.c | 56 +++++++++---------- src/odhcpd.c | 8 +-- src/odhcpd.h | 4 +- src/router.c | 72 ++++++++++++++----------- src/router.h | 21 +++++++- 11 files changed, 176 insertions(+), 146 deletions(-)