mbox series

[19.07,0/4] ubus fixes backports

Message ID 20210701130955.2315-1-ynezz@true.cz
Headers show
Series ubus fixes backports | expand

Message

Petr Štetiar July 1, 2021, 1:09 p.m. UTC
Hi,

this patch series backports various ubus related fixes and additionally marks
various default packages as nonshared in order to avoid further ABI issues[1].

1. https://github.com/openwrt/openwrt/pull/4233

-- ynezz

Hannu Nyman (1):
  treewide: mark selected packages nonshared

Petr Štetiar (3):
  ubus: backport SOVERSION support
  ubus: update to version 2021-06-03
  ubus: update to version 2021-07-01

 package/libs/libjson-c/Makefile  |  3 ++-
 package/libs/libnl-tiny/Makefile |  4 +++-
 package/libs/libubox/Makefile    |  4 +++-
 package/system/ubus/Makefile     | 17 ++++++++++-------
 package/system/uci/Makefile      |  3 ++-
 package/utils/lua/Makefile       |  3 ++-
 6 files changed, 22 insertions(+), 12 deletions(-)

Comments

Nick July 2, 2021, 7:57 a.m. UTC | #1
There was a update of libubus: 
https://github.com/openwrt/openwrt/commit/3c574750854488ff463b2069a5d23d9c44f2a3dc

However this still "broke" 21.02-rc3 and SNAPSHOT (imagebuilder)?
Why does it break "21.02-rc3"? Packages are not recompiled?

On 7/1/21 3:09 PM, Petr Štetiar wrote:
> Hi,
>
> this patch series backports various ubus related fixes and additionally marks
> various default packages as nonshared in order to avoid further ABI issues[1].
>
> 1. https://github.com/openwrt/openwrt/pull/4233
>
> -- ynezz
>
> Hannu Nyman (1):
>    treewide: mark selected packages nonshared
>
> Petr Štetiar (3):
>    ubus: backport SOVERSION support
>    ubus: update to version 2021-06-03
>    ubus: update to version 2021-07-01
>
>   package/libs/libjson-c/Makefile  |  3 ++-
>   package/libs/libnl-tiny/Makefile |  4 +++-
>   package/libs/libubox/Makefile    |  4 +++-
>   package/system/ubus/Makefile     | 17 ++++++++++-------
>   package/system/uci/Makefile      |  3 ++-
>   package/utils/lua/Makefile       |  3 ++-
>   6 files changed, 22 insertions(+), 12 deletions(-)
>
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Petr Štetiar July 2, 2021, 8:48 a.m. UTC | #2
Nick <vincent@systemli.org> [2021-07-02 09:57:57]:

Hi,

> There was a update of libubus: https://github.com/openwrt/openwrt/commit/3c574750854488ff463b2069a5d23d9c44f2a3dc

thats handled via `ubus: update to version 2021-07-01` backport.

> However this still "broke" 21.02-rc3 and SNAPSHOT (imagebuilder)?
> Why does it break "21.02-rc3"? Packages are not recompiled?

That should be handled via `treewide: mark selected packages nonshared` which
is in 21.02-rc3 via commit ea308e2f383c ("treewide: mark selected packages
nonshared") and in snapshot via commit 72cc44958ef4 ("treewide: mark
selected packages nonshared").

So I'm wondering what's broken, do you've any reproducer, link to the issue
details?

-- ynezz
Nick July 2, 2021, 9:33 a.m. UTC | #3
Hi,
the described backports also help if I compare rc2 to rc3. However, the 
backport from the ubus update broke it again. :)

We insert our own feed, so maybe we generate this issue:

21.02 SNAPSHOT:
https://gist.github.com/PolynomialDivision/a490bbe773ef3b29167f78912d1b6080

21.02-RC3:
https://gist.github.com/PolynomialDivision/443e53d4dc08994a9affe3174a792d75

You can also reproduce by using our repro:
https://github.com/Freifunk-Spalter/bbb-configs

And then
ansible-playbook play.yml --tags image --limit schreiner-core

Bests,
Nick

On 7/2/21 10:48 AM, Petr Štetiar wrote:
> Nick <vincent@systemli.org> [2021-07-02 09:57:57]:
>
> Hi,
>
>> There was a update of libubus: https://github.com/openwrt/openwrt/commit/3c574750854488ff463b2069a5d23d9c44f2a3dc
> thats handled via `ubus: update to version 2021-07-01` backport.
>
>> However this still "broke" 21.02-rc3 and SNAPSHOT (imagebuilder)?
>> Why does it break "21.02-rc3"? Packages are not recompiled?
> That should be handled via `treewide: mark selected packages nonshared` which
> is in 21.02-rc3 via commit ea308e2f383c ("treewide: mark selected packages
> nonshared") and in snapshot via commit 72cc44958ef4 ("treewide: mark
> selected packages nonshared").
>
> So I'm wondering what's broken, do you've any reproducer, link to the issue
> details?
>
> -- ynezz
Petr Štetiar July 2, 2021, 1:13 p.m. UTC | #4
Nick <vincent@systemli.org> [2021-07-02 11:33:49]:

Hi,

> However, the backport from the ubus update broke it again. :)

no, it's due to iwinfo and luci-mod-status updates, for details see
https://lists.infradead.org/pipermail/openwrt-devel/2021-July/035741.html

-- ynezz