mbox series

[v2,0/6] sysupgrade: introduce compatibility version for devices

Message ID 20200714142825.16889-1-freifunk@adrianschmutzler.de
Headers show
Series sysupgrade: introduce compatibility version for devices | expand

Message

Adrian Schmutzler July 14, 2020, 2:28 p.m. UTC 
This revised patchset provides some polishing to the initial submission.

It does not change the mechanics substantially, but just provides some
aesthetic improvements.

Notable functional changes:
- compat version check is now executed _after_ the supported_devices check
- the DEVICE_COMPAT_MESSAGE is now also printed for the legacy sysupgrade hack

Cosmetic changes:
- The "error" message have been reworded to be more conclusive and provide
  more information.

Further additions:
- Instead of the example implementation patch for ath79, this now features
  the actual implementation for swconfig->DSA change in mvebu and kirkwood.
  (adding mt7621 will be considered after merge)

While v1 has been device-tested, I have not run-tested this patchset so
far, as changes between them are mostly cosmetic and I want to wait for
feedback first.

Adrian Schmutzler (6):
  build: add DEVICE_COMPAT_VERSION and DEVICE_COMPAT_MESSAGE
  base-files: add support for compat_version on device
  base-files: fwtool: implement compatibility check for images
  base-files: fwtool: make compat_version backward compatible
  mvebu: implement compatibility version for DSA migration
  kirkwood: implement compatibility version for DSA migration

 include/image-commands.mk                     | 10 ++++--
 include/image.mk                              |  3 ++
 package/base-files/files/bin/config_generate  |  7 +++++
 .../files/lib/functions/uci-defaults.sh       |  6 ++++
 .../base-files/files/lib/upgrade/fwtool.sh    | 31 +++++++++++++++++--
 .../base-files/etc/board.d/02_network         |  1 +
 target/linux/kirkwood/image/Makefile          |  7 +++++
 .../base-files/etc/board.d/02_network         | 14 +++++----
 target/linux/mvebu/image/cortexa9.mk          | 19 ++++++++++++
 9 files changed, 88 insertions(+), 10 deletions(-)

Comments

Adrian Schmutzler July 27, 2020, 11 a.m. UTC | #1 
> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Adrian Schmutzler
> Sent: Dienstag, 14. Juli 2020 16:28
> To: openwrt-devel@lists.openwrt.org
> Subject: [PATCH v2 0/6] sysupgrade: introduce compatibility version for
> devices

This has been lying around for two weeks now (plus the time since the v1 submission), but unfortunately there has been not much feedback on it.

Since I think this really solves an important open issue not taken care of so far, I'm very eager to merge it.
I also considered to wait for the DSA config patch, but actually there have been several cases where I'd have needed this functionality already and I'm starting to lose track.

I'd thus add it to master end of this week, until somebody explicitly NAKs it or requests delay.
Note that I don't want to force it in, I just try to push it forward in case nobody really cares (as it appears to my ATM).

Best

Adrian

> 
> This revised patchset provides some polishing to the initial submission.
> 
> It does not change the mechanics substantially, but just provides some
> aesthetic improvements.
> 
> Notable functional changes:
> - compat version check is now executed _after_ the supported_devices
> check
> - the DEVICE_COMPAT_MESSAGE is now also printed for the legacy
> sysupgrade hack
> 
> Cosmetic changes:
> - The "error" message have been reworded to be more conclusive and
> provide
>   more information.
> 
> Further additions:
> - Instead of the example implementation patch for ath79, this now features
>   the actual implementation for swconfig->DSA change in mvebu and
> kirkwood.
>   (adding mt7621 will be considered after merge)
> 
> While v1 has been device-tested, I have not run-tested this patchset so far,
> as changes between them are mostly cosmetic and I want to wait for
> feedback first.
> 
> Adrian Schmutzler (6):
>   build: add DEVICE_COMPAT_VERSION and DEVICE_COMPAT_MESSAGE
>   base-files: add support for compat_version on device
>   base-files: fwtool: implement compatibility check for images
>   base-files: fwtool: make compat_version backward compatible
>   mvebu: implement compatibility version for DSA migration
>   kirkwood: implement compatibility version for DSA migration
> 
>  include/image-commands.mk                     | 10 ++++--
>  include/image.mk                              |  3 ++
>  package/base-files/files/bin/config_generate  |  7 +++++
>  .../files/lib/functions/uci-defaults.sh       |  6 ++++
>  .../base-files/files/lib/upgrade/fwtool.sh    | 31 +++++++++++++++++--
>  .../base-files/etc/board.d/02_network         |  1 +
>  target/linux/kirkwood/image/Makefile          |  7 +++++
>  .../base-files/etc/board.d/02_network         | 14 +++++----
>  target/linux/mvebu/image/cortexa9.mk          | 19 ++++++++++++
>  9 files changed, 88 insertions(+), 10 deletions(-)
> 
> --
> 2.20.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel