diff mbox

[ovs-dev] ovs-ctl: Remove a leftover restore_interfaces in restart

Message ID f6c0cb9f4eff3cab57657e6f262c1304ac8cbded.1501076907.git.tredaelli@redhat.com
State Accepted
Headers show

Commit Message

Timothy Redaelli July 26, 2017, 1:48 p.m. UTC
Since commit c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open
vSwitch 1.9 and earlier.") the kernel configuration of the specified
network interfaces is not saved anymore for restart command so there is no
need to try to restore it.

CC: Ben Pfaff <blp@ovn.org>
Fixes: c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.")
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 utilities/ovs-ctl.in | 3 ---
 1 file changed, 3 deletions(-)

Comments

Ben Pfaff Aug. 3, 2017, 7:32 p.m. UTC | #1
On Wed, Jul 26, 2017 at 03:48:33PM +0200, Timothy Redaelli wrote:
> Since commit c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open
> vSwitch 1.9 and earlier.") the kernel configuration of the specified
> network interfaces is not saved anymore for restart command so there is no
> need to try to restore it.
> 
> CC: Ben Pfaff <blp@ovn.org>
> Fixes: c416eaf8c247 ("ovs-ctl: Remove code for upgrading from Open vSwitch 1.9 and earlier.")
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>

Thanks a lot, I applied this to master.
diff mbox

Patch

diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in
index 85ce6baef..dc1d02c9c 100755
--- a/utilities/ovs-ctl.in
+++ b/utilities/ovs-ctl.in
@@ -443,9 +443,6 @@  restart () {
     restore_flows
     flow_restore_complete
     add_managers
-
-    # Restore the interfaces if required. Return true even if restore fails.
-    restore_interfaces || true
 }
 
 ## --------------- ##