| Message ID | c5fc4c18cd0096f9a80525ffa74f68b0e09f0180.1492076789.git.tredaelli@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Apr 13, 2017 at 11:48:20AM +0200, Timothy Redaelli wrote: > Avoid also errors if an ovs server didn't start correctly or it crashed without > deleting the pid file. > > Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1441524 > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Thanks! I applied this to master.
diff --git a/rhel/etc_logrotate.d_openvswitch b/rhel/etc_logrotate.d_openvswitch index 914e67c..d93a56e 100644 --- a/rhel/etc_logrotate.d_openvswitch +++ b/rhel/etc_logrotate.d_openvswitch @@ -12,8 +12,10 @@ missingok postrotate # Tell Open vSwitch daemons to reopen their log files - for pidfile in `cd /var/run/openvswitch && echo *.pid`; do - ovs-appctl -t "${pidfile%%.pid}" vlog/reopen - done + if [ -d /var/run/openvswitch ]; then + for pidfile in `cd /var/run/openvswitch && echo *.pid`; do + ovs-appctl -t "${pidfile%%.pid}" vlog/reopen 2>/dev/null || : + done + fi endscript }
Avoid also errors if an ovs server didn't start correctly or it crashed without deleting the pid file. Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1441524 Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> --- rhel/etc_logrotate.d_openvswitch | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)