From patchwork Wed Nov 24 13:32:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: miter X-Patchwork-Id: 1559100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=outlook.com header.i=@outlook.com header.a=rsa-sha256 header.s=selector1 header.b=aeaToM7L; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4HzhlW2xQ6z9sRN for ; Thu, 25 Nov 2021 00:32:55 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 8DCBC4046B; Wed, 24 Nov 2021 13:32:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lfage5mTVw6C; Wed, 24 Nov 2021 13:32:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 701F34044D; Wed, 24 Nov 2021 13:32:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 069AEC001E; Wed, 24 Nov 2021 13:32:50 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id F41CDC0012 for ; Wed, 24 Nov 2021 13:32:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id C93D240557 for ; Wed, 24 Nov 2021 13:32:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=outlook.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cC4wu7ov_sGS for ; Wed, 24 Nov 2021 13:32:47 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from AUS01-SY4-obe.outbound.protection.outlook.com (mail-sy4aus01olkn20826.outbound.protection.outlook.com [IPv6:2a01:111:f403:7005::826]) by smtp4.osuosl.org (Postfix) with ESMTPS id 871F14054A for ; Wed, 24 Nov 2021 13:32:47 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c0WjsIeXGKkMu2IahvKn0EHBTyEkBtu5aO0EgVCXn1V2hAkql22hquyxz5cW5TpdVcmvC+lnQu5sYhSf8HNi43XyQ+kFqLc4Sj2v5GLpDb9F7rixBlj3Cp78mgU7YoaOwyibQgKyU/QQTDSXBMGnBaIu0qKwGqMfEdnCxR9SQaaAfZz73l/a2TUwylj0+tZs7HLOez5ClBpdb4j0TkXNRFP4RCR0qcHpJSX/WRRmH2DA+GYj6n5Jrxyc/bM27ny6P1UTbzkoYfcGAWKhruNTpeTKueT/yDT44BFe2tsdoJaazHrbRGUOeMsPm6LSVRjToJ6OoNAROtw7RQFnqARwrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zGCF1z6WfWJZAwwU0mC5L/+pewj8HrtAvj2wDYQpDso=; b=gE9VWKjM28dwI8abFDHFQdzZhjouEGrgCvgkGTuA+vAgcvWJKtNHQ5NetZOy6G5Fy715GqxsdaDJJCiaSHx6y7pCdFIBtsJI8QIT/+I/uIL4fV5urfSFxbZYIwZ2xqALPvwmbvW9p3rgXV2eH48/M7KTybBPSEYj9evO7V+8SSs22BlE7CBmqr7mdliQ9BHLcSHQ0oH06VQKScS+184Q/PE4jHJ64WeWAZVzlzTKK4jNNzYWremDpvU+pEllr6QX9zn2HGklli7DYyVj1xI5EyDhrcH7TRcsRIjsn5G+G4ovzB8dmUcf2delK5q/qS9marD4iy/nIXUhKzggcM2/hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zGCF1z6WfWJZAwwU0mC5L/+pewj8HrtAvj2wDYQpDso=; b=aeaToM7LCqg3D5jylRYfXnk4I2zjdX3mU6mut1NGLQgyjybcEl5StBEcC3eFdxjLTVC/4Lm3QyWcEJqM/H12+yWZ6v4wpWCoCeEK0NBUuWPlLB/wMA3GmwaQnqFjqPi5akwNwZrawujqONYaaVnS57kEaY5SW1t5zBjGjgBy7AnZHU4hDjllfASa7T+BbNh2umKUHGJNRNBm4e7E7pqE0/7q61QuBiUhDoG0vWM5CO797tHT80oUaXv4y/4JPzCBVIl0kGOJjqX4g3sYHy6IuF5wxrCvuWnK8hnVmFUUaNAjxhs5E3jMZQTdAhghOgNwylqlvI5tJGwudz3W6PCIRg== Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:15b::24) by MEYP282MB2816.AUSP282.PROD.OUTLOOK.COM (2603:10c6:220:155::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Wed, 24 Nov 2021 13:32:41 +0000 Received: from MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::31f7:780a:9782:eddb]) by MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM ([fe80::31f7:780a:9782:eddb%9]) with mapi id 15.20.4713.027; Wed, 24 Nov 2021 13:32:41 +0000 From: lin huang To: "dev@openvswitch.org" Thread-Topic: [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs. Thread-Index: AQHX4TMIgbIsgv93YUWKYmxdLqtDJQ== Date: Wed, 24 Nov 2021 13:32:41 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: suggested_attachment_session_id: ddaec516-49fe-0e62-dd56-2608651f8b72 x-tmn: [huvNqTO6xEi5lPHnOcPe5H1w0OuffLFhcbQX0b4BjnWHE8L6Pe/F3ajwtP4z6Erx] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c07c3f91-ab61-4426-68f6-08d9af4ee414 x-ms-traffictypediagnostic: MEYP282MB2816: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bKeSqxiZ5kuoMARlLZcn/IPz6keUuSdxH25lm00ieVxkiwb9iTMvhboGev6frgUnqKxfSlyCHaXbkYr4aq1Zrr8Cc+pJn1LWADU4/89s2sIuAswqJfgjiKry+YQYqejnuhXgjaP4//1wjHiCw6qFwmUALLIEuThgrgGu12NwDGqWVaUDKMq5khisPHKub2cwvaz486AItYcXIA3C/MgQYwQnMmhNlgTJ0jFCDC9mPMqNoxSeRnyqqoTRBPB1h0kSu3+VKBixln9j6rBKHbW8wvJy12rpYIEvbp8Xb3b+iJyNFQTpBP11QXgQX0MezlhRjfVLFlN92QBh7dmrxk/a04S7+VCgzR9U4QGGt8rja6l5zGi4AledPSDuDRMz+HJCq5sd4eGLS/G8pcfo56Lg9L7GLju3fAncFk0v6Yn0xQWK0434bp/AiEGhqU4wJjFulachP7KhWOinoAtw0GIEXeafDW+P8oLYICMPVZ82m5rnO2qB2T5fYLmP5iKZtVNVcjjK+zlrYYhyM2/ouRmKVkqhV/UAb2QjCLZgPGmsGQGvHvGdBVMoUjC3qxRDqEdyf6xEU6TITqXC7APLPBEF/A== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: /V2ZukvcteBDvRtaWalflCc/C538Br8i/OcEDXMqSQ4wxEF6Ivb9HAZrdAY1/v+fo8vqYTGEjtSTuTdulteO/5aGicKxOO6JyRphGK3rkZa1TUogsvxFVDiva3krOrvG52HIqWTDQ9VN66cHeD9+mBZBU4QbuFq17m9BLDNB91DEaZjZuy314RYqghPWob49TA7miFqRST6/tLJDm8L2+9LAvdbY1QilY/1e+RBj+tl9jN1D//LNojZuQKI96cxWtjlwkw6kvkbCcjKeLvUP6dF3mQQpEaed/CWxSbzll92SR9bL51VwezHqjEL/a8NDLUK2ZS2soYh8OZlfpwUnhYjoL0FtC25+MmnQ1OI6Oeo6Pwr/C1HIIDievOueqoLvGezeS3ysUfRP2c/jrXuco9prnbm+nkt9DibrGFsdYNWkhELkkxTnfJiKMihuPiUITrXXPn7TGvNW0Xl4mMt+J8ZeW1djzIsit4IgWAshdgdQwd5cDAtLFag1GU38YS4MrBYHCFB3B0/z+dmGsBzpM6m7WHKCoP2MVOAwXLGLM1ghW7nL1AsS5PgkVRyk7c5HPLcX5RRyy31DBbK03Z+cEdpTOv2ymZkarmfiKRqSiBMxNiaXQpzz3wpeLNdasDzyw2cVwuV/P51cHY8ueH+UMutUZuXkIhAT8Ok8jXHRi9IV6i9TGgnzIUbIAX22W7J+xv6jGuQs6Tc/P6n+yfeQmuDS6rUl52607QDLnaKz3D9w4QtRAZuwtxQsx04qBk/6 MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MEYP282MB3302.AUSP282.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: c07c3f91-ab61-4426-68f6-08d9af4ee414 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2021 13:32:41.7084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MEYP282MB2816 Cc: "i.maximets" Subject: [ovs-dev] [PATCH v3] netdev-vport : Fix userspace tunnel ioctl(SIOCGIFINDEX) info logs. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" From: linhuang Userspace tunnel doesn't have a valid device in the kernel. So get_ifindex() function (ioctl) always get error during adding a port, deleting a port or updating a port status. The info log is "2021-08-29T09:17:39.830Z|00059|netdev_linux|INFO|ioctl(SIOCGIFINDEX) on vxlan_sys_4789 device failed: No such device" If there are a lot of userspace tunnel ports on a bridge, the iface_refresh_netdev_status() function will spend a lot of time. So ignore userspace tunnel port ioctl(SIOCGIFINDEX) operation, just return -ENODEV. Signed-off-by: Lin Huang Test-by: Mike Pattrick Reviewed-by: Aaron Conole Reviewed-by: Ilya Maximets Acked-by: Mike Pattrick Acked-by: Aaron Conole --- lib/netdev-vport.c | 4 +++- vswitchd/bridge.c | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) -- 1.8.3.1 diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c index 499c029..f0ff02b 100644 --- a/lib/netdev-vport.c +++ b/lib/netdev-vport.c @@ -1151,8 +1151,10 @@ netdev_vport_get_ifindex(const struct netdev *netdev_) { char buf[NETDEV_VPORT_NAME_BUFSIZE]; const char *name = netdev_vport_get_dpif_port(netdev_, buf, sizeof(buf)); + const char *dpif_type = netdev_get_dpif_type(netdev_); - return linux_get_ifindex(name); + return (dpif_type && !strcmp(dpif_type, "system") + ? linux_get_ifindex(name) : -ENODEV); } #define NETDEV_VPORT_GET_IFINDEX netdev_vport_get_ifindex diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 5223aa8..513ef7e 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -2052,6 +2052,8 @@ iface_do_create(const struct bridge *br, goto error; } + netdev_set_dpif_type(netdev, br->ofproto->type); + error = iface_set_netdev_config(iface_cfg, netdev, errp); if (error) { goto error;