diff mbox

[ovs-dev,v3,3/7] dpif-netlink: code to create/destroy tunnel ports via rtnetlink

Message ID CAPWQB7Hz6sjkM7J09dvybqWWXCyxYFULdTtcmsu8m-ckYGV06A@mail.gmail.com
State Not Applicable
Headers show

Commit Message

Joe Stringer April 27, 2017, 9:37 p.m. UTC 
On 13 April 2017 at 13:47, Eric Garver <e@erig.me> wrote:
> In order to be able to add those tunnels, we need to add code to create
> the tunnels and add them as NETDEV vports. And when there is no support
> to create them, we need to fallback to compatibility code and add them
> as tunnel vports.
>
> When removing those tunnels, we need to remove the interfaces as well,
> and detecting the right type might be important, at least to distinguish
> the tunnel vports that we should remove and the interfaces that we
> shouldn't.
>
> Co-authored-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>
> Signed-off-by: Eric Garver <e@erig.me>
> ---

Hi Eric (and Thadeu!), thanks for the patches. A couple of minor
comments on this patch:

As a matter of style, please use the imperative in commit messages and
keep them ideally below 50 characters. For instance, rather than
"dpif-netlink: code to create/destroy tunnel ports via rtnetlink", try
"dpif-netlink: Support rtnetlink port creation.". For a refresher, see
the documentation here:

http://docs.openvswitch.org/en/latest/internals/contributing/submitting-patches/

This fixup also makes the error messages more clear in the logs when
something fails on the rtnetlink interface.

    }
diff mbox

Patch

diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
index 5244d7e24179..4d3d4ffe81bc 100644
--- a/lib/dpif-netlink.c
+++ b/lib/dpif-netlink.c
@@ -967,8 +967,8 @@  dpif_netlink_rtnl_port_create_and_add(struct
dpif_netlink *dpif,
    error = dpif_netlink_rtnl_port_create(netdev);
    if (error) {
        if (error != EOPNOTSUPP) {
-            VLOG_INFO_RL(&rl, "Failed to create %s with rtnetlink. error = %d",
-                         netdev_get_name(netdev), error);
+            VLOG_INFO_RL(&rl, "Failed to create %s with rtnetlink: %s",
+                         netdev_get_name(netdev), ovs_strerror(error));
        }
        return error;