| Message ID | CAPWQB7FGqihyeDtGTxauoafaLKyiabG1fp-n3CXnrv-npZ1KpQ@mail.gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 01/13/2016 07:37 PM, Joe Stringer wrote: > On 13 January 2016 at 11:03, Russell Bryant <russell@ovn.org> wrote: >> On 01/13/2016 01:59 PM, Joe Stringer wrote: >>> These pieces of documentation were not updated when the CS_* flags were >>> reordered on the OpenFlow interface. >>> >>> Fixes: 63bc9fb1c69f ("packets: Reorder CS_* flags to remove gap.") >>> Signed-off-by: Joe Stringer <joe@ovn.org> >> >> Acked-by: Russell Bryant <russell@ovn.org> > > Thanks for the review, > > I noticed one last mistake before pushing, so I applied your ack and > this incremental and pushed the patch to master and branch-2.5: Argh! I read this simple patch multiple times and still missed that. Numbers are hard. :-)
On 14 January 2016 at 06:03, Russell Bryant <russell@ovn.org> wrote: > On 01/13/2016 07:37 PM, Joe Stringer wrote: >> On 13 January 2016 at 11:03, Russell Bryant <russell@ovn.org> wrote: >>> On 01/13/2016 01:59 PM, Joe Stringer wrote: >>>> These pieces of documentation were not updated when the CS_* flags were >>>> reordered on the OpenFlow interface. >>>> >>>> Fixes: 63bc9fb1c69f ("packets: Reorder CS_* flags to remove gap.") >>>> Signed-off-by: Joe Stringer <joe@ovn.org> >>> >>> Acked-by: Russell Bryant <russell@ovn.org> >> >> Thanks for the review, >> >> I noticed one last mistake before pushing, so I applied your ack and >> this incremental and pushed the patch to master and branch-2.5: > > Argh! I read this simple patch multiple times and still missed that. > Numbers are hard. :-) Sometimes your eyes just see what they want to see :-)
diff --git a/lib/meta-flow.h b/lib/meta-flow.h index 08170eaf325b..53bbc9ecb2a3 100644 --- a/lib/meta-flow.h +++ b/lib/meta-flow.h @@ -747,7 +747,7 @@ enum OVS_PACKED_ENUM mf_field_id { * - Established (0x02): This is part of an already existing connection. * - Related (0x04): This is a separate connection that is related to an * existing connection. - * - Reply (0x80): This flow is in the reply direction, ie it did not + * - Reply (0x08): This flow is in the reply direction, ie it did not * initiate the connection. * - Invalid (0x10): This flow could not be associated with a connection. * This could be set for a variety of reasons,