From patchwork Thu Oct 15 00:49:44 2015
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Joe Stringer
X-Patchwork-Id: 530453
Return-Path:
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from archives.nicira.com (li376-54.members.linode.com
[96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 6D6A6140E42
for ;
Thu, 15 Oct 2015 11:50:08 +1100 (AEDT)
Received: from archives.nicira.com (localhost [127.0.0.1])
by archives.nicira.com (Postfix) with ESMTP id B4D2B109EA;
Wed, 14 Oct 2015 17:50:07 -0700 (PDT)
X-Original-To: dev@openvswitch.org
Delivered-To: dev@openvswitch.org
Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67])
by archives.nicira.com (Postfix) with ESMTPS id D44D1108F9
for ; Wed, 14 Oct 2015 17:50:05 -0700 (PDT)
Received: from bar5.cudamail.com (localhost [127.0.0.1])
by mx1e3.cudamail.com (Postfix) with ESMTPS id 58763420068
for ; Wed, 14 Oct 2015 18:50:05 -0600 (MDT)
X-ASG-Debug-ID: 1444870204-09eadd76e204520001-byXFYA
Received: from mx1-pf2.cudamail.com ([192.168.24.2]) by bar5.cudamail.com
with
ESMTP id pmBkYPpqIripvFgh (version=TLSv1 cipher=DHE-RSA-AES256-SHA
bits=256 verify=NO) for ;
Wed, 14 Oct 2015 18:50:04 -0600 (MDT)
X-Barracuda-Envelope-From: stringerjoe@nicira.com
X-Barracuda-RBL-Trusted-Forwarder: 192.168.24.2
Received: from unknown (HELO mail-yk0-f175.google.com) (209.85.160.175)
by mx1-pf2.cudamail.com with ESMTPS (RC4-SHA encrypted);
15 Oct 2015 00:50:04 -0000
Received-SPF: unknown (mx1-pf2.cudamail.com: Multiple SPF records returned)
X-Barracuda-Apparent-Source-IP: 209.85.160.175
X-Barracuda-RBL-IP: 209.85.160.175
Received: by ykoo7 with SMTP id o7so63960484yko.0
for ; Wed, 14 Oct 2015 17:50:03 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc:content-type;
bh=0aS/BdndxdbxxljnRvAFfSgSzBWrsrEuBhHWX4H1XHo=;
b=bVTGBqZoUQzTCY7ZpWJ8HW0t+vrg7lup6o1qOnUqYDaFUvlHqAyUKJG12ZRFk4kE4C
2M4sW2fzNhtLKFkHGe3FyZl2hG1Rw8q/9zm9jNap0MzDAgcS9i5d3og/AiyjJ+zdfz3s
E7Fe9yxA1NQoKCih3qSUb/SEd4ECSN6oiHPCLk+WhzgpWvvd/oXGZPI8CVpbPNPJXtqI
V/QrLRN927RQejd+svjaMxnh0HuALRBLJIYVHjmSIyQBjnTqMIoyArrkJy8XksmNctWJ
+jENaWWC0pCDH8MZeb8sqUtlHjI2tXL/h6WuLz20/W5hSSXAVh+SCrukTw0uW5lYYaWT
LzXg==
X-Gm-Message-State:
ALoCoQmqtBzhzna+949C8iWoRwixsSE7CJOQg+BXunuObWSQkSjRvFZz5mAVfaihBySdDTo1WuPf
X-Received: by 10.129.78.88 with SMTP id c85mr1881880ywb.345.1444870203837;
Wed, 14 Oct 2015 17:50:03 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.13.193.68 with HTTP; Wed, 14 Oct 2015 17:49:44 -0700 (PDT)
In-Reply-To:
References: <1444854420-59975-1-git-send-email-joestringer@nicira.com>
X-CudaMail-Envelope-Sender: stringerjoe@nicira.com
From: Joe Stringer
Date: Wed, 14 Oct 2015 17:49:44 -0700
Message-ID:
X-CudaMail-Whitelist-To: dev@openvswitch.org
X-CudaMail-Whitelist-To: dev@openvswitch.org
X-CudaMail-MID: CM-E2-1013111969
X-CudaMail-DTE: 101415
X-CudaMail-Originating-IP: 209.85.160.175
To: Justin Pettit
X-ASG-Orig-Subj: [##CM-E2-1013111969##]Re: [ovs-dev] [PATCH]
ovs-vswitchd.conf.db.5: Update docs for max-idle.
X-Barracuda-Connect: UNKNOWN[192.168.24.2]
X-Barracuda-Start-Time: 1444870204
X-Barracuda-Encrypted: DHE-RSA-AES256-SHA
X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi
X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?=
X-Virus-Scanned: by bsmtpd at cudamail.com
X-Barracuda-BRTS-Status: 1
Cc: "dev@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH] ovs-vswitchd.conf.db.5: Update docs for
max-idle.
X-BeenThere: dev@openvswitch.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dev-bounces@openvswitch.org
Sender: "dev"
On 14 October 2015 at 15:02, Justin Pettit wrote:
>
>> On Oct 14, 2015, at 1:27 PM, Joe Stringer wrote:
>>
>> When this configuration parameter was initially introduced into the
>> database, the documentation was not updated to describe where it
>> resides.
>
> I think we didn't document it on purpose. If we're going to document it, I'd recommend that we still discourage tweaking the value.
How about this incremental. The flow-limit in the same column could
probably use this incremental, too.
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 6a699e0da180..aac4bd8c7fcc 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -158,7 +158,8 @@
The maximum time (in ms) that idle flows will remain cached in the
datapath. Internally OVS will check the validity and activity for
datapath flows regularly and may expire flows quicker than this
- number, based on real time network conditions.
+ number, based on real time network conditions. Tweaking this
+ value is discouraged unless you know exactly what you're doing.
The default is 10000.