diff mbox

[ovs-dev] ovs-vswitchd.conf.db.5: Update docs for max-idle.

Message ID CANr6G5xHC33hYKo8gKs6skzfi+a_7OzjMZ28EyB8_BdMy2yh3g@mail.gmail.com
State Accepted, archived
Headers show

Commit Message

Joe Stringer Oct. 15, 2015, 12:49 a.m. UTC
On 14 October 2015 at 15:02, Justin Pettit <jpettit@nicira.com> wrote:
>
>> On Oct 14, 2015, at 1:27 PM, Joe Stringer <joestringer@nicira.com> wrote:
>>
>> When this configuration parameter was initially introduced into the
>> database, the documentation was not updated to describe where it
>> resides.
>
> I think we didn't document it on purpose.  If we're going to document it, I'd recommend that we still discourage tweaking the value.

How about this incremental. The flow-limit in the same column could
probably use this incremental, too.

Comments

Ben Pfaff Oct. 15, 2015, 2:17 a.m. UTC | #1
On Wed, Oct 14, 2015 at 05:49:44PM -0700, Joe Stringer wrote:
> On 14 October 2015 at 15:02, Justin Pettit <jpettit@nicira.com> wrote:
> >
> >> On Oct 14, 2015, at 1:27 PM, Joe Stringer <joestringer@nicira.com> wrote:
> >>
> >> When this configuration parameter was initially introduced into the
> >> database, the documentation was not updated to describe where it
> >> resides.
> >
> > I think we didn't document it on purpose.  If we're going to document it, I'd recommend that we still discourage tweaking the value.
> 
> How about this incremental. 

I like it, thanks.

> The flow-limit in the same column could probably use this incremental,
> too.

Do you want to make that change too?
Joe Stringer Oct. 15, 2015, 3:28 a.m. UTC | #2
On 14 October 2015 at 19:17, Ben Pfaff <blp@nicira.com> wrote:
> On Wed, Oct 14, 2015 at 05:49:44PM -0700, Joe Stringer wrote:
>> On 14 October 2015 at 15:02, Justin Pettit <jpettit@nicira.com> wrote:
>> >
>> >> On Oct 14, 2015, at 1:27 PM, Joe Stringer <joestringer@nicira.com> wrote:
>> >>
>> >> When this configuration parameter was initially introduced into the
>> >> database, the documentation was not updated to describe where it
>> >> resides.
>> >
>> > I think we didn't document it on purpose.  If we're going to document it, I'd recommend that we still discourage tweaking the value.
>>
>> How about this incremental.
>
> I like it, thanks.
>
>> The flow-limit in the same column could probably use this incremental,
>> too.
>
> Do you want to make that change too?

Sure. Is it something we want to backport or just apply to master?
Justin Pettit Oct. 15, 2015, 4:55 a.m. UTC | #3
> On Oct 14, 2015, at 8:28 PM, Joe Stringer <joestringer@nicira.com> wrote:
> 
>> Do you want to make that change too?
> 
> Sure. Is it something we want to backport or just apply to master?

I'd just apply it to master.  I don't think we've had any issues with it.

--Justin
Joe Stringer Oct. 15, 2015, 4:51 p.m. UTC | #4
On 14 October 2015 at 21:55, Justin Pettit <jpettit@nicira.com> wrote:
>
>> On Oct 14, 2015, at 8:28 PM, Joe Stringer <joestringer@nicira.com> wrote:
>>
>>> Do you want to make that change too?
>>
>> Sure. Is it something we want to backport or just apply to master?
>
> I'd just apply it to master.  I don't think we've had any issues with it.

OK, I folded the incremental into the patch and pushed it to master. I
also pushed a similar incremental as a separate patch for flow-limit. Thanks.
diff mbox

Patch

diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 6a699e0da180..aac4bd8c7fcc 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -158,7 +158,8 @@ 
           The maximum time (in ms) that idle flows will remain cached in the
           datapath. Internally OVS will check the validity and activity for
           datapath flows regularly and may expire flows quicker than this
-          number, based on real time network conditions.
+          number, based on real time network conditions. Tweaking this
+          value is discouraged unless you know exactly what you're doing.
         </p>
         <p>
           The default is 10000.