From patchwork Wed Jun 8 13:05:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Zong Kai LI X-Patchwork-Id: 632231 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3rPpb81Njfz9t0r for ; Wed, 8 Jun 2016 23:05:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=vcZT4J+S; dkim-atps=neutral Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 086AF10934; Wed, 8 Jun 2016 06:05:55 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx1e3.cudamail.com (mx1.cudamail.com [69.90.118.67]) by archives.nicira.com (Postfix) with ESMTPS id 3A77F10933 for ; Wed, 8 Jun 2016 06:05:53 -0700 (PDT) Received: from bar5.cudamail.com (localhost [127.0.0.1]) by mx1e3.cudamail.com (Postfix) with ESMTPS id A1E81420379 for ; Wed, 8 Jun 2016 07:05:52 -0600 (MDT) X-ASG-Debug-ID: 1465391150-09eadd4df912ba10001-byXFYA Received: from mx3-pf1.cudamail.com ([192.168.14.2]) by bar5.cudamail.com with ESMTP id oZRLzbBPMkeoBaPE (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 08 Jun 2016 07:05:50 -0600 (MDT) X-Barracuda-Envelope-From: zealokii@gmail.com X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.2 Received: from unknown (HELO mail-io0-f193.google.com) (209.85.223.193) by mx3-pf1.cudamail.com with ESMTPS (AES128-SHA encrypted); 8 Jun 2016 13:05:49 -0000 Received-SPF: pass (mx3-pf1.cudamail.com: SPF record at _netblocks.google.com designates 209.85.223.193 as permitted sender) X-Barracuda-RBL-Trusted-Forwarder: 209.85.223.193 Received: by mail-io0-f193.google.com with SMTP id 5so1186560ioy.0 for ; Wed, 08 Jun 2016 06:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=IALefxDmDDg7B8jWnnhyW4IaBlzl5oF+QN5hHQDG12k=; b=vcZT4J+SMh8DMtD9IZLXky/Dtpo5sWJiosn5q3bmy0dmlJa3pl+RzvvA+wxiCCfWGR R19nExBn8L8qEDPYkXG516D+T8pZKn7WMmzBUKAaDn3FCxsz1F/Ctxkca/8hSRFt1aoa DTH1Ai6foMzA0OwYK0EBw79augHUh/LFVfaWf8XxpfuYAEl0H6/QRYqVbiJKy6oLCJlz mWR244r+TrTxFrmxU5SUfCEUA1UJIqAW13SshCDNoAmofEgI7bu3i7lFn6XZp/Tj+XNT fTrGb/O5OOHY7Wxm6aIRfUYUNwrSKMDVKUVsFUZ+tk0Q3nQ74cvzywXY1hwPVhjF+SCd YZag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IALefxDmDDg7B8jWnnhyW4IaBlzl5oF+QN5hHQDG12k=; b=R1Vh6MYDlmd13rQ8oTiD0Ltx+nTO+6RY68sqvQzYSbCFztexPNyCOWvE4yOjyo9jxf gk2Mx7HxQLVfWYedyA7+Goeri/bK8iZ5GxCfvSWg+zna2omF8ewc8y/+SgFzYwrgSh+7 cI+P12V7HF9mVQbiAIbIlUtwpER9jqNyBQIE2IxTQz+phySyTPiaU01aBYHFNFIchNDy Un/laM59aw3LtyTJtHGYmWcNOwg5H5/rhb6eHEXxP/kpUAot5q8LJOLVDNYBwXilqUZw o9C4T7UmkWQiR/lIZwYolxg+P5vC7SKuJStbb3iEjtHOuZRx8AxkhwoQTqxPJWgQ4+I7 ut4A== X-Gm-Message-State: ALyK8tLQ6k6IYo7j1PFfI6RpFy8R2gQp3CE59fo37lfextxDaJFyHeJG2fcAqqz51lAx5BfgAAynDz7P/n6M3w== X-Received: by 10.107.47.152 with SMTP id v24mr9154570iov.8.1465391148434; Wed, 08 Jun 2016 06:05:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.198.71 with HTTP; Wed, 8 Jun 2016 06:05:47 -0700 (PDT) In-Reply-To: References: <1465370790-28836-1-git-send-email-zealokii@gmail.com> X-CudaMail-Envelope-Sender: zealokii@gmail.com From: Zong Kai LI Date: Wed, 8 Jun 2016 21:05:47 +0800 Message-ID: X-CudaMail-MID: CM-V1-607009908 X-CudaMail-DTE: 060816 X-CudaMail-Originating-IP: 209.85.223.193 To: Numan Siddique X-ASG-Orig-Subj: [##CM-V1-607009908##]Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND X-GBUdb-Analysis: 0, 209.85.223.193, Ugly c=0.214287 p=-0.25 Source Normal X-MessageSniffer-Rules: 0-0-0-21251-c X-Barracuda-Connect: UNKNOWN[192.168.14.2] X-Barracuda-Start-Time: 1465391150 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.10 X-Barracuda-Spam-Status: No, SCORE=0.10 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=4.0 tests=BSF_SC0_MISMATCH_TO, DKIM_SIGNED, HTML_MESSAGE, RDNS_NONE X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.30271 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.00 HTML_MESSAGE BODY: HTML included in message 0.10 RDNS_NONE Delivered to trusted network by a host with no rDNS X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: ovs dev Subject: Re: [ovs-dev] [PATCH] [PATCH v3 1/2] ovn-controller: Add 'na' action for ND X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" On Wed, Jun 8, 2016 at 6:19 PM, Numan Siddique wrote: > >> --- a/ovn/ovn-sb.xml >> +++ b/ovn/ovn-sb.xml >> @@ -985,6 +985,55 @@ >>

Prerequisite: ip4

>> >> >> +
>> + na{A; action; ... >> }; >> +
>> + >> +
>> +

>> + Temporarily replaces the IPv6 packet being processed by an NA >> + packet and executes each nested action on the NA >> + packet. Actions following the na action, if any, >> apply >> + to the original, unmodified packet. >> +

>> + >> +

>> + The NA packet that this action operates on is initialized >> based on >> + the IPv6 packet being processed(with userdata), as follows: >> +

>> + >> +
    >> +
  • eth.dst copied from eth.src
    • >> +
  • eth.src copied from userdata
    • >> +
  • eth.type = 0x86dd
    • >> +
  • ip6.dst copied from >> ip6.src
    • >> +
  • ip6.src copied from >> nd.target
    • >> +
  • icmp6.type = 136 (Neighbor >> Advertisement)
    • >> +
  • nd.target unchanged
    • >> +
  • nd.sll = 00:00:00:00:00:00
    • >> +
  • nd.sll copied from userdata
    • >> +
>> + >> +

>> + These are default values that the nested actions will >> probably want >> + to change: >> +

>> + >> +

    >> +
  • reg0 = 0x1(Mark as replied by >> ovn-controller)
    • >> +
  • outport copied from inport
    • >> +
  • inport = ""
    • >> +
>> + >> + The ND packet has the same VLAN header, if any, as the IP >> packet >> + it replaces. >> +

>> + >> +

>> + Prerequisite: nd&&icmp6.type == >> 135 >> +

>> +
>> + >> >> > ​Hi Zong Kai LI, > I am seeing compilation errors when I apply this patch. Probably some xml > tag above has a mismatch. > > ----------- > File "/usr/lib64/python2.7/xml/dom/expatbuilder.py", line 207, in > parseFile > parser.Parse(buffer, 0) > xml.parsers.expat.ExpatError: mismatched tag: line 1035, column 10 > Makefile:6208: recipe for target 'ovn/ovn-sb.5' failed > > ​------------​ > >> >> _______________________________________________ >> dev mailing list >> dev@openvswitch.org >> http://openvswitch.org/mailman/listinfo/dev >> > > Hi, Numan. Sorry for that mistake, the correct things should be like:
  • reg0 = 0x1(Mark as replied by ovn-controller)
    • @@ -1025,6 +1025,7 @@
  • inport = ""
    • +

    The ND packet has the same VLAN header, if any, as the IP packet it replaces.

    And I noticed you add a comment in the other patch: "This patch fails to apply on the latest master.". I'm not sure what does that mean? Once things get clear, I will try to submit a new patch later. Thanks for your time and have a nice day! :) Best regards, Zong Kai, LI diff --git a/ovn/ovn-sb.xml b/ovn/ovn-sb.xml index 5189401..857105d 100644 --- a/ovn/ovn-sb.xml +++ b/ovn/ovn-sb.xml @@ -1017,7 +1017,7 @@

    These are default values that the nested actions will probably want to change: -

    +