From patchwork Thu Mar 24 20:56:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Gurucharan Shetty X-Patchwork-Id: 601808 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from archives.nicira.com (archives.nicira.com [96.126.127.54]) by ozlabs.org (Postfix) with ESMTP id 3qWJdD2S0Yz9s8d for ; Fri, 25 Mar 2016 07:56:32 +1100 (AEDT) Received: from archives.nicira.com (localhost [127.0.0.1]) by archives.nicira.com (Postfix) with ESMTP id 6004B10865; Thu, 24 Mar 2016 13:56:31 -0700 (PDT) X-Original-To: dev@openvswitch.org Delivered-To: dev@openvswitch.org Received: from mx3v3.cudamail.com (mx3.cudamail.com [64.34.241.5]) by archives.nicira.com (Postfix) with ESMTPS id 859661080A for ; Thu, 24 Mar 2016 13:56:30 -0700 (PDT) Received: from bar6.cudamail.com (localhost [127.0.0.1]) by mx3v3.cudamail.com (Postfix) with ESMTPS id 1D7291611C2 for ; Thu, 24 Mar 2016 14:56:30 -0600 (MDT) X-ASG-Debug-ID: 1458852989-0b323711be2b6d40001-byXFYA Received: from mx3-pf2.cudamail.com ([192.168.14.1]) by bar6.cudamail.com with ESMTP id u6Z8JJ3MKHaRTVNm (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 24 Mar 2016 14:56:29 -0600 (MDT) X-Barracuda-Envelope-From: guru@ovn.org X-Barracuda-RBL-Trusted-Forwarder: 192.168.14.1 Received: from unknown (HELO relay8-d.mail.gandi.net) (217.70.183.201) by mx3-pf2.cudamail.com with ESMTPS (DHE-RSA-AES256-SHA encrypted); 24 Mar 2016 20:56:29 -0000 Received-SPF: pass (mx3-pf2.cudamail.com: SPF record at ovn.org designates 217.70.183.201 as permitted sender) X-Barracuda-Apparent-Source-IP: 217.70.183.201 X-Barracuda-RBL-IP: 217.70.183.201 Received: from mfilter24-d.gandi.net (mfilter24-d.gandi.net [217.70.178.152]) by relay8-d.mail.gandi.net (Postfix) with ESMTP id A4AC640490 for ; Thu, 24 Mar 2016 21:56:26 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter24-d.gandi.net Received: from relay8-d.mail.gandi.net ([IPv6:::ffff:217.70.183.201]) by mfilter24-d.gandi.net (mfilter24-d.gandi.net [::ffff:10.0.15.180]) (amavisd-new, port 10024) with ESMTP id 30ufOAX8oXDz for ; Thu, 24 Mar 2016 21:56:24 +0100 (CET) X-Originating-IP: 209.85.217.180 Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com [209.85.217.180]) (Authenticated sender: guru@ovn.org) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 3E71B4048F for ; Thu, 24 Mar 2016 21:56:24 +0100 (CET) Received: by mail-lb0-f180.google.com with SMTP id bc4so38612817lbc.2 for ; Thu, 24 Mar 2016 13:56:24 -0700 (PDT) X-Gm-Message-State: AD7BkJIxGEDyxDKJ7uDclk21bBOk3aHYNcmSpsQzxvQwODV97YbPnGuqoOpSJk/+656W+C4uh0RWvPPDf9n6Aw== MIME-Version: 1.0 X-Received: by 10.112.13.33 with SMTP id e1mr3621887lbc.79.1458852983735; Thu, 24 Mar 2016 13:56:23 -0700 (PDT) Received: by 10.114.78.40 with HTTP; Thu, 24 Mar 2016 13:56:23 -0700 (PDT) In-Reply-To: References: <1458592801-20814-1-git-send-email-rmoats@us.ibm.com> <1458592801-20814-2-git-send-email-rmoats@us.ibm.com> <20160323210500.GT25186@ovn.org> Date: Thu, 24 Mar 2016 13:56:23 -0700 X-Gmail-Original-Message-ID: Message-ID: X-CudaMail-Whitelist-To: dev@openvswitch.org X-CudaMail-MID: CM-V2-323053259 X-CudaMail-DTE: 032416 X-CudaMail-Originating-IP: 217.70.183.201 X-CudaMail-Envelope-Sender: guru@ovn.org X-ASG-Orig-Subj: [##CM-V2-323053259##]Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes From: Guru Shetty To: Russell Bryant X-Barracuda-Connect: UNKNOWN[192.168.14.1] X-Barracuda-Start-Time: 1458852989 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://web.cudamail.com:443/cgi-mod/mark.cgi X-ASG-Whitelist: Header =?UTF-8?B?eFwtY3VkYW1haWxcLXdoaXRlbGlzdFwtdG8=?= X-Virus-Scanned: by bsmtpd at cudamail.com X-Barracuda-BRTS-Status: 1 X-Content-Filtered-By: Mailman/MimeDel 2.1.16 Cc: ovs dev , Michael Subject: Re: [ovs-dev] [PATCH v11 1/1] Separating OVN NB and SB database processes X-BeenThere: dev@openvswitch.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@openvswitch.org Sender: "dev" I saw the following 3 issues when I did a git pull today. It is possible that I am not doing something the "new" way. 1. root@ovn1:~/git/routes# /usr/share/openvswitch/scripts/ovn-ctl restart_northd * Exiting ovn-northd (30705) 2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to /var/run/openvswitch/ovnnb_db.30694.ctl ovs-appctl: cannot connect to "/var/run/openvswitch/ovnnb_db.30694.ctl" (No such file or directory) 2016-03-24T10:56:44Z|00001|unixctl|WARN|failed to connect to /var/run/openvswitch/ovnsb_db.30700.ctl ovs-appctl: cannot connect to "/var/run/openvswitch/ovnsb_db.30700.ctl" (No such file or directory) * Starting ovn-northd I think the above needs the following incremental. I think it is unfortunate that we will have to run the commands of the following form in the future for runtime information: ovs-appctl -t /var/run/openvswitch/ovnnb_db ovsdb-server/list-remotes But I guess, I will get used to it. 2. The ovsdb-server daemons are getting started with --log-file set to "/" . For e.g: ovsdb-server --detach -vconsole:off --log-file=/ovsdb-server-nb.log 3. The databases are being created in /var/run/openvswitch That feels like an odd place to keep databases. We have been keeping it in /etc/openvswitch so far. On 23 March 2016 at 17:11, Russell Bryant wrote: > On Wed, Mar 23, 2016 at 5:05 PM, Ben Pfaff wrote: > > > On Mon, Mar 21, 2016 at 03:40:01PM -0500, Ryan Moats wrote: > > > From: RYAN D. MOATS > > > > > > OVN NB & SB DB's should be run in separate ovsdb-server processes > > > and should run with ovn-ctl start_northd / stop_northd. This patch > > > includes changes to unit tests, tutorial and debian scripts to remain > > > self-consistent. > > > > > > Signed-off-by: RYAN D. MOATS > > > Signed-off-by: Michael Arnaldi > > > > This seems OK to me. > > > > From our IRC conversation, it sounds like there should be a > > Co-authored-by for Michael Arnaldi. > > > > Since Russell has taken the lead on this I'll leave the final review and > > apply to him. > > > > Thanks for working on this Michael and Ryan! The latest version looked > good to me. I applied it to master with the following minor changes: a > whitespace fix, adding Michael to AUTHORS, and removing duplicate help > text. > > diff --git a/AUTHORS b/AUTHORS > index 9e44e4c..f0d1e23 100644 > --- a/AUTHORS > +++ b/AUTHORS > @@ -141,6 +141,7 @@ Martino Fornasa mf@fornasa.it > Maryam Tahhan maryam.tahhan@intel.com > Mauricio Vásquez mauricio.vasquezbernal@studenti.polito.it > Mehak Mahajan mmahajan@nicira.com > +Michael Arnaldi arnaldimichael@gmail.com > Michal Weglicki michalx.weglicki@intel.com > Mijo Safradin mijo@linux.vnet.ibm.com > Minoru TAKAHASHI takahashi.minoru7@gmail.com > diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl > index 9dbaa64..4348d6e 100755 > --- a/ovn/utilities/ovn-ctl > +++ b/ovn/utilities/ovn-ctl > @@ -230,7 +230,6 @@ Options: > this is set to "no", the "start_ovsdb" > and > "stop_ovsdb" commands must be used to > start > and stop the OVN databases. > - --ovn-manage-ovsdb=no manage ovsdb separately from > start_northd and stop_northd > --ovn-controller-log=STRING ovn controller process logging params > (default: $OVN_CONTROLLER_LOG) > --ovn-northd-log=STRING ovn northd process logging params > (default: $OVN_NORTHD_LOG) > --ovn-nb-log=STRING ovn NB ovsdb-server processes logging > params (default: $OVN_NB_LOG) > diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox > index 51e3a9f..f331a00 100755 > --- a/tutorial/ovs-sandbox > +++ b/tutorial/ovs-sandbox > @@ -365,7 +365,7 @@ if $ovn; then > --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock \ > --ovnnb-db=unix:"$sandbox"/ovnnb_db.sock > rungdb $gdb_ovn_controller $gdb_ovn_controller_ex ovn-controller \ > - --detach --no-chdir --pidfile -vconsole:off --log-file > + --detach --no-chdir --pidfile -vconsole:off --log-file > rungdb $gdb_ovn_controller_vtep $gdb_ovn_controller_vtep_ex \ > ovn-controller-vtep --detach --no-chdir --pidfile -vconsole:off \ > --log-file --ovnsb-db=unix:"$sandbox"/ovnsb_db.sock > > > -- > Russell Bryant > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev > diff --git a/ovn/utilities/ovn-ctl b/ovn/utilities/ovn-ctl index 4348d6e..fb39754 100755 --- a/ovn/utilities/ovn-ctl +++ b/ovn/utilities/ovn-ctl @@ -37,11 +37,11 @@ pidfile_is_running () { stop_ovsdb () { if pidfile_is_running $DB_NB_PID; then - ovs-appctl -t ovnnb_db exit + ovs-appctl -t $OVN_DIR/ovnnb_db exit fi if pidfile_is_running $DB_SB_PID; then - ovs-appctl -t ovnsb_db exit + ovs-appctl -t $OVN_DIR/ovnsb_db exit fi }