From patchwork Fri Dec 22 12:34:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roberto Bartzen Acosta X-Patchwork-Id: 1879675 X-Patchwork-Delegate: horms@verge.net.au Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=luizalabs.com header.i=@luizalabs.com header.a=rsa-sha256 header.s=google header.b=Uw3UVv4d; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SxRYt16Xnz1ydZ for ; Fri, 22 Dec 2023 23:34:09 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 13F84424CC; Fri, 22 Dec 2023 12:34:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 13F84424CC Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=luizalabs.com header.i=@luizalabs.com header.a=rsa-sha256 header.s=google header.b=Uw3UVv4d X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gqEiGipfrjMY; Fri, 22 Dec 2023 12:34:07 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp4.osuosl.org (Postfix) with ESMTPS id 162BD42425; Fri, 22 Dec 2023 12:34:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 162BD42425 Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id DD418C0072; Fri, 22 Dec 2023 12:34:05 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 71679C0037 for ; Fri, 22 Dec 2023 12:34:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3892282046 for ; Fri, 22 Dec 2023 12:34:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3892282046 Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key) header.d=luizalabs.com header.i=@luizalabs.com header.a=rsa-sha256 header.s=google header.b=Uw3UVv4d X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1e8AUXsUns1v for ; Fri, 22 Dec 2023 12:34:04 +0000 (UTC) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by smtp1.osuosl.org (Postfix) with ESMTPS id D2E3081E96 for ; Fri, 22 Dec 2023 12:34:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org D2E3081E96 Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-50e55f97606so2634154e87.1 for ; Fri, 22 Dec 2023 04:34:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=luizalabs.com; s=google; t=1703248441; x=1703853241; darn=openvswitch.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=xGuf8WvlbozRT5qZX/j9FLvJUcgo1y0TUjA+PCyEUvc=; b=Uw3UVv4djNrIcoyXRJ3uia3tOrBEzzlspAiWHCQDHLNOV16alcFpZlvl7/KT4pd7i8 1ogcnOiXN68IRjEDsUt7efkXv/XLuf6zK8ypeaNV1zDFiSCVF9HvYqooVk2rRfV+mtkY aWUoumVMCbgLZqqG+NSyfcx1y6wIpxDf+TJbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703248441; x=1703853241; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xGuf8WvlbozRT5qZX/j9FLvJUcgo1y0TUjA+PCyEUvc=; b=bw+BmTstwqKLq2TrHs/DH+5KUyM8EMXFpnJTU2S2cqeNCW7bRRwA5i0U2UV9v+0B7Z kYV+EO1RG6b9sG8ThEKOVs4MRxTWzJ775dGSV+Fi5RmNaSIYr729mRVIZSVFmvVDNKAa Uxsuf9H3cxS8Yb/CPSmx9NlV/OigeZ0nEW5jd3xK4qjxlJtqW2TTMfrvDgoavr8621V6 5Y06mDgeBawUEzgrS/Md+UAogPdpiqTnRG+2RQNfvl8t4PpTcNzzQ6OzBTshljVXqC8c pgmee4xa6GTHuPb8iC3xZRNOXhFmQAz4FbcpLFxbgtqLaZ+mgYuzvdjEzcpPawlEvBXg eC7Q== X-Gm-Message-State: AOJu0Yx47dIHCz/NtIymKFyUr92bcffWmx/JbTFgcgW7XIu4A+KPibgp 5Y9fq4Cwq7+GhfGRWFHQJR3495IEpVakAab2q3s3Kket18XexfMPhoyj5Yu1mGed1/0oDnPMeDc 95R6wGL6pjdfvURtTQFWVM/QztDfoshTQzfVD0NIHj68= X-Google-Smtp-Source: AGHT+IHleij0a03y1m88/gHQyqT7pY+Zuz1peN5CQAAO6CVbjJWk6ziPQEyv2zBPzuLpMxdqSe16R67tZy8Rs65+o4o= X-Received: by 2002:a05:6512:3051:b0:50e:6ec3:6a42 with SMTP id b17-20020a056512305100b0050e6ec36a42mr33158lfb.126.1703248441264; Fri, 22 Dec 2023 04:34:01 -0800 (PST) MIME-Version: 1.0 Date: Fri, 22 Dec 2023 09:34:02 -0300 Message-ID: To: dev@openvswitch.org X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [ovs-dev] [PATCH ovs v2] debian/rules: Fix incorrect use of link-time optimizer. X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roberto Bartzen Acosta via dev From: Roberto Bartzen Acosta Reply-To: Roberto Bartzen Acosta Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" Current version of debian/rules simply uses the default lto GCC optimization settings during the linkage process. The main problem with this approach is that GCC on OS like Ubuntu Jammy, for example, can enable the -flto=auto option during the openvswitch building and linking process. In this case, the linked dynamic libraries would need to be builded based on the same lto optimization options, at the risk of not working, according to documentation [1]. I'm not sure of the real benefits of using this link-time optimization option, and since when it is enabled it causes problems with shared libs link libjemalloc, for example, it seems safer overwritten compiler decision by passing -fno-lto command. [1] https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html#index-flto Reported-at: https://bugs.launchpad.net/ubuntu/+source/openvswitch/+bug/2015748 Signed-off-by: Roberto Bartzen Acosta --- debian/rules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debian/rules b/debian/rules index dc5cc8a65..de8771813 100755 --- a/debian/rules +++ b/debian/rules @@ -2,7 +2,7 @@ # -*- makefile -*- #export DH_VERBOSE=1 export DEB_BUILD_MAINT_OPTIONS = hardening=+all -export DEB_CFLAGS_MAINT_APPEND = -fPIC +export DEB_CFLAGS_MAINT_APPEND = -fPIC -fno-lto %: dh $@