| Message ID | CAE3VLheSosx16w8WCxUhQexMxrj209JQhcpgX_-_HzfH-4DVLw@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
> > Hi > I found that OVS DPDK fails to build with DPDK 16.07 after commit > 01961bb. I am not sure if this is because of some expectations about > DPDK configuration or problems in the code. I could fix this fairly > easily with 4 additions to lib/dpdk.c (patch below), but am unsure > about whether this is what was intended. Hi, Apologies, I just submitted a very similar patch. I hadn't seen yours! I think the pdump include should be conditional, depending on whether DPDK_PDUMP is detected. It can also be taken out of netdev-dpdk.c as it's no longer required there. For my build I didn't require adding the ring and mempool includes to this file. Do you have additional DPDK config options set that require these headers to be included here? Thanks, Ciara > > Panda > > > > diff --git a/lib/dpdk.c b/lib/dpdk.c > index caea0f4..e998b65 100644 > --- a/lib/dpdk.c > +++ b/lib/dpdk.c > @@ -22,12 +22,16 @@ > #include <getopt.h> > > #include <rte_memzone.h> > +#include <rte_mempool.h> > +#include <rte_ring.h> > +#include <rte_pdump.h> > > #include "dirs.h" > #include "netdev-dpdk.h" > #include "openvswitch/dynamic-string.h" > #include "openvswitch/vlog.h" > #include "smap.h" > +#include "fatal-signal.h" > > VLOG_DEFINE_THIS_MODULE(dpdk); > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
diff --git a/lib/dpdk.c b/lib/dpdk.c index caea0f4..e998b65 100644 --- a/lib/dpdk.c +++ b/lib/dpdk.c @@ -22,12 +22,16 @@ #include <getopt.h> #include <rte_memzone.h> +#include <rte_mempool.h> +#include <rte_ring.h> +#include <rte_pdump.h> #include "dirs.h" #include "netdev-dpdk.h" #include "openvswitch/dynamic-string.h" #include "openvswitch/vlog.h" #include "smap.h" +#include "fatal-signal.h" VLOG_DEFINE_THIS_MODULE(dpdk); _______________________________________________