| Message ID | CADrDrPqc_XWCrA49Knbw0qJLes_iufExX-JaXwrhWQBcXMP4WQ@mail.gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
This seems to be an identical patch to one that Dennis Sam (cc'd) submitted a few hours ago. Did the two of you coordinate or is this just coincidence? I'm just curious how we want to handle authorship. I'm cc'ing Bruce and Anupam to get their take on the patch. --Justin > On May 11, 2016, at 3:15 PM, Saurabh Shrivastava <saurabh.shrivastava@nuagenetworks.net> wrote: > > Signed-off-by: Saurabh Shrivastava <saurabh.shrivastava@nuagenetworks.net> > --- > vtep/vtep.ovsschema | 7 +++++-- > vtep/vtep.xml | 8 ++++++++ > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/vtep/vtep.ovsschema b/vtep/vtep.ovsschema > index 533fd2e..799d760 100644 > --- a/vtep/vtep.ovsschema > +++ b/vtep/vtep.ovsschema > @@ -1,6 +1,6 @@ > { > "name": "hardware_vtep", > - "cksum": "770244945 11113", > + "cksum": "841956498 11245", > "tables": { > "Global": { > "columns": { > @@ -10,6 +10,9 @@ > "min": 0, "max": "unlimited"}}, > "switches": { > "type": {"key": {"type": "uuid", "refTable": "Physical_Switch"}, > + "min": 0, "max": "unlimited"}}, > + "other_config": { > + "type": {"key": "string", "value": "string", > "min": 0, "max": "unlimited"}} > }, > "maxRows": 1, > @@ -296,4 +299,4 @@ > "ephemeral": true}}, > "indexes": [["target"]], > "isRoot": false}}, > - "version": "1.5.1"} > + "version": "1.5.2"} > diff --git a/vtep/vtep.xml b/vtep/vtep.xml > index a3a6988..39d9bd3 100644 > --- a/vtep/vtep.xml > +++ b/vtep/vtep.xml > @@ -88,6 +88,14 @@ > table for more information. > </column> > </group> > + > + <group title="Common Column"> > + The overall purpose of this column is described under <code>Common > + Column</code> at the beginning of this document. > + > + <column name="other_config"/> > + </group> > + > </table> > > <table name="Manager" title="OVSDB management connection."> > -- > 1.8.3.1 > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev
Lets go with Dennis's patch. On Wed, May 11, 2016 at 3:19 PM, Justin Pettit <jpettit@ovn.org> wrote: > This seems to be an identical patch to one that Dennis Sam (cc'd) > submitted a few hours ago. Did the two of you coordinate or is this just > coincidence? I'm just curious how we want to handle authorship. > > I'm cc'ing Bruce and Anupam to get their take on the patch. > > --Justin > > > > On May 11, 2016, at 3:15 PM, Saurabh Shrivastava < > saurabh.shrivastava@nuagenetworks.net> wrote: > > > > Signed-off-by: Saurabh Shrivastava < > saurabh.shrivastava@nuagenetworks.net> > > --- > > vtep/vtep.ovsschema | 7 +++++-- > > vtep/vtep.xml | 8 ++++++++ > > 2 files changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/vtep/vtep.ovsschema b/vtep/vtep.ovsschema > > index 533fd2e..799d760 100644 > > --- a/vtep/vtep.ovsschema > > +++ b/vtep/vtep.ovsschema > > @@ -1,6 +1,6 @@ > > { > > "name": "hardware_vtep", > > - "cksum": "770244945 11113", > > + "cksum": "841956498 11245", > > "tables": { > > "Global": { > > "columns": { > > @@ -10,6 +10,9 @@ > > "min": 0, "max": "unlimited"}}, > > "switches": { > > "type": {"key": {"type": "uuid", "refTable": > "Physical_Switch"}, > > + "min": 0, "max": "unlimited"}}, > > + "other_config": { > > + "type": {"key": "string", "value": "string", > > "min": 0, "max": "unlimited"}} > > }, > > "maxRows": 1, > > @@ -296,4 +299,4 @@ > > "ephemeral": true}}, > > "indexes": [["target"]], > > "isRoot": false}}, > > - "version": "1.5.1"} > > + "version": "1.5.2"} > > diff --git a/vtep/vtep.xml b/vtep/vtep.xml > > index a3a6988..39d9bd3 100644 > > --- a/vtep/vtep.xml > > +++ b/vtep/vtep.xml > > @@ -88,6 +88,14 @@ > > table for more information. > > </column> > > </group> > > + > > + <group title="Common Column"> > > + The overall purpose of this column is described under <code>Common > > + Column</code> at the beginning of this document. > > + > > + <column name="other_config"/> > > + </group> > > + > > </table> > > > > <table name="Manager" title="OVSDB management connection."> > > -- > > 1.8.3.1 > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > >
> On May 11, 2016, at 3:30 PM, Saurabh Shrivastava <saurabh.shrivastava@nuagenetworks.net> wrote: > > Lets go with Dennis's patch. Sounds good. They're identical down to the checksum, so it makes it easy to see there's no difference. :-) Thanks, --Justin
Oh sorry, there was some co-ordination in terms of content but not it in terms of who was going to do it. :) On Wed, May 11, 2016 at 3:32 PM, Justin Pettit <jpettit@ovn.org> wrote: > > > On May 11, 2016, at 3:30 PM, Saurabh Shrivastava < > saurabh.shrivastava@nuagenetworks.net> wrote: > > > > Lets go with Dennis's patch. > > Sounds good. They're identical down to the checksum, so it makes it easy > to see there's no difference. :-) > > Thanks, > > --Justin > > >
diff --git a/vtep/vtep.ovsschema b/vtep/vtep.ovsschema index 533fd2e..799d760 100644 --- a/vtep/vtep.ovsschema +++ b/vtep/vtep.ovsschema @@ -1,6 +1,6 @@ { "name": "hardware_vtep", - "cksum": "770244945 11113", + "cksum": "841956498 11245", "tables": { "Global": { "columns": { @@ -10,6 +10,9 @@ "min": 0, "max": "unlimited"}}, "switches": { "type": {"key": {"type": "uuid", "refTable": "Physical_Switch"}, + "min": 0, "max": "unlimited"}}, + "other_config": { + "type": {"key": "string", "value": "string", "min": 0, "max": "unlimited"}} }, "maxRows": 1, @@ -296,4 +299,4 @@ "ephemeral": true}}, "indexes": [["target"]], "isRoot": false}}, - "version": "1.5.1"} + "version": "1.5.2"} diff --git a/vtep/vtep.xml b/vtep/vtep.xml index a3a6988..39d9bd3 100644 --- a/vtep/vtep.xml +++ b/vtep/vtep.xml @@ -88,6 +88,14 @@ table for more information. </column> </group> + + <group title="Common Column"> + The overall purpose of this column is described under <code>Common + Column</code> at the beginning of this document. + + <column name="other_config"/> + </group> + </table> <table name="Manager" title="OVSDB management connection.">
Signed-off-by: Saurabh Shrivastava <saurabh.shrivastava@nuagenetworks.net> --- vtep/vtep.ovsschema | 7 +++++-- vtep/vtep.xml | 8 ++++++++ 2 files changed, 13 insertions(+), 2 deletions(-)