diff mbox

[ovs-dev,09/40] datapath-windows: Fix possible NULL dereference in BufferMgmt

Message ID BY2PR0501MB21190F61A0EDC39E28007C53A2AD0@BY2PR0501MB2119.namprd05.prod.outlook.com
State Not Applicable
Headers show

Commit Message

Shashank Ram July 14, 2017, 4:56 p.m. UTC
diff mbox

Patch

diff --git a/datapath-windows/ovsext/BufferMgmt.c b/datapath-windows/ovsext/BufferMgmt.c
index 6354781..53490fa 100644
--- a/datapath-windows/ovsext/BufferMgmt.c
+++ b/datapath-windows/ovsext/BufferMgmt.c
@@ -1674,9 +1674,11 @@  OvsCompleteNBL(POVS_SWITCH_CONTEXT context,
         PNET_BUFFER nbTemp = NET_BUFFER_LIST_FIRST_NB(nbl);
         while (nbTemp) {
             PMDL mdl = NET_BUFFER_FIRST_MDL(nbTemp);
+            if (mdl) {
+                ASSERT(mdl->Next == NULL);
+                OvsFreeMDLAndData(mdl);
+            }
             NET_BUFFER_FIRST_MDL(nbTemp) = NULL;
-            ASSERT(mdl->Next == NULL);
-            OvsFreeMDLAndData(mdl);
             nbTemp = NET_BUFFER_NEXT_NB(nbTemp);
         }
     }