diff mbox

[ovs-dev] Documentation: Fix the ovs-ifup and ovs-ifdown examples in kvm.rst

Message ID 909750453d107ccfab511f3e0a382be7e5237df4.1490026489.git.tredaelli@redhat.com
State Accepted
Headers show

Commit Message

Timothy Redaelli March 20, 2017, 4:14 p.m. UTC
Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
---
 Documentation/howto/kvm.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Ben Pfaff March 20, 2017, 4:23 p.m. UTC | #1
On Mon, Mar 20, 2017 at 05:14:49PM +0100, Timothy Redaelli wrote:
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>

Thanks, applied to master and branch-2.7.

Do these scripts need to be marked executable?  If so, should we add a
command to do that?

Thanks,

Ben.
diff mbox

Patch

diff --git a/Documentation/howto/kvm.rst b/Documentation/howto/kvm.rst
index 4b43af3..29732a9 100644
--- a/Documentation/howto/kvm.rst
+++ b/Documentation/howto/kvm.rst
@@ -46,7 +46,7 @@  make use of example Open vSwitch bridges that we'll describe in this guide.
 
 Create the following two files and store them in known locations. For example::
 
-    echo << EOF > /etc/ovs-ifup
+    $ cat << 'EOF' > /etc/ovs-ifup
     #!/bin/sh
 
     switch='br0'
@@ -56,12 +56,13 @@  Create the following two files and store them in known locations. For example::
 
 ::
 
-    echo << EOF > /etc/ovs-ifdown
+    $ cat << 'EOF' > /etc/ovs-ifdown
     #!/bin/sh
 
     switch='br0'
     /sbin/ifconfig $1 0.0.0.0 down
     ovs-vsctl del-port ${switch} $1
+    EOF
 
 The basic usage of Open vSwitch is described at the end of
 :doc:`/intro/install/general`. If you haven't already, create a bridge named