Message ID | 6234560c5ec9637f9e68a270313701c6465f95bc.1620832088.git.tredaelli@redhat.com |
---|---|
State | Accepted |
Headers | show |
Series | [ovs-dev] rhel: use /run instead of /var/run | expand |
On Wed, May 12, 2021 at 05:08:08PM +0200, Timothy Redaelli wrote: > Systemd unit file generates warnings about PID file path since /var/run > is a legacy path so just use /run instead of /var/run. > > /var/run is a symlink of /run starting from RHEL7 (and any other distribution > that uses systemd). > > Reported-at: https://bugzilla.redhat.com/1952081 > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > --- Reproduced on F34: Jul 12 17:03:28 p50 systemd[1]: /usr/lib/systemd/system/ovs-vswitchd.service:12: PIDFile= references a path below legacy directory /var/run/, updating /var/run/openvswitch/ovs-vswitchd.pid → /run/openvswitch/ovs-vswitchd.pid; please update the unit file accordingly. Acked-by: Flavio Leitner <fbl@sysclose.org> Thanks Timothy, fbl
On 7/12/21 22:15, Flavio Leitner wrote: > On Wed, May 12, 2021 at 05:08:08PM +0200, Timothy Redaelli wrote: >> Systemd unit file generates warnings about PID file path since /var/run >> is a legacy path so just use /run instead of /var/run. >> >> /var/run is a symlink of /run starting from RHEL7 (and any other distribution >> that uses systemd). >> >> Reported-at: https://bugzilla.redhat.com/1952081 >> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> >> --- > > Reproduced on F34: > Jul 12 17:03:28 p50 systemd[1]: > /usr/lib/systemd/system/ovs-vswitchd.service:12: PIDFile= references > a path below legacy directory /var/run/, updating > /var/run/openvswitch/ovs-vswitchd.pid → > /run/openvswitch/ovs-vswitchd.pid; please update the unit file > accordingly. > > Acked-by: Flavio Leitner <fbl@sysclose.org> Sorry for delay. Applied. Thanks! Best regards, Ilya Maximets.
diff --git a/rhel/etc_logrotate.d_openvswitch b/rhel/etc_logrotate.d_openvswitch index f4302ffbc..c0f476744 100644 --- a/rhel/etc_logrotate.d_openvswitch +++ b/rhel/etc_logrotate.d_openvswitch @@ -13,8 +13,8 @@ missingok postrotate # Tell Open vSwitch daemons to reopen their log files - if [ -d /var/run/openvswitch ]; then - for ctl in /var/run/openvswitch/*.ctl; do + if [ -d /run/openvswitch ]; then + for ctl in /run/openvswitch/*.ctl; do ovs-appctl -t "$ctl" vlog/reopen 2>/dev/null || : done fi diff --git a/rhel/usr_lib_systemd_system_openvswitch-ipsec.service b/rhel/usr_lib_systemd_system_openvswitch-ipsec.service index d8f47af68..92dad44f9 100644 --- a/rhel/usr_lib_systemd_system_openvswitch-ipsec.service +++ b/rhel/usr_lib_systemd_system_openvswitch-ipsec.service @@ -5,7 +5,7 @@ After=openvswitch.service [Service] Type=forking -PIDFile=/var/run/openvswitch/ovs-monitor-ipsec.pid +PIDFile=/run/openvswitch/ovs-monitor-ipsec.pid ExecStart=/usr/share/openvswitch/scripts/ovs-ctl \ --ike-daemon=libreswan start-ovs-ipsec ExecStop=/usr/share/openvswitch/scripts/ovs-ctl stop-ovs-ipsec diff --git a/rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service b/rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service index 4cd4d7f57..d4d7b204b 100644 --- a/rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service +++ b/rhel/usr_lib_systemd_system_ovs-delete-transient-ports.service @@ -2,7 +2,7 @@ Description=Open vSwitch Delete Transient Ports After=ovsdb-server.service Before=ovs-vswitchd.service -AssertPathExists=/var/run/openvswitch/db.sock +AssertPathExists=/run/openvswitch/db.sock [Service] Type=oneshot diff --git a/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in b/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in index ff43dae96..6d021618b 100644 --- a/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in +++ b/rhel/usr_lib_systemd_system_ovs-vswitchd.service.in @@ -4,14 +4,14 @@ After=ovsdb-server.service network-pre.target systemd-udev-settle.service Before=network.target network.service Requires=ovsdb-server.service ReloadPropagatedFrom=ovsdb-server.service -AssertPathIsReadWrite=/var/run/openvswitch/db.sock +AssertPathIsReadWrite=/run/openvswitch/db.sock PartOf=openvswitch.service [Service] Type=forking -PIDFile=/var/run/openvswitch/ovs-vswitchd.pid +PIDFile=/run/openvswitch/ovs-vswitchd.pid Restart=on-failure -Environment=XDG_RUNTIME_DIR=/var/run/openvswitch +Environment=XDG_RUNTIME_DIR=/run/openvswitch EnvironmentFile=/etc/openvswitch/default.conf EnvironmentFile=-/etc/sysconfig/openvswitch EnvironmentFile=-/run/openvswitch.useropts diff --git a/rhel/usr_lib_systemd_system_ovsdb-server.service b/rhel/usr_lib_systemd_system_ovsdb-server.service index ed6419f31..558632320 100644 --- a/rhel/usr_lib_systemd_system_ovsdb-server.service +++ b/rhel/usr_lib_systemd_system_ovsdb-server.service @@ -7,7 +7,7 @@ PartOf=openvswitch.service [Service] Type=forking -PIDFile=/var/run/openvswitch/ovsdb-server.pid +PIDFile=/run/openvswitch/ovsdb-server.pid Restart=on-failure EnvironmentFile=/etc/openvswitch/default.conf EnvironmentFile=-/etc/sysconfig/openvswitch @@ -18,7 +18,7 @@ EnvironmentFile=-/run/openvswitch.useropts # OVS_USER_ID from default.conf or sysconfig. ExecStartPre=/usr/bin/rm -f /run/openvswitch.useropts -ExecStartPre=-/usr/bin/chown ${OVS_USER_ID} /var/run/openvswitch /var/log/openvswitch +ExecStartPre=-/usr/bin/chown ${OVS_USER_ID} /run/openvswitch /var/log/openvswitch ExecStartPre=/bin/sh -c '/usr/bin/echo "OVS_USER_ID=${OVS_USER_ID}" > /run/openvswitch.useropts' ExecStartPre=/bin/sh -c 'if [ "$${OVS_USER_ID/:*/}" != "root" ]; then /usr/bin/echo "OVS_USER_OPT=--ovs-user=${OVS_USER_ID}" >> /run/openvswitch.useropts; fi' ExecStart=/usr/share/openvswitch/scripts/ovs-ctl \
Systemd unit file generates warnings about PID file path since /var/run is a legacy path so just use /run instead of /var/run. /var/run is a symlink of /run starting from RHEL7 (and any other distribution that uses systemd). Reported-at: https://bugzilla.redhat.com/1952081 Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> --- rhel/etc_logrotate.d_openvswitch | 4 ++-- rhel/usr_lib_systemd_system_openvswitch-ipsec.service | 2 +- ...sr_lib_systemd_system_ovs-delete-transient-ports.service | 2 +- rhel/usr_lib_systemd_system_ovs-vswitchd.service.in | 6 +++--- rhel/usr_lib_systemd_system_ovsdb-server.service | 4 ++-- 5 files changed, 9 insertions(+), 9 deletions(-)