| Message ID | 61f86a6deff386a3828c94d6b4dcc3afba1ffa05.1705420069.git.echaudro@redhat.com |
|---|---|
| State | Accepted |
| Commit | bdf2f16771941569dfc591ab9cb013f427e450c4 |
| Headers | show |
| Series | [ovs-dev,v2] tests: Fix 'long flow dump duration' failures due to large time warp. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/intel-ovs-compilation | fail | test: fail |
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On 1/16/24 16:47, Eelco Chaudron wrote: > Large time warps can cause the 'long flow dump duration' log message > to happen. However, due to the level change, they could now cause > failures. This patch will stop these messages from failing the tests. > > Fixes: 9bcfb8fb7784 ("ofproto-dpif-upcall: Change flow dump duration message to WARN level.") > Signed-off-by: Eelco Chaudron <echaudro@redhat.com> > --- > > v2: Move exclusion to check_logs() > > tests/ofproto-macros.at | 4 ++++ > 1 file changed, 4 insertions(+) Thanks! I applied this one myself to speed up the process a little. Best regards, Ilya Maximets.
diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 5a7b7a6e7..acd1765b1 100644 --- a/tests/ofproto-macros.at +++ b/tests/ofproto-macros.at @@ -249,6 +249,9 @@ check_logs () { # we ignore the messages that were rate-limited, we can end up failing just # because of the announcement that rate-limiting happened (and in a racy, # timing-dependent way, too). + # + # We also ignore the "Spent an unreasonably long XXms dumping flows" as + # they can appear when large time/warps are used during tests. sed -n "$1 /reset by peer/d /Broken pipe/d @@ -261,6 +264,7 @@ check_logs () { /Dropped [[0-9]]* log messages/d /setting extended ack support failed/d /ETHTOOL_GSSET_INFO/d +/Spent an unreasonably long .*ms dumping flows/d /|WARN|/p /|ERR|/p /|EMER|/p" ${logs}
Large time warps can cause the 'long flow dump duration' log message to happen. However, due to the level change, they could now cause failures. This patch will stop these messages from failing the tests. Fixes: 9bcfb8fb7784 ("ofproto-dpif-upcall: Change flow dump duration message to WARN level.") Signed-off-by: Eelco Chaudron <echaudro@redhat.com> --- v2: Move exclusion to check_logs() tests/ofproto-macros.at | 4 ++++ 1 file changed, 4 insertions(+)