| Message ID | 5c0aa9f5fd67faeccead7ab1dcff00d56d433104.1611327007.git.tredaelli@redhat.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [ovs-dev] rhel: Update for DPDK 20.11 | expand |
On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > > With DPDK 20.11, meson and pkgconfig are used instead of the old > Makefile-based system and so --with-dpdk option is changed to only > accept shared or static instead of the directory. > > This commit uses --with-dpdk=shared since Fedora and RHEL ship shared > libraries of DPDK. > > Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.") > Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > --- > rhel/openvswitch-fedora.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in > index 2c0c4fa18..21929e6cf 100644 > --- a/rhel/openvswitch-fedora.spec.in > +++ b/rhel/openvswitch-fedora.spec.in > @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS tunnels. > --disable-libcapng \ > %endif > %if %{with dpdk} > - --with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \ > + --with-dpdk=shared \ one question, should we change the version of dpdk required: BuildRequires: dpdk-devel >= 17.05.1 --> 20.11 > %endif > --enable-ssl \ > --disable-static \ > -- > 2.29.2 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 1/25/21 2:34 PM, Tonghao Zhang wrote: > On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli <tredaelli@redhat.com> wrote: >> >> With DPDK 20.11, meson and pkgconfig are used instead of the old >> Makefile-based system and so --with-dpdk option is changed to only >> accept shared or static instead of the directory. >> >> This commit uses --with-dpdk=shared since Fedora and RHEL ship shared >> libraries of DPDK. >> >> Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.") >> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> Thanks! I updated the subject line to better reflect the change and applied to master and branch-2.15. >> --- >> rhel/openvswitch-fedora.spec.in | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in >> index 2c0c4fa18..21929e6cf 100644 >> --- a/rhel/openvswitch-fedora.spec.in >> +++ b/rhel/openvswitch-fedora.spec.in >> @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS tunnels. >> --disable-libcapng \ >> %endif >> %if %{with dpdk} >> - --with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \ >> + --with-dpdk=shared \ > one question, should we change the version of dpdk required: > BuildRequires: dpdk-devel >= 17.05.1 --> 20.11 Yes, we need that. Thanks for pointing out. Could one of you, please, prepare a patch with this change? Best regards, Ilya Maximets.
On Wed, Feb 3, 2021 at 1:25 AM Ilya Maximets <i.maximets@ovn.org> wrote: > > On 1/25/21 2:34 PM, Tonghao Zhang wrote: > > On Fri, Jan 22, 2021 at 10:50 PM Timothy Redaelli <tredaelli@redhat.com> wrote: > >> > >> With DPDK 20.11, meson and pkgconfig are used instead of the old > >> Makefile-based system and so --with-dpdk option is changed to only > >> accept shared or static instead of the directory. > >> > >> This commit uses --with-dpdk=shared since Fedora and RHEL ship shared > >> libraries of DPDK. > >> > >> Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.") > >> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> > > Thanks! > I updated the subject line to better reflect the change and > applied to master and branch-2.15. > > >> --- > >> rhel/openvswitch-fedora.spec.in | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in > >> index 2c0c4fa18..21929e6cf 100644 > >> --- a/rhel/openvswitch-fedora.spec.in > >> +++ b/rhel/openvswitch-fedora.spec.in > >> @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS tunnels. > >> --disable-libcapng \ > >> %endif > >> %if %{with dpdk} > >> - --with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \ > >> + --with-dpdk=shared \ > > one question, should we change the version of dpdk required: > > BuildRequires: dpdk-devel >= 17.05.1 --> 20.11 > > Yes, we need that. Thanks for pointing out. > > Could one of you, please, prepare a patch with this change? patch is sent, please review, thanks! http://patchwork.ozlabs.org/project/openvswitch/patch/20210203151049.67212-1-xiangxia.m.yue@gmail.com/ > Best regards, Ilya Maximets.
diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 2c0c4fa18..21929e6cf 100644 --- a/rhel/openvswitch-fedora.spec.in +++ b/rhel/openvswitch-fedora.spec.in @@ -162,7 +162,7 @@ This package provides IPsec tunneling support for OVS tunnels. --disable-libcapng \ %endif %if %{with dpdk} - --with-dpdk=$(dirname %{_datadir}/dpdk/*/.config) \ + --with-dpdk=shared \ %endif --enable-ssl \ --disable-static \
With DPDK 20.11, meson and pkgconfig are used instead of the old Makefile-based system and so --with-dpdk option is changed to only accept shared or static instead of the directory. This commit uses --with-dpdk=shared since Fedora and RHEL ship shared libraries of DPDK. Fixes: 252e1e576443 ("dpdk: Update to use DPDK v20.11.") Signed-off-by: Timothy Redaelli <tredaelli@redhat.com> --- rhel/openvswitch-fedora.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)