| Message ID | 57A47A62.20703@samsung.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Exactly same situation with gcc (GCC) 6.1.1 20160510 (Red Hat 6.1.1-2). On 05.08.2016 14:37, Ilya Maximets wrote: > There is one interesting bug: > > Test 2224 (ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS) constantly fails > with 'CFLAGS=-march=native'. All other tests works normally. > > Environment: > > * OVS current master: > commit d59831e9b08e ("bridge: No QoS configured is not an error") > * Red Hat Enterprise Linux Server release 7.2 (Maipo) > * Compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > * Intel(R) Xeon(R) CPU E5-2690 v3 > > Test scenario: > > 1. Checkout current master branch. > > 2. Configure OVS with default configuration: > > # ./boot.sh && ./configure && make > > 3. Check test #2224 > > # make check TESTSUITEFLAGS='2224' > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS ok > > 4. Clean up > > # make distclean > > 5. Configure OVS with '-march=native': > > # ./boot.sh && ./configure CFLAGS="-march=native" && make > > 6. Check test #2224 > > # make check TESTSUITEFLAGS='2224' > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED (ovn.at:3205) > > Test failed because of bad packet: > > ./ovn.at:3205: cat 1.packets | cut -c 53- > --- expout 2016-08-05 14:29:47.205360523 +0300 > +++ /ovs/tests/testsuite.dir/at-groups/2224/stdout 2016-08-05 14:29:47.215360172 +0300 > @@ -1 +1 @@ > -0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000638253633501020104ffffff > 0003040a00000136040a000001330400000e1000000000ff00000000 > +0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 00000000000000000000000000000000000000000000000000000000000000006382536335010236040a0000 > 010104ffffff0003040a000001330400000e1000000000ff00000000 > > Full log attached. > > Best regards, Ilya Maximets. >
Same situation on another environment: * Ubuntu 16.04 LTS * Compiler: gcc (Ubuntu 5.3.1-14ubuntu2.1) 5.3.1 20160413 * Intel(R) Core(TM) i7-3770 CPU Best regards, Ilya Maximets. On 05.08.2016 14:37, Ilya Maximets wrote: > There is one interesting bug: > > Test 2224 (ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS) constantly fails > with 'CFLAGS=-march=native'. All other tests works normally. > > Environment: > > * OVS current master: > commit d59831e9b08e ("bridge: No QoS configured is not an error") > * Red Hat Enterprise Linux Server release 7.2 (Maipo) > * Compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > * Intel(R) Xeon(R) CPU E5-2690 v3 > > Test scenario: > > 1. Checkout current master branch. > > 2. Configure OVS with default configuration: > > # ./boot.sh && ./configure && make > > 3. Check test #2224 > > # make check TESTSUITEFLAGS='2224' > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS ok > > 4. Clean up > > # make distclean > > 5. Configure OVS with '-march=native': > > # ./boot.sh && ./configure CFLAGS="-march=native" && make > > 6. Check test #2224 > > # make check TESTSUITEFLAGS='2224' > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED (ovn.at:3205) > > Test failed because of bad packet: > > ./ovn.at:3205: cat 1.packets | cut -c 53- > --- expout 2016-08-05 14:29:47.205360523 +0300 > +++ /ovs/tests/testsuite.dir/at-groups/2224/stdout 2016-08-05 14:29:47.215360172 +0300 > @@ -1 +1 @@ > -0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000638253633501020104ffffff > 0003040a00000136040a000001330400000e1000000000ff00000000 > +0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > 00000000000000000000000000000000000000000000000000000000000000006382536335010236040a0000 > 010104ffffff0003040a000001330400000e1000000000ff00000000 > > Full log attached. > > Best regards, Ilya Maximets. >
Wow, that is a very strange finding. I also see it on Fedora 23 with gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), 2/100 failures with default configuration, 100% failure rate with -march=native. Lance ----- Original Message ----- > From: "Ilya Maximets" <i.maximets@samsung.com> > To: "Numan Siddique" <nusiddiq@redhat.com>, "Ben Pfaff" <blp@ovn.org>, bugs@openvswitch.org > Cc: dev@openvswitch.org, "Ramu Ramamurthy" <ramu.ramamurthy@us.ibm.com>, "Dyasly Sergey" <s.dyasly@samsung.com> > Sent: Friday, August 5, 2016 9:21:33 AM > Subject: Re: [ovs-dev] [openvswitch 2.5.90] testsuite: 2224 failed > > Exactly same situation with gcc (GCC) 6.1.1 20160510 (Red Hat 6.1.1-2). > > On 05.08.2016 14:37, Ilya Maximets wrote: > > There is one interesting bug: > > > > Test 2224 (ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS) constantly fails > > with 'CFLAGS=-march=native'. All other tests works normally. > > > > Environment: > > > > * OVS current master: > > commit d59831e9b08e ("bridge: No QoS configured is not an error") > > * Red Hat Enterprise Linux Server release 7.2 (Maipo) > > * Compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > * Intel(R) Xeon(R) CPU E5-2690 v3 > > > > Test scenario: > > > > 1. Checkout current master branch. > > > > 2. Configure OVS with default configuration: > > > > # ./boot.sh && ./configure && make > > > > 3. Check test #2224 > > > > # make check TESTSUITEFLAGS='2224' > > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS ok > > > > 4. Clean up > > > > # make distclean > > > > 5. Configure OVS with '-march=native': > > > > # ./boot.sh && ./configure CFLAGS="-march=native" && make > > > > 6. Check test #2224 > > > > # make check TESTSUITEFLAGS='2224' > > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED > > (ovn.at:3205) > > > > Test failed because of bad packet: > > > > ./ovn.at:3205: cat 1.packets | cut -c 53- > > --- expout 2016-08-05 14:29:47.205360523 +0300 > > +++ /ovs/tests/testsuite.dir/at-groups/2224/stdout 2016-08-05 > > 14:29:47.215360172 +0300 > > @@ -1 +1 @@ > > -0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000638253633501020104ffffff > > 0003040a00000136040a000001330400000e1000000000ff00000000 > > +0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 > > f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 > > 00000000000000000000000000000000000000000000000000000000000000006382536335010236040a0000 > > 010104ffffff0003040a000001330400000e1000000000ff00000000 > > > > Full log attached. > > > > Best regards, Ilya Maximets. > > > _______________________________________________ > dev mailing list > dev@openvswitch.org > http://openvswitch.org/mailman/listinfo/dev >
I can reproduce this too With -march=native, if the CPU has CRC32 extensions we use a different hash function. I suspect the dhcp options are output on the packet in a different order because of this. Perhaps we should make the test agnostic of the order, or order the options on the DHCP packet. Thanks, Daniele 2016-08-05 11:41 GMT-07:00 Lance Richardson <lrichard@redhat.com>: > Wow, that is a very strange finding. > > I also see it on Fedora 23 with gcc (GCC) 5.3.1 20160406 (Red Hat 5.3.1-6), > 2/100 failures with default configuration, 100% failure rate with > -march=native. > > Lance > > ----- Original Message ----- > > From: "Ilya Maximets" <i.maximets@samsung.com> > > To: "Numan Siddique" <nusiddiq@redhat.com>, "Ben Pfaff" <blp@ovn.org>, > bugs@openvswitch.org > > Cc: dev@openvswitch.org, "Ramu Ramamurthy" <ramu.ramamurthy@us.ibm.com>, > "Dyasly Sergey" <s.dyasly@samsung.com> > > Sent: Friday, August 5, 2016 9:21:33 AM > > Subject: Re: [ovs-dev] [openvswitch 2.5.90] testsuite: 2224 failed > > > > Exactly same situation with gcc (GCC) 6.1.1 20160510 (Red Hat 6.1.1-2). > > > > On 05.08.2016 14:37, Ilya Maximets wrote: > > > There is one interesting bug: > > > > > > Test 2224 (ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS) constantly fails > > > with 'CFLAGS=-march=native'. All other tests works normally. > > > > > > Environment: > > > > > > * OVS current master: > > > commit d59831e9b08e ("bridge: No QoS configured is not an error") > > > * Red Hat Enterprise Linux Server release 7.2 (Maipo) > > > * Compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) > > > * Intel(R) Xeon(R) CPU E5-2690 v3 > > > > > > Test scenario: > > > > > > 1. Checkout current master branch. > > > > > > 2. Configure OVS with default configuration: > > > > > > # ./boot.sh && ./configure && make > > > > > > 3. Check test #2224 > > > > > > # make check TESTSUITEFLAGS='2224' > > > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS ok > > > > > > 4. Clean up > > > > > > # make distclean > > > > > > 5. Configure OVS with '-march=native': > > > > > > # ./boot.sh && ./configure CFLAGS="-march=native" && make > > > > > > 6. Check test #2224 > > > > > > # make check TESTSUITEFLAGS='2224' > > > 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED > > > (ovn.at:3205) > > > > > > Test failed because of bad packet: > > > > > > ./ovn.at:3205: cat 1.packets | cut -c 53- > > > --- expout 2016-08-05 14:29:47.205360523 +0300 > > > +++ /ovs/tests/testsuite.dir/at-groups/2224/stdout 2016-08-05 > > > 14:29:47.215360172 +0300 > > > @@ -1 +1 @@ > > > -0a0000010a00000400430044011c0000020106006359aa76000000000000 > 00000a0000040000000000000000 > > > f00000000001000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000638253633501020104ffffff > > > 0003040a00000136040a000001330400000e1000000000ff00000000 > > > +0a0000010a00000400430044011c0000020106006359aa76000000000000 > 00000a0000040000000000000000 > > > f00000000001000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 0000000000000000000000000000 > > > 000000000000000000000000000000000000000000000000000000000000 > 00006382536335010236040a0000 > > > 010104ffffff0003040a000001330400000e1000000000ff00000000 > > > > > > Full log attached. > > > > > > Best regards, Ilya Maximets. > > > > > _______________________________________________ > > dev mailing list > > dev@openvswitch.org > > http://openvswitch.org/mailman/listinfo/dev > > > _______________________________________________ > discuss mailing list > discuss@openvswitch.org > http://openvswitch.org/mailman/listinfo/discuss >
--- expout 2016-08-05 14:29:47.205360523 +0300 +++ /ovs/tests/testsuite.dir/at-groups/2224/stdout 2016-08-05 14:29:47.215360172 +0300 @@ -1 +1 @@ -0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000
There is one interesting bug: Test 2224 (ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS) constantly fails with 'CFLAGS=-march=native'. All other tests works normally. Environment: * OVS current master: commit d59831e9b08e ("bridge: No QoS configured is not an error") * Red Hat Enterprise Linux Server release 7.2 (Maipo) * Compiler: gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-4) * Intel(R) Xeon(R) CPU E5-2690 v3 Test scenario: 1. Checkout current master branch. 2. Configure OVS with default configuration: # ./boot.sh && ./configure && make 3. Check test #2224 # make check TESTSUITEFLAGS='2224' 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS ok 4. Clean up # make distclean 5. Configure OVS with '-march=native': # ./boot.sh && ./configure CFLAGS="-march=native" && make 6. Check test #2224 # make check TESTSUITEFLAGS='2224' 2224: ovn -- dhcpv4 : 1 HV, 2 LS, 2 LSPs/LS FAILED (ovn.at:3205) Test failed because of bad packet: ./ovn.at:3205: cat 1.packets | cut -c 53- 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000638253633501020104ffffff 0003040a00000136040a000001330400000e1000000000ff00000000 +0a0000010a00000400430044011c0000020106006359aa7600000000000000000a0000040000000000000000 f000000000010000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 00000000000000000000000000000000000000000000000000000000000000006382536335010236040a0000 010104ffffff0003040a000001330400000e1000000000ff00000000 Full log attached. Best regards, Ilya Maximets.