| Message ID | 2DC89DE0-8F2C-4053-9473-E78626BCAA96@vmware.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Unit tests are passing. I also gave it a test via the installer. Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > -----Original Message----- > From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > bounces@openvswitch.org] On Behalf Of Anand Kumar > Sent: Saturday, June 17, 2017 1:47 AM > To: Guru Shetty <guru@ovn.org> > Cc: ovs dev <dev@openvswitch.org> > Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from > service_start function > > Hi Guru, > > No, I didn’t run unit tests before. But I have verified manually, that ovsdb- > server and ovs-vswitchd daemons starts normally when run as a > service/console application. > > I have run the unit tests now, so far 1812 tests have executed and I didn’t > see any issues. But the test suite got hung at “1813: SSL db: implementation”, > so running it again. > > Thanks, > Anand Kumar > > From: Guru Shetty <guru@ovn.org> > Date: Friday, June 16, 2017 at 11:06 AM > To: Anand Kumar <kumaranand@vmware.com> > Cc: ovs dev <dev@openvswitch.org> > Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from > service_start function > > > > On 16 June 2017 at 10:06, Anand Kumar > <kumaranand@vmware.com<mailto:kumaranand@vmware.com>> wrote: > When --syslog-method is passed as a cmd line argument and ovs daemons > are started as a service, --syslog-method argument is not honoured, as vlog > module is initialized by service_start function before parsing the command > line arguments. > > Easy way to fix this, is to remove vlog_init() from the service start function > and let the first log message to initialize the vlog module. > > Signed-off-by: Anand Kumar > <kumaranand@vmware.com<mailto:kumaranand@vmware.com>>
Alin, Thanks for looking into this! Acked-by: Sairam Venugopal <vsairam@vmware.com> On 6/20/17, 12:14 PM, "ovs-dev-bounces@openvswitch.org on behalf of Alin Serdean" <ovs-dev-bounces@openvswitch.org on behalf of aserdean@cloudbasesolutions.com> wrote: >Unit tests are passing. > > > >I also gave it a test via the installer. > > > >Acked-by: Alin Gabriel Serdean <aserdean@cloudbasesolutions.com> > > > > > >> -----Original Message----- > >> From: ovs-dev-bounces@openvswitch.org [mailto:ovs-dev- > >> bounces@openvswitch.org] On Behalf Of Anand Kumar > >> Sent: Saturday, June 17, 2017 1:47 AM > >> To: Guru Shetty <guru@ovn.org> > >> Cc: ovs dev <dev@openvswitch.org> > >> Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from > >> service_start function > >> > >> Hi Guru, > >> > >> No, I didn’t run unit tests before. But I have verified manually, that ovsdb- > >> server and ovs-vswitchd daemons starts normally when run as a > >> service/console application. > >> > >> I have run the unit tests now, so far 1812 tests have executed and I didn’t > >> see any issues. But the test suite got hung at “1813: SSL db: implementation”, > >> so running it again. > >> > >> Thanks, > >> Anand Kumar > >> > >> From: Guru Shetty <guru@ovn.org> > >> Date: Friday, June 16, 2017 at 11:06 AM > >> To: Anand Kumar <kumaranand@vmware.com> > >> Cc: ovs dev <dev@openvswitch.org> > >> Subject: Re: [ovs-dev] [PATCH] windows: Remove vlog_init() from > >> service_start function > >> > >> > >> > >> On 16 June 2017 at 10:06, Anand Kumar > >> <kumaranand@vmware.com<mailto:kumaranand@vmware.com>> wrote: > >> When --syslog-method is passed as a cmd line argument and ovs daemons > >> are started as a service, --syslog-method argument is not honoured, as vlog > >> module is initialized by service_start function before parsing the command > >> line arguments. > >> > >> Easy way to fix this, is to remove vlog_init() from the service start function > >> and let the first log message to initialize the vlog module. > >> > >> Signed-off-by: Anand Kumar > >> <kumaranand@vmware.com<mailto:kumaranand@vmware.com>> > > > >_______________________________________________ >dev mailing list >dev@openvswitch.org >https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.openvswitch.org_mailman_listinfo_ovs-2Ddev&d=DwIGaQ&c=uilaK90D4TOVoH58JNXRgQ&r=Z6vowHUOjP5ysP_g372c49Nqc1vEKqHKNBkR5Q5Z7uo&m=6PSoRMb2_Za8AiSS_bUShxGINRprA-Pjd8OWtXSFNC0&s=F7JVaof-epz2VayD_XtQ5jsyf3SNYodbNoiAw2ZTMbg&e=
diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c index 5804284..1ba714d 100644 --- a/lib/daemon-windows.c +++ b/lib/daemon-windows.c @@ -138,13 +138,6 @@ service_start(int *argcp, char **argvp[]) *argcp = sargc; *argvp = *sargvp; - /* XXX: Windows implementation cannot have a unixctl commands in the - * traditional sense of unix domain sockets. If an implementation is - * done that involves 'unixctl' vlog commands the following call is - * needed to make sure that the unixctl commands for vlog get - * registered in a daemon, even before the first log message. */ - vlog_init(); - return; }