| Message ID | 20240520-axfxdp-config-have-ebpf-jit-v1-1-97f4c9e5de44@ovn.org |
|---|---|
| State | Under Review |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | docs: afxdp: Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | warning | apply and check: warning |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
Bleep bloop. Greetings 'Simon Horman', I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Simon Horman <horms@ovn.org> Lines checked: 31, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email aconole@redhat.com Thanks, 0-day Robot
On 20 May 2024, at 20:13, Simon Horman wrote: > From: Ville Skyttä <ville.skytta@upcloud.com> > > Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). > > Signed-off-by: Ville Skyttä <ville.skytta@upcloud.com> > [simon: added commit meesage] I guess this line was a leftover of your merge/tooling? The rest looks good. Acked-by: Eelco Chaudron <echaudro@redhat.com> > Signed-off-by: Simon Horman <horms@ovn.org> > --- > Documentation/intro/install/afxdp.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/intro/install/afxdp.rst b/Documentation/intro/install/afxdp.rst > index 964d9ef5b1d0..7fa8088c6eeb 100644 > --- a/Documentation/intro/install/afxdp.rst > +++ b/Documentation/intro/install/afxdp.rst > @@ -103,7 +103,7 @@ vSwitch with AF_XDP will require the following: > > * CONFIG_BPF_JIT=y (Performance) > > - * CONFIG_HAVE_BPF_JIT=y (Performance) > + * CONFIG_HAVE_EBPF_JIT=y (Performance) > > * CONFIG_XDP_SOCKETS_DIAG=y (Debugging) > > > -- > 2.43.0 > > _______________________________________________ > dev mailing list > dev@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: > > > On 20 May 2024, at 20:13, Simon Horman wrote: > > > From: Ville Skyttä <ville.skytta@upcloud.com> > > > > Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). > > > > Signed-off-by: Ville Skyttä <ville.skytta@upcloud.com> > > [simon: added commit meesage] > > I guess this line was a leftover of your merge/tooling? It was intentional, but I can drop it. > > The rest looks good. > > Acked-by: Eelco Chaudron <echaudro@redhat.com> Thanks
On 21 May 2024, at 17:47, Simon Horman wrote: > On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: >> >> >> On 20 May 2024, at 20:13, Simon Horman wrote: >> >>> From: Ville Skyttä <ville.skytta@upcloud.com> >>> >>> Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). >>> >>> Signed-off-by: Ville Skyttä <ville.skytta@upcloud.com> >>> [simon: added commit meesage] >> >> I guess this line was a leftover of your merge/tooling? > > It was intentional, but I can drop it. It looked odd, maybe this is more a remark for the -- section, i.e. not part of the actual commit message? >> >> The rest looks good. >> >> Acked-by: Eelco Chaudron <echaudro@redhat.com> > > Thanks
On 5/22/24 14:47, Eelco Chaudron wrote: > > > On 21 May 2024, at 17:47, Simon Horman wrote: > >> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: >>> >>> >>> On 20 May 2024, at 20:13, Simon Horman wrote: >>> >>>> From: Ville Skyttä <ville.skytta@upcloud.com> >>>> >>>> Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). >>>> >>>> Signed-off-by: Ville Skyttä <ville.skytta@upcloud.com> >>>> [simon: added commit meesage] >>> >>> I guess this line was a leftover of your merge/tooling? >> >> It was intentional, but I can drop it. > > It looked odd, maybe this is more a remark for the -- section, i.e. not part of the actual commit message? It's a normal practice to add such remarks to the commit message when committer made some noticeable changes to the original patch, or if they want to clarify something that wasn't fully explained by the original commit message. I add those sometimes as well. Best regards, Ilya Maximets.
On 28 May 2024, at 17:44, Ilya Maximets wrote: > On 5/22/24 14:47, Eelco Chaudron wrote: >> >> >> On 21 May 2024, at 17:47, Simon Horman wrote: >> >>> On Tue, May 21, 2024 at 08:35:21AM +0200, Eelco Chaudron wrote: >>>> >>>> >>>> On 20 May 2024, at 20:13, Simon Horman wrote: >>>> >>>>> From: Ville Skyttä <ville.skytta@upcloud.com> >>>>> >>>>> Fix CONFIG_HAVE_EBPF_JIT Kconfig option spelling "EBPF" vs "BPF"). >>>>> >>>>> Signed-off-by: Ville Skyttä <ville.skytta@upcloud.com> >>>>> [simon: added commit meesage] >>>> >>>> I guess this line was a leftover of your merge/tooling? >>> >>> It was intentional, but I can drop it. >> >> It looked odd, maybe this is more a remark for the -- section, i.e. not part of the actual commit message? > > It's a normal practice to add such remarks to the commit message > when committer made some noticeable changes to the original patch, > or if they want to clarify something that wasn't fully explained > by the original commit message. I add those sometimes as well. Ack, learned something today ;) //Eelco
diff --git a/Documentation/intro/install/afxdp.rst b/Documentation/intro/install/afxdp.rst index 964d9ef5b1d0..7fa8088c6eeb 100644 --- a/Documentation/intro/install/afxdp.rst +++ b/Documentation/intro/install/afxdp.rst @@ -103,7 +103,7 @@ vSwitch with AF_XDP will require the following: * CONFIG_BPF_JIT=y (Performance) - * CONFIG_HAVE_BPF_JIT=y (Performance) + * CONFIG_HAVE_EBPF_JIT=y (Performance) * CONFIG_XDP_SOCKETS_DIAG=y (Debugging)