diff mbox series

[ovs-dev,2/2] ovsdb: raft: Fix probe intervals after install snapshot request.

Message ID 20240411234504.2913083-3-i.maximets@ovn.org
State Accepted
Commit bcacd805fefa776d4943190d5b1c19238b3dcf75
Delegated to: Ilya Maximets
Headers show
Series ovsdb: raft: Fixes for probe interval updates. | expand

Checks

Context Check Description
ovsrobot/apply-robot success apply and check: success
ovsrobot/github-robot-_Build_and_Test success github build: passed
ovsrobot/intel-ovs-compilation success test: success

Commit Message

Ilya Maximets April 11, 2024, 11:45 p.m. UTC
If the new snapshot received with INSTALL_SNAPSHOT request contains
a different election timer value, the timer is updated, but the
probe intervals for RAFT connections are not.

Fix that by updating probe intervals whenever we get election timer
from the log.

Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
---
 ovsdb/raft.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Mike Pattrick April 17, 2024, 6:39 p.m. UTC | #1
On Thu, Apr 11, 2024 at 7:45 PM Ilya Maximets <i.maximets@ovn.org> wrote:
>
> If the new snapshot received with INSTALL_SNAPSHOT request contains
> a different election timer value, the timer is updated, but the
> probe intervals for RAFT connections are not.
>
> Fix that by updating probe intervals whenever we get election timer
> from the log.
>
> Fixes: 14b2b0aad7ae ("raft: Reintroduce jsonrpc inactivity probes.")
> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>

Acked-by: Mike Pattrick <mkp@redhat.com>
diff mbox series

Patch

diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 083ebf66a..ac3d37ac4 100644
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -5035,6 +5035,7 @@  raft_get_election_timer_from_log(struct raft *raft)
             break;
         }
     }
+    raft_update_probe_intervals(raft);
 }
 
 static void