| Message ID | 20240309183458.3014713-3-kuba@kernel.org |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | None | expand |
On Sat, Mar 09, 2024 at 10:34:57AM -0800, Jakub Kicinski wrote: > The only legit reason I could think of for net/genetlink.h > and linux/genetlink.h to be separate would be if one was > included by other headers and we wanted to keep it lightweight. > That is not the case, net/openvswitch/meter.h includes > linux/genetlink.h but for no apparent reason (for struct genl_family > perhaps? it's not necessary, types of externs do not need > to be known). > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/openvswitch/meter.h b/net/openvswitch/meter.h index ed11cd12b512..8bbf983cd244 100644 --- a/net/openvswitch/meter.h +++ b/net/openvswitch/meter.h @@ -11,7 +11,6 @@ #include <linux/kernel.h> #include <linux/netlink.h> #include <linux/openvswitch.h> -#include <linux/genetlink.h> #include <linux/skbuff.h> #include <linux/bits.h>
The only legit reason I could think of for net/genetlink.h and linux/genetlink.h to be separate would be if one was included by other headers and we wanted to keep it lightweight. That is not the case, net/openvswitch/meter.h includes linux/genetlink.h but for no apparent reason (for struct genl_family perhaps? it's not necessary, types of externs do not need to be known). Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: pshelar@ovn.org CC: dev@openvswitch.org --- net/openvswitch/meter.h | 1 - 1 file changed, 1 deletion(-)