| Message ID | 20240301-dei-t1-v2-1-10ee89c17b89@ovn.org |
|---|---|
| State | Accepted |
| Delegated to: | Simon Horman |
| Headers | show |
| Series | DEI: Address some instances of master and slave | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 1 Mar 2024, at 15:50, Simon Horman wrote: > Since the patch-set that included [1] there has been a policy of using > the term member for bonds, LACP, and bundle contexts. This is > consistent with the more recently adopted policy of using the inclusive > naming word list v1 [2, 3]. > > This patch addresses two instances where the term member should be used > in vswitch.xml. It does not address instances of alternative wording > that require code updates, which can addressed as follow-up activity. > > [1] 91fc374a9c5a ("Eliminate use of term "slave" in bond, LACP, and bundle contexts.") > [2] df5e5cf4318a ("Documentation: Add section on inclusive language.") > [3] https://inclusivenaming.org/word-lists/ > > Signed-off-by: Simon Horman <horms@ovn.org> Thanks for fixing these. Changes look good to me. Acked-by: Eelco Chaudron <echaudro@redhat.com> //Eelco
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 612ba41e3b24..8a1b607d71b9 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2159,7 +2159,7 @@ <column name="other_config" key="bond-primary" type='{"type": "string"}'> - If a slave interface with this name exists in the bond and + If a member interface with this name exists in the bond and is up, it will be made active. Relevant only when <ref column="other_config" key="bond_mode"/> is <code>active-backup</code> or if <code>balance-tcp</code> falls back @@ -6291,7 +6291,7 @@ ovs-vsctl add-port br0 p0 -- set Interface p0 type=patch options:peer=p1 \ and avoids recirculation of packet in datapath. It is supported only for balance-tcp bond mode in netdev datapath. The new action gives higher performance by using bond buckets instead of post - recirculation flows for selection of slave port from bond. By default + recirculation flows for selection of member port from bond. By default this new action is disabled, however it can be enabled by setting <ref column="other-config" key="lb-output-action"/> in <ref table="Port"/> table.
Since the patch-set that included [1] there has been a policy of using the term member for bonds, LACP, and bundle contexts. This is consistent with the more recently adopted policy of using the inclusive naming word list v1 [2, 3]. This patch addresses two instances where the term member should be used in vswitch.xml. It does not address instances of alternative wording that require code updates, which can addressed as follow-up activity. [1] 91fc374a9c5a ("Eliminate use of term "slave" in bond, LACP, and bundle contexts.") [2] df5e5cf4318a ("Documentation: Add section on inclusive language.") [3] https://inclusivenaming.org/word-lists/ Signed-off-by: Simon Horman <horms@ovn.org> --- vswitchd/vswitch.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)