| Message ID | 20240129223403.5300-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 6bdca15791ce53e15101c436d8524f2944336031 |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] github: Bump Fedora version to 39. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | success | test: success |
On 29 Jan 2024, at 23:33, Ilya Maximets wrote: > Fedora 37 reached EOL in November. Switch to the most recent version > to avoid potential CI failures in the future. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Thanks for looking forward! The change looks fine to me, only tested on the master branch. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On 29.01.24 23:33, Ilya Maximets wrote: > Fedora 37 reached EOL in November. Switch to the most recent version > to avoid potential CI failures in the future. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > --- > .github/workflows/build-and-test.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml > index ddb425580..fc7558148 100644 > --- a/.github/workflows/build-and-test.yml > +++ b/.github/workflows/build-and-test.yml > @@ -462,7 +462,7 @@ jobs: > build-linux-rpm: > name: linux rpm fedora > runs-on: ubuntu-latest > - container: fedora:37 > + container: fedora:39 > timeout-minutes: 30 > > strategy: Why not fedora:rawhide? We will not have to update this line anymore and we will catch breaking changes early, like the GCC14 issue. I assume there has been a discussion previously, but I cannot find it in my archives (which is not old)...
On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote: > Fedora 37 reached EOL in November. Switch to the most recent version > to avoid potential CI failures in the future. > > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Acked-by: Simon Horman <horms@ovn.org>
On 1/30/24 09:54, Jakob Meng wrote: > On 29.01.24 23:33, Ilya Maximets wrote: >> Fedora 37 reached EOL in November. Switch to the most recent version >> to avoid potential CI failures in the future. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> >> --- >> .github/workflows/build-and-test.yml | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml >> index ddb425580..fc7558148 100644 >> --- a/.github/workflows/build-and-test.yml >> +++ b/.github/workflows/build-and-test.yml >> @@ -462,7 +462,7 @@ jobs: >> build-linux-rpm: >> name: linux rpm fedora >> runs-on: ubuntu-latest >> - container: fedora:37 >> + container: fedora:39 >> timeout-minutes: 30 >> >> strategy: > > Why not fedora:rawhide? > > We will not have to update this line anymore and we will catch breaking changes early, like the GCC14 issue. > > I assume there has been a discussion previously, but I cannot find it in my archives (which is not old)... The reason is that we don't want our CI to break whenever rawhide breaks. It is unstable, so it will break. We're not testing Fedora, we're testing OVS, so we need a stable environment to test with. If we use rawhide, whenever it breaks we can't merge anything into OVS until the build is fixed. That can be very inconvenient. Best regards, Ilya Maximets.
On 1/30/24 10:55, Simon Horman wrote: > On Mon, Jan 29, 2024 at 11:33:56PM +0100, Ilya Maximets wrote: >> Fedora 37 reached EOL in November. Switch to the most recent version >> to avoid potential CI failures in the future. >> >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Acked-by: Simon Horman <horms@ovn.org> > Thanks, Simon and Eelco! Applied to branches down to 3.2. We do not have fedora builds in CI in older branches. Best regards, Ilya Maximets.
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml index ddb425580..fc7558148 100644 --- a/.github/workflows/build-and-test.yml +++ b/.github/workflows/build-and-test.yml @@ -462,7 +462,7 @@ jobs: build-linux-rpm: name: linux rpm fedora runs-on: ubuntu-latest - container: fedora:37 + container: fedora:39 timeout-minutes: 30 strategy:
Fedora 37 reached EOL in November. Switch to the most recent version to avoid potential CI failures in the future. Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- .github/workflows/build-and-test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)