| Message ID | 20240118192525.3406231-1-i.maximets@ovn.org |
|---|---|
| State | Accepted |
| Commit | 9ca8d3a4d47901aa836a514501e429ccd7c370d5 |
| Delegated to: | Ilya Maximets |
| Headers | show |
| Series | [ovs-dev] tests: mcast-snooping: Stop time for the group protocol test. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
On 18 Jan 2024, at 20:25, Ilya Maximets wrote: > Otherwise, it randomly fails due to age not being zero under load: > > tests/mcast-snooping.at:645: ovs-appctl mdb/show br0 > --- - Thanks for finding and fixing this. Tests pass fine in my not too busy system. Acked-by: Eelco Chaudron <echaudro@redhat.com>
On Thu, Jan 18, 2024 at 08:25:23PM +0100, Ilya Maximets wrote: > Otherwise, it randomly fails due to age not being zero under load: > > tests/mcast-snooping.at:645: ovs-appctl mdb/show br0 > --- - > +++ /at-groups/2592/stdout > @@ -1,5 +1,5 @@ > port VLAN protocol GROUP Age > - 1 0 IGMPv1 224.1.1.1 0 > + 1 0 IGMPv1 224.1.1.1 1 > 1 0 IGMPv2 224.1.1.2 0 > 1 0 IGMPv3 233.54.12.230 0 > > Fixes: b222593bc69b ("mcast-snooping: Add group protocol to mdb/show output.") > Signed-off-by: Ilya Maximets <i.maximets@ovn.org> Thanks. On my otherwise idle system, I ran the test updated by this patch in a loop. Without this patch, it failed on the 55th iteration. With this patch it successfully ran 1000 iterations (the target for my experiment). Not being very scientific, I did not try this experiment a second time. Acked-by: Simon Horman <horms@ovn.org>
On 1/19/24 10:18, Simon Horman wrote: > On Thu, Jan 18, 2024 at 08:25:23PM +0100, Ilya Maximets wrote: >> Otherwise, it randomly fails due to age not being zero under load: >> >> tests/mcast-snooping.at:645: ovs-appctl mdb/show br0 >> --- - >> +++ /at-groups/2592/stdout >> @@ -1,5 +1,5 @@ >> port VLAN protocol GROUP Age >> - 1 0 IGMPv1 224.1.1.1 0 >> + 1 0 IGMPv1 224.1.1.1 1 >> 1 0 IGMPv2 224.1.1.2 0 >> 1 0 IGMPv3 233.54.12.230 0 >> >> Fixes: b222593bc69b ("mcast-snooping: Add group protocol to mdb/show output.") >> Signed-off-by: Ilya Maximets <i.maximets@ovn.org> > > Thanks. > > On my otherwise idle system, I ran the test updated by this patch > in a loop. > > Without this patch, it failed on the 55th iteration. > With this patch it successfully ran 1000 iterations > (the target for my experiment). > > Not being very scientific, I did not try this experiment a second time. > > Acked-by: Simon Horman <horms@ovn.org> > Thanks, Simon and Eelco! Applied and backported to branch-3.3. Best regards, Ilya Maximets.
diff --git a/tests/mcast-snooping.at b/tests/mcast-snooping.at index a91b3e13a..adbb66c70 100644 --- a/tests/mcast-snooping.at +++ b/tests/mcast-snooping.at @@ -622,6 +622,8 @@ AT_CHECK([ other-config:hwaddr=aa:55:aa:55:00:01 ofport_request=1 \ ], [0]) +AT_CHECK([ovs-appctl time/stop]) + # Send IGMPv1 report packet. AT_CHECK([ ovs-appctl netdev-dummy/receive p1 \
Otherwise, it randomly fails due to age not being zero under load: tests/mcast-snooping.at:645: ovs-appctl mdb/show br0 --- - +++ /at-groups/2592/stdout @@ -1,5 +1,5 @@ port VLAN protocol GROUP Age - 1 0 IGMPv1 224.1.1.1 0 + 1 0 IGMPv1 224.1.1.1 1 1 0 IGMPv2 224.1.1.2 0 1 0 IGMPv3 233.54.12.230 0 Fixes: b222593bc69b ("mcast-snooping: Add group protocol to mdb/show output.") Signed-off-by: Ilya Maximets <i.maximets@ovn.org> --- tests/mcast-snooping.at | 2 ++ 1 file changed, 2 insertions(+)