diff mbox series

[ovs-dev,v6,6/6] appctl: Add tests for unsupported output formats.

Message ID 20240118095742.731853-7-jmeng@redhat.com
State Superseded, archived
Headers show
Series Add global option to output JSON from ovs-appctl cmds. | expand

Checks

Context Check Description
ovsrobot/apply-robot warning apply and check: warning

Commit Message

Jakob Meng Jan. 18, 2024, 9:57 a.m. UTC 
From: Jakob Meng <code@jakobmeng.de>

Signed-off-by: Jakob Meng <code@jakobmeng.de>
---
 tests/pmd.at        | 5 +++++
 tests/unixctl-py.at | 7 +++++++
 2 files changed, 12 insertions(+)

Comments

0-day Robot Jan. 18, 2024, 10:18 a.m. UTC | #1 
Bleep bloop.  Greetings Jakob Meng, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


Patch skipped due to previous failure.

Please check this out.  If you feel there has been an error, please email aconole@redhat.com

Thanks,
0-day Robot
diff mbox series

Patch

diff --git a/tests/pmd.at b/tests/pmd.at
index cff80da15..82a514f36 100644
--- a/tests/pmd.at
+++ b/tests/pmd.at
@@ -105,6 +105,11 @@  pmd thread numa_id <cleared> core_id <cleared>:
   overhead: NOT AVAIL
 ])
 
+AT_CHECK([ovs-appctl --format json dpif-netdev/pmd-rxq-show], [2], [], [dnl
+"dpif-netdev/pmd-rxq-show" command does not support output format "json" (supported: 1, requested: 2)
+ovs-appctl: ovs-vswitchd: server returned an error
+])
+
 AT_CHECK([ovs-appctl dpif/show], [0], [dnl
 dummy@ovs-dummy: hit:0 missed:0
   br0:
diff --git a/tests/unixctl-py.at b/tests/unixctl-py.at
index 26c137047..eeea386c7 100644
--- a/tests/unixctl-py.at
+++ b/tests/unixctl-py.at
@@ -65,6 +65,13 @@  AT_CHECK([head -1 stderr], [0], [dnl
 sed 's/ovs-appctl/appctl.py/' stderr > experr
 AT_CHECK([PYAPPCTL_PY bond/hash mac vlan basis extra], [2], [], [experr])
 
+AT_CHECK([APPCTL --format json dpif-netdev/pmd-rxq-show], [2], [], [stderr])
+AT_CHECK([head -1 stderr], [0], [dnl
+"dpif-netdev/pmd-rxq-show" command does not support output format "json" (supported: 1, requested: 2)
+])
+sed 's/ovs-appctl/appctl.py/' stderr > experr
+AT_CHECK([PYAPPCTL_PY --format json dpif-netdev/pmd-rxq-show], [2], [], [experr])
+
 OVS_VSWITCHD_STOP
 AT_CLEANUP