Message ID | 20231118010055.4143239-3-ihrachys@redhat.com |
---|---|
State | Superseded, archived |
Headers | show
Return-Path: <ovs-dev-bounces@openvswitch.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cleKwNYc; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org; envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4SXFp82v2Jz1ySF for <incoming@patchwork.ozlabs.org>; Sat, 18 Nov 2023 12:01:20 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 9D00D421D0; Sat, 18 Nov 2023 01:01:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9D00D421D0 Authentication-Results: smtp4.osuosl.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cleKwNYc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MXpSpR5_OMUQ; Sat, 18 Nov 2023 01:01:14 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id 0567F41FDB; Sat, 18 Nov 2023 01:01:13 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0567F41FDB Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 03579C0DDA; Sat, 18 Nov 2023 01:01:11 +0000 (UTC) X-Original-To: dev@openvswitch.org Delivered-To: ovs-dev@lists.linuxfoundation.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 335C7C0DDA for <dev@openvswitch.org>; Sat, 18 Nov 2023 01:01:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 051ED60BA8 for <dev@openvswitch.org>; Sat, 18 Nov 2023 01:01:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 051ED60BA8 Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cleKwNYc X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I4KqnQDaBMRI for <dev@openvswitch.org>; Sat, 18 Nov 2023 01:01:09 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 5B6F860BA7 for <dev@openvswitch.org>; Sat, 18 Nov 2023 01:01:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5B6F860BA7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700269268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7Ljz/OX0E7i8Sl0hVEJdXXKeGaZC+gf8QOY6eXQdLI=; b=cleKwNYcTk6DOZSM3AXKhqQSmcbvCBrtZp8qGKj9kuOZCiHHMCKlASJIvx0HuQUeeWK6J8 FGfm3osS9ES6P3n4P05kYFGVwPITx/irSiHtzMMOFmyJ7aOXwJwLR7zNF9AVKCCG6JGb7T yMaWDMOwPOx7juaWD2WCfdmpyEsrVuc= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-CezDb94JMtynVgt3ETU-Aw-1; Fri, 17 Nov 2023 20:01:06 -0500 X-MC-Unique: CezDb94JMtynVgt3ETU-Aw-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-778a65923bdso313248885a.3 for <dev@openvswitch.org>; Fri, 17 Nov 2023 17:01:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700269265; x=1700874065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F7Ljz/OX0E7i8Sl0hVEJdXXKeGaZC+gf8QOY6eXQdLI=; b=MvFGnX1HT4wV6Jgp1ZvBl/ZjF3A+cXdqjXXexbqdj9AnTAhmpzvJGt3nsOAxzhGPFi +nkbMTcjjaymbOCkV4DXWYNIxk9S0wZNcw1MdXY4X04jKn/pKiY3+wx1NTk7i8bghuGy OaRGxpB8HiKqZ4txRuVevpH0t5SeM8kArcXk6Ufoezb2Fk210T1aQ0I87rJghJ+wZoVe mblTQAViYC7htYP0IR8Cvq4I3/CMyFOv+wu/cU3I9TMxg8+2FBJbh8KWiADRHx6HDuvn sGZkEA9mhrQtYVr4hupRwlg/ZwfdQI8I0B2R+cvFcWv7SqkKccTXOEGRTIS11L8Zvw3g 7gXg== X-Gm-Message-State: AOJu0Yw5ldIBcTqT8t3Qd+UUm2zj3eYDWu2SKrwJ9FyKqB0noGFRdNO6 IyXteYrc5IfM3KBPU5oAhZaJOJNYuLsL9Ne1BkmtiVHWacEPtOXLpb+HEJhUqw+4aYefT8GMJX6 afcSP6mtLCdNSWWWHk33nvv5e4rOTIOZwE9f0uVRE42PFc+lNJJrHVinKwyqYagJ0OrWtOfFn X-Received: by 2002:a05:620a:55a5:b0:77b:cea0:51a2 with SMTP id vr5-20020a05620a55a500b0077bcea051a2mr1339595qkn.33.1700269265437; Fri, 17 Nov 2023 17:01:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IExlKay1sm9mIsijRtO5h/vQlVjwNA4ZcYJYFBCQgIOmAEKqWYkm5nTdb7OtLj6ifa3a1GMyQ== X-Received: by 2002:a05:620a:55a5:b0:77b:cea0:51a2 with SMTP id vr5-20020a05620a55a500b0077bcea051a2mr1339579qkn.33.1700269265164; Fri, 17 Nov 2023 17:01:05 -0800 (PST) Received: from fedora38.localdomain.com (cpe-172-73-180-250.carolina.res.rr.com. [172.73.180.250]) by smtp.gmail.com with ESMTPSA id sn1-20020a05620a948100b00770f2a690a8sm1005577qkn.53.2023.11.17.17.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 17:01:02 -0800 (PST) From: Ihar Hrachyshka <ihrachys@redhat.com> To: dev@openvswitch.org Date: Sat, 18 Nov 2023 01:00:52 +0000 Message-ID: <20231118010055.4143239-3-ihrachys@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231118010055.4143239-1-ihrachys@redhat.com> References: <20231118010055.4143239-1-ihrachys@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [ovs-dev] [PATCH 2/4] Don't convert EAGAIN to EPROTO for unix sockets X-BeenThere: ovs-dev@openvswitch.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: <ovs-dev.openvswitch.org> List-Unsubscribe: <https://mail.openvswitch.org/mailman/options/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=unsubscribe> List-Archive: <http://mail.openvswitch.org/pipermail/ovs-dev/> List-Post: <mailto:ovs-dev@openvswitch.org> List-Help: <mailto:ovs-dev-request@openvswitch.org?subject=help> List-Subscribe: <https://mail.openvswitch.org/mailman/listinfo/ovs-dev>, <mailto:ovs-dev-request@openvswitch.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ovs-dev-bounces@openvswitch.org Sender: "dev" <ovs-dev-bounces@openvswitch.org> |
Series |
Improve unixctl AF_UNIX backlog handling
|
expand
|
Context | Check | Description |
---|---|---|
ovsrobot/apply-robot | warning | apply and check: warning |
ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
ovsrobot/intel-ovs-compilation | success | test: success |
diff --git a/lib/socket-util-unix.c b/lib/socket-util-unix.c index 59f63fcce..0053a61b1 100644 --- a/lib/socket-util-unix.c +++ b/lib/socket-util-unix.c @@ -376,9 +376,6 @@ make_unix_socket(int style, bool nonblock, return fd; error: - if (error == EAGAIN) { - error = EPROTO; - } if (bind_path) { fatal_signal_unlink_file_now(bind_path); }
Unix sockets also have listener backlog. Returning EAGAIN is valid to allow the caller handle the non-blocking temporary failure to connect() gracefully. Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com> --- lib/socket-util-unix.c | 3 --- 1 file changed, 3 deletions(-)