| Message ID | 20230823153419.241641-7-david.marchand@redhat.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [ovs-dev,v2,1/7] system-dpdk: Introduce helpers for testpmd. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
| ovsrobot/intel-ovs-compilation | fail | test: fail |
On 23 Aug 2023, at 17:34, David Marchand wrote: > As reported by Ales, net/tap has broken support for checksum offloading. > Fixes have been sent to the DPDK side, but waiting for the fixes, simply > disable all conntrack related tests and some IPv6 tunnel tests. > > Signed-off-by: David Marchand <david.marchand@redhat.com> I think we should make this series dependent on “netdev-dpdk: Disable net/tap Tx L4 checksum offloads.”, so this patch can be removed from the series. Tested this series with the patch applied and all tests are passing even with ASAN, UBSAN enabled. Cheers, Eelco
On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron <echaudro@redhat.com> wrote: > On 23 Aug 2023, at 17:34, David Marchand wrote: > > > As reported by Ales, net/tap has broken support for checksum offloading. > > Fixes have been sent to the DPDK side, but waiting for the fixes, simply > > disable all conntrack related tests and some IPv6 tunnel tests. > > > > Signed-off-by: David Marchand <david.marchand@redhat.com> > I think we should make this series dependent on “netdev-dpdk: Disable net/tap Tx L4 checksum offloads.”, so this patch can be removed from the series. I don't think CI handles such dependencies, a easier way is to send a series with everything in it. Would that be ok for you?
David Marchand <david.marchand@redhat.com> writes: > On Fri, Aug 25, 2023 at 1:40 PM Eelco Chaudron <echaudro@redhat.com> wrote: >> On 23 Aug 2023, at 17:34, David Marchand wrote: >> >> > As reported by Ales, net/tap has broken support for checksum offloading. >> > Fixes have been sent to the DPDK side, but waiting for the fixes, simply >> > disable all conntrack related tests and some IPv6 tunnel tests. >> > >> > Signed-off-by: David Marchand <david.marchand@redhat.com> >> I think we should make this series dependent on “netdev-dpdk: >> Disable net/tap Tx L4 checksum offloads.”, so this patch can be >> removed from the series. +1 > > I don't think CI handles such dependencies, a easier way is to send a > series with everything in it. That is the only way currently. We previously discussed having a mechanism like depends-on / series_*, but there wasn't much interest in supporting it. The drawback of depends-on is that it pollutes the git commit log, and the drawback of developing on top of in-flight series is when a new version needs to be posted. > Would that be ok for you? That's probably the best approach assuming Ales is on board with folding it all into a single series.
diff --git a/tests/system-dpdk-macros.at b/tests/system-dpdk-macros.at index de126946a0..a01781b5a8 100644 --- a/tests/system-dpdk-macros.at +++ b/tests/system-dpdk-macros.at @@ -183,6 +183,15 @@ m4_define([OVS_CHECK_TCPDUMP], [AT_SKIP_IF([:])]) +# FIXME: disable some failing tests, waiting for a fix on net/tap in DPDK +m4_define([CHECK_CONNTRACK], + [AT_SKIP_IF([:])]) +m4_define([OVS_CHECK_GENEVE_UDP6ZEROCSUM], + [AT_SKIP_IF([:])]) +m4_define([OVS_CHECK_VXLAN_UDP6ZEROCSUM], + [AT_SKIP_IF([:])]) + + # Fake a veth by creating a tap on kernel side and plug it in OVS using the # net/tap DPDK driver. m4_define([ADD_VETH],
As reported by Ales, net/tap has broken support for checksum offloading. Fixes have been sent to the DPDK side, but waiting for the fixes, simply disable all conntrack related tests and some IPv6 tunnel tests. Signed-off-by: David Marchand <david.marchand@redhat.com> --- tests/system-dpdk-macros.at | 9 +++++++++ 1 file changed, 9 insertions(+)