| Message ID | 20230504173606.262663-2-ktraynor@redhat.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | netdev-dpdk: Apply device rx/tx descriptor limits. | expand |
| Context | Check | Description |
|---|---|---|
| ovsrobot/apply-robot | success | apply and check: success |
| ovsrobot/github-robot-_Build_and_Test | success | github build: passed |
On Thu, May 4, 2023 at 7:36 PM Kevin Traynor <ktraynor@redhat.com> wrote: > > There is no need to display 'requested_rx/tx_descriptors' and > 'configured_rx/tx_descriptors' as they will be the same. > > It simpler to just have a single 'n_rxq/txq_desc' value. It is* > > Suggested-by: Ilya Maximets <i.maximets@ovn.org> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com> Reviewed-by: David Marchand <david.marchand@redhat.com>
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index fb0dd43f7..2d9afc493 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -1741,12 +1741,6 @@ netdev_dpdk_get_config(const struct netdev *netdev, struct smap *args) if (dev->type == DPDK_DEV_ETH) { - smap_add_format(args, "requested_rxq_descriptors", "%d", - dev->requested_rxq_size); - smap_add_format(args, "configured_rxq_descriptors", "%d", - dev->rxq_size); - smap_add_format(args, "requested_txq_descriptors", "%d", - dev->requested_txq_size); - smap_add_format(args, "configured_txq_descriptors", "%d", - dev->txq_size); + smap_add_format(args, "n_rxq_desc", "%d", dev->rxq_size); + smap_add_format(args, "n_txq_desc", "%d", dev->txq_size); if (dev->hw_ol_features & NETDEV_RX_CHECKSUM_OFFLOAD) { smap_add(args, "rx_csum_offload", "true");
There is no need to display 'requested_rx/tx_descriptors' and 'configured_rx/tx_descriptors' as they will be the same. It simpler to just have a single 'n_rxq/txq_desc' value. Suggested-by: Ilya Maximets <i.maximets@ovn.org> Signed-off-by: Kevin Traynor <ktraynor@redhat.com> --- lib/netdev-dpdk.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)